Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

Looks good to me. With best regards. Petr. > On Jul 3, 2014, at 6:49 PM, Dmitriy Ermashov > wrote: > > Hi, > I've updated the webrev, so could you please review it? > http://cr.openjdk.java.net/~dermashov/8048246/webrev.02/ > > Last changes: > 1. Clipboard folder moved to datatransfer folder.

Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

Hi, I've updated the webrev, so could you please review it? http://cr.openjdk.java.net/~dermashov/8048246/webrev.02/ Last changes: 1. Clipboard folder moved to datatransfer folder. 2. Removed private fields/methods call from AddFlavorClipboard test 3. Test GetContentsInterruptedTest.java is a rep

Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

Hello, Dmitriy. As we do not have a Clipboard folder yet, could you please put Clipboard tests under java/awt/datatransfer/Clipboard so that all data transfer tests are in the same folder. AddFlavorTest:80 - here the test is using the private method via reflection. Please remove this part of th

Re: [9] Review request for 8044614: [macosx] Focus issue with 2 applets in firefox

On 7/3/2014 1:15 PM, dmitry markov wrote: Hi Alexandr, Thank you for review. For the use case you described - when we move back to the first browser window with 3 applets, the first applet (not the second one) will receive the focus. This behavior is incorrect, since the second applet should

Re: [7] Review request for 6993873: java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java test indicates ".a frame wasn't focused on click" jdk7 issue on linux

Hello, Anton. Please add an @Override annotation to the method. All the rest looks fine, the new webrev is not needed. With best regards. Petr. > On Jul 3, 2014, at 1:23 PM, Anton V. Tarasov wrote: > > Looks fine to me. > > Regards, > Anton. > > On 02.07.2014 22:36, anton nashatyrev wrote: >

Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

Hi all, Please review the updated version of tests to be colocated. http://cr.openjdk.java.net/~dermashov/8048246/webrev.01/ http://cr.openjdk.java.net/~dermashov/8048246/webrev.diff.01/ Last changes: 1. Removed 1 test from closed part. New GetContentsInterruptedTest.java is an up-to-date copy

Re: [7] Review request for 6993873: java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java test indicates ".a frame wasn't focused on click" jdk7 issue on linux

Looks fine to me. Regards, Anton. On 02.07.2014 22:36, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/6993873/7/webrev.00/ bug: https://bugs.openjdk.java.net

Re: [9] Review request for 8044614: [macosx] Focus issue with 2 applets in firefox

Hi Alexandr, Thank you for review. For the use case you described - when we move back to the first browser window with 3 applets, the first applet (not the second one) will receive the focus. This behavior is incorrect, since the second applet should receive the focus. I have updated the fix,