Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module

2014-12-16 Thread Alan Bateman
On 16/12/2014 18:29, Phil Race wrote: Yes .. no technical constraint there. Although I was pondering going further and seeing if we can actually remove the public method java.awt.peer.Peer Component.getPeer() since with the module system the peer package is not accessible and this is then even

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module

2014-12-16 Thread Phil Race
Yes .. no technical constraint there. Although I was pondering going further and seeing if we can actually remove the public method java.awt.peer.Peer Component.getPeer() since with the module system the peer package is not accessible and this is then even weirder than it is now .. as it effectiv

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module

2014-12-16 Thread Jim Graham
Stop using them and replace them with new package private methods and a cross-package accessor (similar to the SurfaceManager.ImageAccessor pattern)? What are the technical constraints preventing this? I think the getPeer() method used to be used by AWT applications to tell if an app was on t

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8067086: Suppress mac-specific deprecation warnings in the java.desktop module

2014-12-16 Thread Phil Race
Approved -phil. On 12/15/14 10:48 PM, joe darcy wrote: Hello, Please review this (hopefully) last change to suppress the deprecation warnings in the java.desktop module: 8067086: Suppress mac-specific deprecation warnings in the java.desktop module http://cr.openjdk.java.net/~darc

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module

2014-12-16 Thread joe darcy
Thanks for the review. Just one more fix to review to finish suppressing the deprecation warnings in the desktop module; please also see the review request for JDK-8067086: Suppress mac-specific deprecation warnings in the java.desktop module: http://mail.openjdk.java.net/pipermail/2d-dev/20

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module

2014-12-16 Thread Phil Race
Approved. We really need to figure out what to do about getPeer() - for this and for jigsaw .. -phil. On 12/16/2014 9:10 AM, joe darcy wrote: On 12/16/2014 3:15 AM, Alan Bateman wrote: On 16/12/2014 06:07, joe darcy wrote: Hello, Please review the next step of suppressing the deprecation

Re: JDK 9 RFR of JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module

2014-12-16 Thread joe darcy
On 12/16/2014 3:15 AM, Alan Bateman wrote: On 16/12/2014 06:07, joe darcy wrote: Hello, Please review the next step of suppressing the deprecation warnings the client libraries, this time in windows-specific desktop code: JDK-8067092: Suppress windows-specific deprecation warnings in t

Re: [9] Review Request: 7077826 Unset and empty DISPLAY variable is handled differently by JDK

2014-12-16 Thread Artem Ananiev
Hi, Sergey, it looks fine to me now. Thanks, Artem On 12/12/2014 5:30 PM, Sergey Bylokhov wrote: Hi, Artem. Thanks for review! The new version: http://cr.openjdk.java.net/~serb/7077826/webrev.01 On 10.12.2014 16:53, Artem Ananiev wrote: Hi, Sergey, the fix looks fine to me as well. Just a

Re: JDK 9 RFR of JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module

2014-12-16 Thread Alan Bateman
On 16/12/2014 06:07, joe darcy wrote: Hello, Please review the next step of suppressing the deprecation warnings the client libraries, this time in windows-specific desktop code: JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module http://cr.openjdk