Re: RFR: 8080317: Disable warning treated as error for signed/unsigned comparison in building splashscreen

2015-05-13 Thread David DeHaven
The changes look ok to me. -DrD- > On May 13, 2015, at 1:45 PM, Phil Race wrote: > > Warnings are now treated as errors by default. > I need a quick review on this from anyone who is available so I can fix our > build for integration... > > -phil. > > https://bugs.openjdk.java.net/browse/JD

Re: RFR: 8080317: Disable warning treated as error for signed/unsigned comparison in building splashscreen

2015-05-13 Thread David DeHaven
Adding Magnus -DrD- > On May 13, 2015, at 1:45 PM, Phil Race wrote: > > Warnings are now treated as errors by default. > I need a quick review on this from anyone who is available so I can fix our > build for integration... > > -phil. > > https://bugs.openjdk.java.net/browse/JDK-8080317 > >

RFR: 8080317: Disable warning treated as error for signed/unsigned comparison in building splashscreen

2015-05-13 Thread Phil Race
Warnings are now treated as errors by default. I need a quick review on this from anyone who is available so I can fix our build for integration... -phil. https://bugs.openjdk.java.net/browse/JDK-8080317 $ hg diff make/lib/Awt2dLibraries.gmk diff --git a/make/lib/Awt2dLibraries.gmk b/make/lib

internal API usage: sun.awt.CausedFocusEvent

2015-05-13 Thread Alan Snyder
I have been using sun.awt.CausedFocusEvent to implement special behavior in response to an explicit user-initiated focus traversal to a component. The main point is that I want to inhibit this behavior for all other kinds of focus gained events. Will there be some way of doing this in JDK9?

Re: Changes for JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

2015-05-13 Thread Alexander Kulyakhtin
Chris, Following the feedback from Jon Gibbons, we have changed our current plan to the following: 1) We are waiting till the new jtreg is promoted. The new jtreg allows for specifying in the repository's TEST.properties file one or more paths to search for libraries 2) After the jtreg is ou

Re: Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

2015-05-13 Thread Chris Hegarty
Alexander, > On 13 May 2015, at 16:46, Alexander Kulyakhtin > wrote: > > Hi Chris, > > >> I suspect that these changes are best going directly into jdk9/dev, as >> opposed to a a downstream forest. > Yes, they are going directly to jdk9/dev, I forgot to add the group, adding > now. > >> In

Re: Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

2015-05-13 Thread Alexander Kulyakhtin
Adding jdk9-dev mailing list - Original Message - From: alexander.kulyakh...@oracle.com To: core-libs-...@openjdk.java.net, awt-dev@openjdk.java.net, hotspot-...@openjdk.java.net Cc: stefan.sa...@oracle.com, yekaterina.kantser...@oracle.com, alan.bate...@oracle.com Sent: Wednesday, May 1

Re: Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

2015-05-13 Thread Alexander Kulyakhtin
Hi Chris, > I suspect that these changes are best going directly into jdk9/dev, as > opposed to a a downstream forest. Yes, they are going directly to jdk9/dev, I forgot to add the group, adding now. > In may places '@library /lib/testlibrary ...' remains. Is this > redundant, in many tests? I

Re: Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

2015-05-13 Thread Chris Hegarty
Hi Alexander, On 13/05/15 15:52, Alexander Kulyakhtin wrote: Hi, Could you please, review the following tests-only changes to the hs-rt/jdk and hs-rt/test repositories. These changes are a part of the changes for "JDK-8075327: Merge jdk and hotspot test libraries" I suspect that these chang

Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository

2015-05-13 Thread Alexander Kulyakhtin
Hi, Could you please, review the following tests-only changes to the hs-rt/jdk and hs-rt/test repositories. These changes are a part of the changes for "JDK-8075327: Merge jdk and hotspot test libraries" The changes are as follows: http://cr.openjdk.java.net/~akulyakh/8075327/jdk_patch/webrev/