Re: [9] Review Request: JDK-8080932 [TEST_BUG] Test java/awt/BasicStroke/DashStrokeTest.java fails with Bad script error due to improper @run notation

2015-06-04 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 6/3/2015 3:50 PM, pooja chopra wrote: Hi All , Please review below fix. Regards, Pooja On 5/22/2015 7:23 PM, pooja chopra wrote: Hello, Please review a fix for issue: 8080932 [TEST_BUG] Test java/awt/BasicStroke/DashStrokeTest.java fails

Re: [9] Review request for 8077686: OperationTimedOut exception inside from XToolkit.syncNativeQueue call on Ubuntu 15.04

2015-06-04 Thread Sergey Bylokhov
Looks fine. On 04.06.15 16:25, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8077686/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8077686 Looks like that moving window between two points isn't enough to avoid optimization, W

[9] Review request for 8077686: OperationTimedOut exception inside from XToolkit.syncNativeQueue call on Ubuntu 15.04

2015-06-04 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8077686/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8077686 Looks like that moving window between two points isn't enough to avoid optimization, With this fix we are moving a bit further :). -- Thanks, Ale

Re: [OpenJDK 2D-Dev] RFR: 8081315: 8077982 giflib upgrade breaks system giflib builds with earlier versions

2015-06-04 Thread Alexander Zvegintsev
Hi Andrew, We have removed a workaround[0] for interlaced images support, there is no need in it after 5.0.0 [1]: DGifSlurp() and EGifSpew() now read and write interlaced images properly. I didn't test it, but it seems to me that interlaced images will look bad after building against GIFLIB <

Re: [9] Review request for 8068886: IDEA IntelliJ crashes in objc_msgSend when an accessibility tool is enabled

2015-06-04 Thread Andrew Brygin
Hi Anton, the fix looks fine to me. Thanks, Andrew On 5/25/2015 1:57 PM, Anton Nashatyrev wrote: Hi Sergey, thanks for review! Could anybody else take a look at the fix? Thanks! Anton. On 15.05.2015 21:27, Sergey Bylokhov wrote: Hi, Anton. Thanks, the fix looks fine. I've sent yo

Re: [9] Review request for 8078606: Deadlock in awt clipboard

2015-06-04 Thread Andrew Brygin
Hi Anton, the change looks fine to me. Thanks, Andrew On 5/25/2015 3:46 PM, Alexander Zvegintsev wrote: Hello Anton, the fix looks fine to me. Thanks, Alexander. On 05/25/2015 02:04 PM, Anton Nashatyrev wrote: Hello, any volunteers? Thanks! Anton. On 08.05.2015 19:08, Anton Nashat