Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L&F on Win 8.1 with HiDPI display

I'll let someone familiar with how the AWT/Swing use all of those metrics respond on whether you've scaled all the right ones, but I wanted to make a minor comment about how the scaling is done. If you inverted it so that scale was 96f/dpi then you could use multiplication everywhere instead o

Re: [9] Review Request for 8130242: DataFlavorComparator transitivity exception

Transitivity (2) violated: X: java.awt.datatransfer.DataFlavor[mimetype=text/uri-list;representationclass=java.nio.ByteBuffer;charset=UTF-8], Y: java.awt.datatransfer.DataFlavor[mimetype=application/x-java-text-encoding;representationclass=java.io.InputStream], Z: java.awt.datatransfer.Dat

Re: [9] Review Request: 8130525 Build failure on jdk9-client solaris-sparcv9

Looks fine to me. Thanks, Alexander. On 07/06/2015 04:20 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. In the fix for JDK-7188942 I forgot to cleanup the mapfiles when I removed initPbuffer() method. Bug: https://bugs.openjdk.java.net/browse/JDK-8130525 Webrev can be fo

Re: [9] Review Request for 8130242: DataFlavorComparator transitivity exception

On 7/6/2015 2:17 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8130242 webrev: http://cr.openjdk.java.net/~ssadetsky/8130242/webrev.00/ Data transfer's flavor comparator violates transitivity. Could you give an example of DataF

[9] Review Request: 8130525 Build failure on jdk9-client solaris-sparcv9

Hello. Please review the fix for jdk9. In the fix for JDK-7188942 I forgot to cleanup the mapfiles when I removed initPbuffer() method. Bug: https://bugs.openjdk.java.net/browse/JDK-8130525 Webrev can be found at: http://cr.openjdk.java.net/~serb/8130525/webrev.00 -- Best regards, Sergey.

[9] Review Request for 8130242: DataFlavorComparator transitivity exception

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8130242 webrev: http://cr.openjdk.java.net/~ssadetsky/8130242/webrev.00/ Data transfer's flavor comparator violates transitivity. --Semyon

Re: [9] Review request for 8081787: [macosx] MalformedURLException is thrown during reading data for application/x-java-url; class=java.net.URL flavor

Hi Sergey, UnsupportedFlavorException is thrown because clipboard has something that can't be translated to application/x-java-url. You should copy link from Safari or copy file from finder, only then you will see MalformedURLException. So testing requires manual actions, because we need a co

Re: [9] Review Request: JDK-8080932 [TEST_BUG] Test java/awt/BasicStroke/DashStrokeTest.java fails with Bad script error due to improper @run notation

Thanks. On 7/2/2015 5:18 PM, Alexander Zvegintsev wrote: Hi, you already have two reviewers, it is sufficient to push. Anyway, the fix looks good to me. Thanks, Alexander. On 07/02/2015 10:28 AM, pooja chopra wrote: Hi All, Please review below fix. Regards, Pooja On 6/17/2015 12:05 PM, pooja

Re: [9] Review Request: JDK-8080953 [TEST_BUG]Test java/awt/FontClass/DebugFonts.java fails due to wrongly typed bugid

Thanks. On 7/2/2015 5:13 PM, Sergey Bylokhov wrote: +1 On 02.07.15 14:41, Alexander Zvegintsev wrote: Looks fine to me. Thanks, Alexander. On 07/02/2015 10:29 AM, pooja chopra wrote: Hi All, Please review below fix. Regards, Pooja On 6/17/2015 12:06 PM, pooja chopra wrote: Hi All , Gentle