AWT Dev [9] Review Request: 8129894 NSApplicationAWT.m:343:72: error: comparison of constant 777 with expression of type 'NSEventSubtype'

2015-07-09 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. This is the last issue, which prevents us to build the jdk on osx using the latest clang w/o --disable-warnings-as-errors. This code was integrated in http://cr.openjdk.java.net/~anashaty/8068886/webrev.00. The new clang complains that our constant is

Re: AWT Dev [9] Review Request: 8129894 NSApplicationAWT.m:343:72: error: comparison of constant 777 with expression of type 'NSEventSubtype'

2015-07-09 Thread Alexander Zvegintsev
Hello Sergey, the fix looks good to me. Thanks, Alexander. On 07/09/2015 01:49 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This is the last issue, which prevents us to build the jdk on osx using the latest clang w/o --disable-warnings-as-errors. This code was

Re: AWT Dev [8-dev] Review request for 8130752: Wrong changes were pushed with 8068886

2015-07-09 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/8/2015 3:22 PM, mikhail cherkasov wrote: Thank you. I believe one review is enough to such kind of fixes. On 7/8/2015 15:20, Sergey Bylokhov wrote: Looks fine. On 08.07.15 14:44, mikhail cherkasov wrote: Hello, Into jdk8 repository

Re: AWT Dev [9] Review Request: 8129894 NSApplicationAWT.m:343:72: error: comparison of constant 777 with expression of type 'NSEventSubtype'

2015-07-09 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/9/2015 2:58 PM, Alexander Zvegintsev wrote: Hello Sergey, the fix looks good to me. Thanks, Alexander. On 07/09/2015 01:49 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This is the last issue, which prevents us