Hello,
Please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8131752/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8131752
This fix simply restores fullscreen windows check. Actually fullscreen
is not necessary to change display mode,
but since I am planning to
It is unclear why it is unrelated, the stack trace from the bug:
java.lang.ExceptionInInitializerError
at sun.misc.Unsafe.ensureClassInitialized(Native Method)
at sun.awt.AWTAccessor.getKeyboardFocusManagerAccessor(AWTAccessor.java:966)
at
Hi, Alexander.
Why you did update of bugid in the test, but did not update the test
itself? Did the test fail before the fix?
On 22.07.15 16:44, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8132123
webrev:
The fix looks fine.
It is unclear why in previous fix the check for fullscreen window was
removed, but the check for fullscreen support not.
On 22.07.15 19:07, Alexander Zvegintsev wrote:
Hello,
Please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8131752/00/
for the issue
The fix looks good to me.
Thanks,
Alexandr.
On 7/22/2015 12:32 AM, Sergey Bylokhov wrote:
Hi, Semyon.
The fix looks good.
On 16.07.15 19:08, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8130769
webrev:
+1
Thanks,
Alexander.
On 07/22/2015 12:14 AM, Sergey Bylokhov wrote:
+1
On 21.07.15 21:24, Phil Race wrote:
Seems fine to me.
Since this is specification visible you will need an approved CCC
request before commiting the change.
-phil.
On 07/21/2015 07:49 AM, Alexander Scherbatiy wrote:
+1
Thanks,
Alexander.
On 07/22/2015 10:51 AM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/22/2015 12:32 AM, Sergey Bylokhov wrote:
Hi, Semyon.
The fix looks good.
On 16.07.15 19:08, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug:
+1
Thanks,
Alexander.
On 07/22/2015 11:49 AM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/22/2015 1:01 AM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
In the fix I replace the usage of the deprecated api in WListPeer.
Most of the
Hi, Semyon.
NPE occurs when we initialize KFM on the Toolkit thread, but this is
only a part of the bug, another issue is that we will use cached
keystrokes on the toolkit thread. But this keystrokes is bound to the
appcontext so we should not use objects which connect to the application
on
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8132123
webrev: http://cr.openjdk.java.net/~alexsch/8132123/webrev.00
The baseImageWidth/Height and Image.UndefinedProperty are returned to
not trigger base image creation in the MultiResolutionCachedImage.
The fix looks good to me.
Thanks,
Alexandr.
On 7/22/2015 1:01 AM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
In the fix I replace the usage of the deprecated api in WListPeer.
Most of the other cases in the bug description are related to
getPeer(), which was
Hi Sergey,
As you said there are 2 issues here. The first is about
KeyboardFocusManager initialization in the main event loop.
And the second about initialization of the KeyboardManagerManager itself
where keystrokes are shared between contexts.
Or do you mean if I remove the keystrokes
Please review this patch which cures a problem that appears since 9 b58
when the compiler was switched to VS2013 and as a result turned on the
High Entropy Virtual Addresses bit in the executable header when running
on Win 8.1.
With the high-entropy 64-bit address space layout randomization
Hi Alexey,
Looks fine to me.
Regards,
Anton.
On 21.07.2015 13:17, Alexey Ivanov wrote:
Hello AWT team,
Could you please review the following fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8130776
webrev: http://cr.openjdk.java.net/~aivanov/8130776/jdk9/webrev.00/
Description:
Hi Sergey,
From the process point of view it's better to fix the issue you've
found in another ticket. The failed test is not related to the
keystrokes caching.
So I suggest to push this fix as it is and file another JIRA for the
keystrokes.
--Semyon
On 7/22/2015 3:58 PM, Sergey Bylokhov
Looks fine.
Regards,
Anton.
On 22.07.2015 1:01, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
In the fix I replace the usage of the deprecated api in WListPeer. Most of the other cases in the
bug description are related to getPeer(), which was already removed.
The usage of
16 matches
Mail list logo
