Re: [9] Review Request for 8011616: JWindow.getLocation and JWindow.getLocationOnScreen return different values on Unity

2015-09-17 Thread Sergey Bylokhov
10.09.2015 19:26, Semyon Sadetsky пишет: I have added size assignment to the target component. Please review. http://cr.openjdk.java.net/~ssadetsky/8011616/webrev.01/ Probably we can get an accessor only once? this makes code a little bit compact and clear? --Semyon On 7/31/2015 9:28 PM,

Re: [9] Review Request for 8132664: closed/javax/swing/DataTransfer/DefaultNoDrop/DefaultNoDrop.java locks on Windows

2015-09-17 Thread Sergey Bylokhov
08.09.2015 19:17, Semyon Sadetsky wrote: On 9/8/2015 6:13 PM, Sergey Bylokhov wrote: On 08.09.15 18:02, Semyon Sadetsky wrote: On 9/8/2015 2:06 PM, Sergey Bylokhov wrote: On 08.09.15 13:42, Semyon Sadetsky wrote: On 9/8/2015 1:31 PM, Sergey Bylokhov wrote: On 08.09.15 13:15, Semyon Sad

Re: [9] Review Request for 8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9

2015-09-17 Thread Sergey Bylokhov
04.09.2015 10:54, Semyon Sadetsky wrote: Hi Sergey, I made the KeyboardFocusManager initialized lazy on the peer level. Maybe you'll find it more acceptable. http://cr.openjdk.java.net/~ssadetsky/8130895/webrev.01/ It is not possible to decouple KFM and the app context it belongs. Can you e

Re: [9] Review Request for 8079595: Resizing dialog which is JWindow parent makes JVM crash

2015-09-17 Thread Sergey Bylokhov
17.09.2015 8:33, Semyon Sadetsky wrote: On 9/16/2015 5:54 PM, Sergey Bylokhov wrote: 16.09.2015 17:07, Semyon Sadetsky wrote: Other scenarios do not cause conflicts. Or we cannot reproduce it right now? and for all these years... But we got regression only now, because we are calling it fro

Re: RFR: 8136570: Avoid setting environment variables related to /usr/dt

2015-09-17 Thread Stuart Marks
Doctor Deprecator approves. Not only is this a win because it's a pure-deletion change, it's a double win because it removes a side effect from a function that's supposed to "get" and initialize Java properties values. s'marks On 9/17/15 9:12 AM, Martin Buchholz wrote: Too late, I just comm

Re: RFR: 8136570: Avoid setting environment variables related to /usr/dt

2015-09-17 Thread Martin Buchholz
Too late, I just committed... If people have second thoughts, this change should be watered down rather than reverted anyways, so an independent followup change seems reasonable. On Thu, Sep 17, 2015 at 9:10 AM, Phil Race wrote: > +1 ( ie approved). May need a core-libs reviewer too ? > > -phil.

Re: RFR: 8136570: Avoid setting environment variables related to /usr/dt

2015-09-17 Thread Phil Race
+1 ( ie approved). May need a core-libs reviewer too ? -phil. On 9/16/2015 10:53 AM, Martin Buchholz wrote: Webrev regenerated http://cr.openjdk.java.net/~martin/webrevs/openjdk9/usr-dt-environment/usr-dt-environment.patch

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2015-09-17 Thread Hendrik Schreiber
>> >> I think it would be foolish to only support @2x and not also @3x, which has >> been supported by XCode for quite some time now. > >There is a performance issue that the Toolkit.getImage(url) needs to check > if @2x, @3x, ... exist for any given image. It especially takes a long time