On 10/20/2015 6:13 PM, Sergey Bylokhov wrote:
On 20.10.15 13:33, Semyon Sadetsky wrote:
On 10/19/2015 8:12 PM, Sergey Bylokhov wrote:
On 18.09.15 18:50, Semyon Sadetsky wrote:
Why do you think so? Each app context KFM has own keystrokes if it is
initialized from the thread that belongs to
Hi all,
Please review the fix. it requires to have two reviewer at least, so I
need one more reviewer for
this fix.
Thanks,
Mikhail.
On 10/19/2015 14:01, mikhail cherkasov wrote:
Sergey, thank you.
Alexander , could you please review the fix too?
Thanks,
Mikhail.
On 10/19/2015 13:51, Ser
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8073320/webrev.01/
- xform is concatenated with transform in SG2D.getResolutionVariant()
method
- imagepipe.transformImage() is used for drawImage(Image,
AffineTransform,...) case
- scale factors are made final in Bu
On 10/21/2015 4:36 PM, mikhail cherkasov wrote:
Hi all,
Please review the fix. it requires to have two reviewer at least, so I
need one more reviewer for
this fix.
It looks like the dragQueryFile(bytes) method can return null and we
can get NPE in the if(strings.length == 0) check in the
Is this is Windows specific issue only? If so, it is better to
replace EOL on window text peer side or may be even better to do it on
the native side before setting a text to the single-line RichEdit. May
be there are methods that can remove EOL from a string exactly in the
same way as it
Hi Alexander,
You are right, NPE can be thrown there, I added check for null.
A new webrev is being uploaded right now:
http://cr.openjdk.java.net/~mcherkas/8136763/webrev.03
Thanks,
Mikhail.
On 10/21/2015 16:42, Alexander Scherbatiy wrote:
On 10/21/2015 4:36 PM, mikhail cherkasov wrote:
Hi
The fix looks good to me.
Thanks,
Alexandr.
On 10/19/2015 12:37 AM, Sergey Bylokhov wrote:
On 16.10.15 13:56, Alexander Scherbatiy wrote:
On 10/6/2015 5:09 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9, I plan to backport it to jdk8.
In this fix some of synchronizat
I have two small suggestions:
- Probably it will be better to move the new properties from
Win32GraphicsDevice.java to SunGraphicsEnvironment.java, at least
"sun.java2d.uiScale" should be implemented on linux, and can be
implemented on osx later.
- I am worried about a rounding in
awt_Win32G
Thanks for clarification, the fix looks fine then.
On 21.10.15 10:16, Semyon Sadetsky wrote:
On 10/20/2015 6:13 PM, Sergey Bylokhov wrote:
On 20.10.15 13:33, Semyon Sadetsky wrote:
On 10/19/2015 8:12 PM, Sergey Bylokhov wrote:
On 18.09.15 18:50, Semyon Sadetsky wrote:
Why do you think so
Hi again,
And one more check was added:
http://cr.openjdk.java.net/~mcherkas/8136763/webrev.04/src/java.desktop/macosx/classes/sun/lwawt/macosx/CDataTransferer.java.udiff.html
Thanks,
Mikhail.
On 10/21/2015 17:09, mikhail cherkasov wrote:
Hi Alexander,
You are right, NPE can be thrown there
The fix looks good to me.
Thanks,
Alexandr.
On 10/21/2015 6:08 PM, mikhail cherkasov wrote:
Hi again,
And one more check was added:
http://cr.openjdk.java.net/~mcherkas/8136763/webrev.04/src/java.desktop/macosx/classes/sun/lwawt/macosx/CDataTransferer.java.udiff.html
Thanks,
Mikhail.
Thanks a lot!
On 10/21/2015 18:32, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 10/21/2015 6:08 PM, mikhail cherkasov wrote:
Hi again,
And one more check was added:
http://cr.openjdk.java.net/~mcherkas/8136763/webrev.04/src/java.desktop/macosx/classes/su
The fix looks good to me.
Thanks,
Alexandr.
On 10/21/2015 5:55 PM, Sergey Bylokhov wrote:
Thanks for clarification, the fix looks fine then.
On 21.10.15 10:16, Semyon Sadetsky wrote:
On 10/20/2015 6:13 PM, Sergey Bylokhov wrote:
On 20.10.15 13:33, Semyon Sadetsky wrote:
On 10/19/
Hello.
Please review the fix for jdk9.
The test emulate implementation of two applets inside one vm. It has two
threads in two different threads groups, for one of them it creates an
appcontext, and the test assumes that for the main thread the appcontext
will be created automatically. This as
Hi, Alexander.
Can you please clarify why this event flushing is necessary.
As far as I understand we have this sequence of calls:
performDragOperation:
-> handleDropMessage
-> postDropTargetEvent(,DISPATCH_SYNC)
-> postEvent to EDT
-> block Appkit untill event is not dispa
On 10/20/2015 12:23 PM, Alexander Scherbatiy wrote:
> On 10/13/2015 10:32 PM, Sebastian Sickelmann wrote:
>> On 10/08/2015 01:06 PM, Alexander Scherbatiy wrote:
>>>Are you going to push the fix as part of other fixes for different
>>> JDK areas or as a separate fix?
>>>In the second case yo
looks fine to me.
--
Thanks,
Alexander.
On 10/21/2015 07:32 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
The test emulate implementation of two applets inside one vm. It has
two threads in two different threads groups, for one of them it
creates an appcontext, and the te
17 matches
Mail list logo
