Re: Review request for 7035459: "java.lang.RuntimeException"

2016-01-12 Thread Ambarish Rapte
Hi Prem, The fix is fine, solves bug on windows and unix platform. As we discussed the test fails on MAC due to MAC specific behavior. Please raise separate bug for this MAC failure. Thanks, Ambarish -Original Message- From: Sergey Bylokhov Sent: Tuesday,

Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the end

2016-01-12 Thread Ambarish Rapte
Hi, Please review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-6180449 Webrev: http://cr.openjdk.java.net/~arapte/6180449/webrev.00/ Issue: When selecting text from right end towards left in TextArea and

Re: Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the end

2016-01-12 Thread prasanta sadhukhan
Look ok to me. Did you do the test in windows also? This message can be changed as it seems expected result is same for all platform, right? so why to mention mac differently Expected selected text: '1234 ' and for mac '1234'" On 1/12/2016 3:34 PM, Ambarish Rapte wrote: Hi,

Re: Review request for 7035459: "java.lang.RuntimeException"

2016-01-12 Thread Sergey Bylokhov
Looks fine. On 28/12/15 08:38, Prem Balakrishnan wrote: Hi, Please review fix for JDK9, *Bug:* https://bugs.openjdk.java.net/browse/JDK-7035459 *Webrev:* http://cr.openjdk.java.net/~arapte/prem/7035459/webrev.00/ *Issue:* Exception java.lang.RuntimeException: can not set focus on

Re: [9] Review Request for 8145784: https://bugs.openjdk.java.net/browse/JDK-8145784

2016-01-12 Thread Sergey Bylokhov
+1 On 23/12/15 18:47, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 12/23/2015 5:48 PM, Semyon Sadetsky wrote: The fix was changed because it is not possible to get individual screen windows under Xinerama correctly. Please, review the updated solution:

Re: RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

2016-01-12 Thread Chris Hegarty
Webrev updated in-place, moved to sun.awt.utli ( desktop module ) http://cr.openjdk.java.net/~chegar/8146735/ -Chris. On 11 Jan 2016, at 22:44, Chris Hegarty wrote: > >> On 11 Jan 2016, at 21:27, Mandy Chung wrote: >> >> On Jan 10, 2016,

Re: [9] Review Request for 8146162: [TEST_BUG] sun/awt/shell/ShellFolderMemoryLeak.java fails with Jigsaw

2016-01-12 Thread Sergey Bylokhov
+1 On 12/01/16 21:21, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 11/01/16 17:56, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8146162 webrev: http://cr.openjdk.java.net/~ssadetsky/8146162/webrev.00/

Re: [9] Review Request for 8146162: [TEST_BUG] sun/awt/shell/ShellFolderMemoryLeak.java fails with Jigsaw

2016-01-12 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 11/01/16 17:56, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8146162 webrev: http://cr.openjdk.java.net/~ssadetsky/8146162/webrev.00/ @modules corrected and

Re: RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

2016-01-12 Thread Mandy Chung
> On Jan 12, 2016, at 10:30 AM, Chris Hegarty wrote: > > Webrev updated in-place, moved to sun.awt.utli ( desktop module ) > > http://cr.openjdk.java.net/~chegar/8146735/ This looks fine. Good to see it moved to java.desktop. Mandy

Re: RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

2016-01-12 Thread Kevin Rushforth
I note that JavaFX optionally uses sun.misc.PerformanceLogger this in one place (via reflection). We'll need to file a new issue to clean this up. -- Kevin Mandy Chung wrote: On Jan 12, 2016, at 10:30 AM, Chris Hegarty wrote: Webrev updated in-place, moved to

Re: [9] Review Request: 8074165 Deprecate support for AppletViewer

2016-01-12 Thread Semyon Sadetsky
Should the message be internationalized? --Semyon On 12/25/2015 4:45 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This was requested by the deployment team. In this fix the text "AppletViewer is deprecated." was added to the output of appletviewer. Bug:

Re: Review-request for 8143227: Platform-Specific Desktop Features

2016-01-12 Thread Semyon Sadetsky
Hi Alexander, awt_Toolkit.cpp: case WM_WTSSESSION_CHANGE: { jclass clzz = env->FindClass("sun/awt/windows/WDesktopPeer"); DASSERT(clzz != NULL); if (!clzz) throw std::bad_alloc(); if (wParam == WTS_SESSION_LOCK || wParam == WTS_SESSION_UNLOCK) {

Re: [9] Review Request: 8074165 Deprecate support for AppletViewer

2016-01-12 Thread Sergey Bylokhov
I am not sure that I am able semantically correctly to translate this to other languages. Probably Naoto can help. ENG: "AppletViewer is deprecated." I need a translation to: de, es, fr, it, ja, ko, pt_BR, sv, zh_CN, zh_TW. Or we can use current version, which should be the usual notion of