Hello Alexandr,
WRT WindowResizingOnDPIChangingTest - I have quite similar manual test
on review:
http://mail.openjdk.java.net/pipermail/awt-dev/2016-January/010569.html
(but it requires two-display configuration).
Could these tests coexist later on? I hope they are not full duplicates.
(and
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8076545/webrev.05
- The awt_DesktopProperties.cpp file is updated to use scaleX for
width rescaling and scaleY for height rescaling
Thanks,
Alexandr.
On 2/1/2016 5:51 PM, Jim Graham wrote:
Hi Alexandr,
In awt_Des
The fix looks good to me.
Thanks,
Alexandr.
On 04/02/16 07:46, Prem Balakrishnan wrote:
Hi ,
Sorry my mistake.
Bug id in subject corrected 8062946.
Regards,
Prem
*From:*Alexandr Scherbatiy
*Sent:* Wednesday, February 03, 2016 8:44 PM
*To:* Prem Balakrishnan; Ambarish Rapte; Semyon Sade
There are just small comments about lines:
119 Graphics2D g = (Graphics2D) gr;
120 if (g != null) { g.drawImage(IMG, 0, 0, this); }
Is it necessary to cast the Graphics to Graphics2D because Graphics
also has drawImage(...) method?
Is it necessary to check the gr
On 05/02/16 12:59, Alexander Stepanov wrote:
Hello Alexandr,
WRT WindowResizingOnDPIChangingTest - I have quite similar manual test
on review:
http://mail.openjdk.java.net/pipermail/awt-dev/2016-January/010569.html
(but it requires two-display configuration).
Could these tests coexist later o
The fix looks good to me.
Thanks,
Alexandr.
On 22/12/15 14:20, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8139218
webrev: http://cr.openjdk.java.net/~ssadetsky/8139218/webrev.00/
The root cause: when window gain focus come for win
Thanks!
On 2/5/2016 1:55 PM, Alexander Scherbatiy wrote:
On 05/02/16 12:59, Alexander Stepanov wrote:
Hello Alexandr,
WRT WindowResizingOnDPIChangingTest - I have quite similar manual
test on review:
http://mail.openjdk.java.net/pipermail/awt-dev/2016-January/010569.html
(but it requires two
Hello Alexandr,
Thank you for the notes; yes, these lines are unnecessary. Please see
the updated patch:
http://cr.openjdk.java.net/~avstepan/8142861/webrev.04/
It should be also mentioned that for now the test is still failing
because of JDK-8143062. Should it be added to any exclude list?
The fix looks good to me.
On 05/02/16 15:59, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the notes; yes, these lines are unnecessary. Please see
the updated patch:
http://cr.openjdk.java.net/~avstepan/8142861/webrev.04/
It should be also mentioned that for now the test is still
Thank you!
On 2/5/2016 7:58 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
On 05/02/16 15:59, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the notes; yes, these lines are unnecessary. Please see
the updated patch:
http://cr.openjdk.java.net/~avstepan/8142861/webrev.0
Hi Alexandr,
awt_DesktopProperties.cpp, line 300 - is the "1.0f /" a typo?
Also, is there a still a need for the setFontProperty() variants that
don't have a scale as the last parameter?
...jim
On 2/5/2016 2:12 AM, Alexandr Scherbatiy wrote:
Could you review the upd
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8149151
webrev: http://cr.openjdk.java.net/~alexsch/8149151/webev.00
This is just an enhancement to use local GraphicsEnvironment instead
of nativec alls to get screen size in WToolkit.
It also allows to get
Looks OK to me.
-phil.
On 02/05/2016 11:52 AM, Alexandr Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8149151
webrev: http://cr.openjdk.java.net/~alexsch/8149151/webev.00
This is just an enhancement to use local GraphicsEnvironment ins
+1
ps: the correct link is:
http://cr.openjdk.java.net/~alexsch/8149151/webrev.00
On 05.02.16 23:00, Phil Race wrote:
Looks OK to me.
-phil.
On 02/05/2016 11:52 AM, Alexandr Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8149151
webrev:
14 matches
Mail list logo
