Re: RFE: Windows awt FileDialog in JDK9

2016-03-08 Thread Semyon Sadetsky
Hi Hendrik, I'm finding this enhancement reasonable. Not 100% sure that it may be included in the JDK9 first release since stabilization is the priority already. --Semyon On 3/7/2016 7:35 PM, Hendrik Schreiber wrote: Hey there, as far as I can tell, the Windows AWT FileDialog still uses the

Re: [9] RFR for 8142406: [TEST] MultiResolution image: need test to cover the case when @2x image is corrupted

2016-03-08 Thread Semyon Sadetsky
+1 --Semyon On 3/4/2016 8:25 PM, Sergey Bylokhov wrote: Looks fine. On 02.03.16 16:47, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8142406/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8142406 just a single test a

Re: Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField.

2016-03-08 Thread Ambarish Rapte
Hi Semyon, Please review the webrev.01, updated as per review comments http://cr.openjdk.java.net/~arapte/8149636/webrev.01/ Changes: 1. Added similar changes for TextArea. 2. Added automatic test to test over scroll. 3. T

Re: Review request for 6734341 : REGTEST fails: SelectionAutoscrollTest.html

2016-03-08 Thread Vikrant Agarwal
Hi All, Gentle Reminder, I need one more approval to push this fix. Best Regards, Vikrant -Original Message- From: Vikrant Agarwal Sent: Friday, March 04, 2016 11:01 AM To: Semyon Sadetsky; Sergey Bylokhov; awt-dev@openjdk.java.net; Alexander Scherbatiy Subject: Re: Review request for

Re: Taking screenshots on x11 composite desktop produce wrong result

2016-03-08 Thread Mario Torre
Hi Sergey, Here is a proposed fix for JDK9, it removes the dependencies on GTK and use only X11 calls: http://cr.openjdk.java.net/~neugens/8150954/webrev.02/ I only tried this on a RHEL 7.2 so far but it seems to compile and work as expected, and doesn't require to regenerate the configure machi

Re: [9] Review-request for 6353518: Creation of a WritableRaster with a custom DataBuffer causes erroneous Exception

2016-03-08 Thread Ambarish Rapte
Hi Ajit, The current changes look fine, In addition please check, if similar change is required when SampleModel is MultiPixelPackedSampleModel in the same createWritableRaster() method. Thanks, Ambarish From: Ajit Ghaisas Sent: Monday, March 07, 2016 1:51 PM To: awt