Re: RFE: Windows awt FileDialog in JDK9

On 3/11/2016 10:26 AM, Hendrik Schreiber wrote: On Mar 10, 2016, at 09:54, Semyon Sadetsky wrote: On 3/10/2016 10:22 AM, Hendrik Schreiber wrote: On Mar 10, 2016, at 07:26, Semyon Sadetsky wrote: In my opinion the switching to

Re: RFE: Windows awt FileDialog in JDK9

> On Mar 10, 2016, at 09:54, Semyon Sadetsky wrote: > > On 3/10/2016 10:22 AM, Hendrik Schreiber wrote: >>> On Mar 10, 2016, at 07:26, Semyon Sadetsky >>> wrote: >>> >>> In my opinion the switching to old/new file dialog should be

Re: [9] RFR for 8150643: [TEST] add test for JDK-8150176

Hello Sergey, > because setImageAutoSize is false by default. Could you please review the fix: http://cr.openjdk.java.net/~avstepan/8150643/fix.00/ If it is suitable, I'll push it after a test bug creation. Thanks, Alexander On 2/26/2016 8:34 PM, Sergey Bylokhov wrote: Just one additional

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/ - should pass on OS X after JDK-8151303 fix. 16x16 and 32x32 icons are used for the tab; the loop over L added. Thanks, Alexander On 3/10/2016 3:22 PM, Alexander Stepanov wrote:

Re: [9] RFR for 8151627 [TEST_BUG] fix test/java/awt/image/multiresolution/MultiResolutionRenderingHintsTest.java to run with Jake

Thanks! On 3/10/2016 5:14 PM, Yuri Nesterenko wrote: OK with me. -yan On 03/10/2016 05:13 PM, Sergey Bylokhov wrote: Looks fine. On 10.03.16 17:03, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8151627/webrev.00/ for

Re: [9] RFR for 8151627 [TEST_BUG] fix test/java/awt/image/multiresolution/MultiResolutionRenderingHintsTest.java to run with Jake

OK with me. -yan On 03/10/2016 05:13 PM, Sergey Bylokhov wrote: Looks fine. On 10.03.16 17:03, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8151627/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8151627 Thanks,

Re: [9] RFR for 8151627 [TEST_BUG] fix test/java/awt/image/multiresolution/MultiResolutionRenderingHintsTest.java to run with Jake

Looks fine. On 10.03.16 17:03, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8151627/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8151627 Thanks, Alexander -- Best regards, Sergey.

Re: [9] Review request for 8149849 [hidpi] DnD issues (cannot DnD from JFileChooser to JEditorPane or other text component) when scale > 1

Looks fine. Small typo in the test: * @test @bug 8149849 Probably the name of the test can be changed to something like HiDPIDrag etc. Does it work on all platforms? On 10.03.16 16:07, Alexandr Scherbatiy wrote: Hello, Could you review the fix: bug:

[9] RFR for 8151627 [TEST_BUG] fix test/java/awt/image/multiresolution/MultiResolutionRenderingHintsTest.java to run with Jake

Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8151627/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8151627 Thanks, Alexander

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

The fix looks good to me. Thanks, Alexandr. On 3/10/2016 3:05 AM, Rajeev Chamyal wrote: Hello Alexandr, Thanks for the review. Below is the updated webrev as per review comments. http://cr.openjdk.java.net/~rchamyal/8145173/webrev.03/

[9] Review request for 8149849 [hidpi] DnD issues (cannot DnD from JFileChooser to JEditorPane or other text component) when scale > 1

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8149849 webrev: http://cr.openjdk.java.net/~alexsch/8149849/webrev.00 Rescaling for native drag coordinates is added. Thanks, Alexandr.

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

Hello Alexandr, Thank you for the comment. Please note that: 1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L the tab's size is adjusted to the icon's size. L are:

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

Hello Alexandr, Thanks for the review. Below is the updated webrev as per review comments. http://cr.openjdk.java.net/~rchamyal/8145173/webrev.03/ Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 10 March 2016 11:39 To: Rajeev Chamyal; awt-dev@openjdk.java.net; Sergey

Re: [9] Review request for JDK-8145174 HiDPI splash screen support on Linux

Hello Sergey, Thanks for the review. HiDpi is not supported for Solaris in jdk. I will raise a new CR for naming convention shortly. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 10 March 2016 15:49 To: Alexandr Scherbatiy; Rajeev Chamyal;

Re: [9] Review request for JDK-8145174 HiDPI splash screen support on Linux

Looks fine. One of the last question: do we support hidpi on Solaris in jdk code? Do we have a separate CR to unify/specify all our .ext naming conversion?(@2, java-scale2x, etc). On 10.03.16 8:27, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 3/2/2016

Re: [9] RFR for 8151269: [TEST] add test covering getSource() method for multiresolution image

Thanks! On 3/9/2016 7:51 PM, Sergey Bylokhov wrote: +1 On 09.03.16 19:18, Alexander Scherbatiy wrote: The test looks good to me. Thanks, Alexandr. On 04/03/16 17:17, Alexander Stepanov wrote: Hello, Could you please review the following fix

Re: [9] Review Request for 8150535: [TEST_BUG] fix @library for test/java/awt/TrayIcon/MouseMovedTest/MouseMovedTest.java

Looks good. --Semyon On 3/10/2016 10:39 AM, Yuri Nesterenko wrote: Gentle unassuming reminder!! (I would also ask someone to push it to Jake upon approval). (Or, after ~b111, I'll push them myself) -yan On 02/29/2016 06:45 PM, Yuri Nesterenko wrote: Colleagues, please review this test-only

Re: RFE: Windows awt FileDialog in JDK9

On 3/10/2016 10:22 AM, Hendrik Schreiber wrote: On Mar 10, 2016, at 07:26, Semyon Sadetsky wrote: In my opinion the switching to old/new file dialog should be presented in more explicit way. The automatic fallback may cause unexpected behavior. May be it is worth