Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

On 03/22/2016 12:45 PM, Sergey Bylokhov wrote: On 22.03.16 22:21, Phil Race wrote: I don't get how JCK detected this problem unless there is a manual test that was verified visually This is the automated test, which sets the flag to false and expects that on OSX isDynamicLayoutActive() will a

Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

On 22.03.16 22:21, Phil Race wrote: I don't get how JCK detected this problem unless there is a manual test that was verified visually This is the automated test, which sets the flag to false and expects that on OSX isDynamicLayoutActive() will also return false. but here is what I think yo

Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

I don't get how JCK detected this problem unless there is a manual test that was verified visually but here is what I think you want the spec. to say :- /** * Returns whether dynamic layout of Containers on resize is currently * enabled on the underlying operating system and/or windo

Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

On 22.03.16 21:12, Phil Race wrote: On 03/22/2016 11:01 AM, Sergey Bylokhov wrote: That flag is used to determine the behaviour of isDynamicLayoutActive() If it is set to "false" then isDynamicLayoutActive() will always return false, (regardless of what the underlying platform is doing) If it i

Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

On 03/22/2016 11:01 AM, Sergey Bylokhov wrote: That flag is used to determine the behaviour of isDynamicLayoutActive() If it is set to "false" then isDynamicLayoutActive() will always return false, (regardless of what the underlying platform is doing) If it is set to "true" then isDynamicLayoutA

Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

On 22.03.16 20:26, Phil Race wrote: I don't see a problem with the words "has no effect". But I am apparently failing to understand the issue I agree that this API is quite cryptic. >The problem is that the method isDynamicLayoutActive() has no >description what happens if the OS support

Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

I don't see a problem with the words "has no effect". But I am apparently failing to understand the issue >The problem is that the method isDynamicLayoutActive() has no >description what happens if the OS supports(or nonsupports) the >feature, but the change of the state is not supported, which

Re: [9] Review Request for 8080395: consider making sun.awt.CausedFocusEvent functionality public

I am not sure that the latest version became better than previous one. The code became much more complicated but do we really solved the problem related to serialization? Will we support both directions when the data serialized/deserialized in jkd9/jdk8/jdk7 and so on. The readResolve() helped

Re:

> > I created an application in Visual Studio and try to check the returned icon > size. > It returns the same size 16 for both IDB_VIEW_SMALL_COLOR and > IDB_VIEW_LARGE_COLOR. Really? That would contradict the documentation. Unfortunately, I currently don’t have access to a working Visual Stu

Re:

On 3/22/2016 8:36 AM, Hendrik Schreiber wrote: On Mar 21, 2016, at 22:07, Alexandr Scherbatiy > wrote: On 3/18/2016 6:09 AM, Hendrik Schreiber wrote: On Mar 16, 2016, at 06:25, Alexandr Scherbatiy wrote: The JDK fixes should be pushed to the JDK

Re:

> On Mar 21, 2016, at 22:07, Alexandr Scherbatiy > wrote: > > On 3/18/2016 6:09 AM, Hendrik Schreiber wrote: >> On Mar 16, 2016, at 06:25, Alexandr Scherbatiy < >> alexandr.scherba...@oracle.com >> > wrote: >>> >>

Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

On 22.03.16 10:35, Semyon Sadetsky wrote: 213 * by the underlying operating system and/or window manager). Note that on 214 * platforms where dynamic layout during resizing is not supported (or is 215 * always supported) by the OS/WM, ({@code isDynamicLayoutSet()}) property 2

Re: [9] Review Request: 8151773 [macosx] TrayIcon.imageAutoSize property is ignored

On 22.03.16 9:54, Semyon Sadetsky wrote: The test instruction: > Please check if both of them have correct size and > the same colouring (white rectagle in a blue mount). In this case please push "Pass". It is unclear how does it test the fix? Correct/incorrect size criteria should be reveale

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

On 3/22/2016 12:43 AM, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145173/webrev.05/ With VC2010 java.c ::ShowSplashScreen fails with segmentation fault on calling free on scaled_splash_name . This failure is due to different C ru

[9] Review request for 8151333: Some AWT functions may access an array outside of its bounds

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8151333 webrev: http://cr.openjdk.java.net/~ssadetsky/8151333/webrev.00/ This just suppose to be a potential issue. It is discovered by AddressSanitizer. When Xinerama is used the number of screens that is seen by

Re: Review request for 8033936: java.awt.List events are not sent properly to handleEvent or ItemListener

Hi, Ambarish. Can you confirm this is regression of JDK-6806217 or not? add this information to the CR. On 18.03.16 11:34, Ambarish Rapte wrote: Hi, Please review the fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8033936 Webrev: http://cr.ope

Re: Review request for 8033936: java.awt.List events are not sent properly to handleEvent or ItemListener

Hi Prasanta, Thanks for the review. The test class is extended from Frame, hence call to dispose works. PerformTest is called twice for the below two scenarios, 1. To test Event received by List's parent Frame's handleEvent() -> Calle

Re: Review request for 8033936: java.awt.List events are not sent properly to handleEvent or ItemListener

FIx looks ok to me. But in testcase, there is no dispose() method but you are still calling dispose(). Also, why there is a need to call performTest() twice? Regards Prasanta On 3/18/2016 2:04 PM, Ambarish Rapte wrote: Hi, Please review the fix for JDK9, Bug:

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145173/webrev.05/ With VC2010 java.c ::ShowSplashScreen fails with segmentation fault on calling free on scaled_splash_name . This failure is due to different C runtime used by libjli and lib splashScreen. Fix

Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

213 * by the underlying operating system and/or window manager). Note that on 214 * platforms where dynamic layout during resizing is not supported (or is 215 * always supported) by the OS/WM, ({@code isDynamicLayoutSet()}) property 216 * has no effect. Not sure that it