Re: [9] Push request for 8151136: [macosx] According to the description, the case is failed

2016-04-26 Thread Manajit Halder
Hi Rajeev, Could you please push the patch to JDK9 with the following details: http://cr.openjdk.java.net/~arapte/manajit/8151136/webrev.00/ 8151136: [macosx] According to the description, the case is failed Reviewed-by: ssadetsky,

Re: RFR(XS): 8155156: Remove remaining sun.misc.* imports from the jdk repo

2016-04-26 Thread Chris Hegarty
On 26 Apr 2016, at 18:33, Volker Simonis wrote: > Hi, > > can I please have a review for this trivial change: > > http://cr.openjdk.java.net/~simonis/webrevs/2016/8155156/ > https://bugs.openjdk.java.net/browse/JDK-8155156 Thank you Volker. Reviewed. -Chris. > The fix for "8153737: Unsuppo

RFR(XS): 8155156: Remove remaining sun.misc.* imports from the jdk repo

2016-04-26 Thread Volker Simonis
Hi, can I please have a review for this trivial change: http://cr.openjdk.java.net/~simonis/webrevs/2016/8155156/ https://bugs.openjdk.java.net/browse/JDK-8155156 The fix for "8153737: Unsupported Module" moved sun.misc to the jdk.unsupported module and removed sun.misc.* imports. Unfortunately

Fwd: Re: JDK 9 pre-review of JDK-6850612: Deprecate Class.newInstance since it violates the checked exception language contract

2016-04-26 Thread joe darcy
Phil and other client reviewers, Please review this change from core libs which impacts client libs implementations. In brief, deprecating a method in core reflection requires uses of that method to have a @SuppressWarnings("deprecation") annotation. The typical way to minimize the scope of th

Re: [9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

2016-04-26 Thread Semyon Sadetsky
On 4/26/2016 3:49 PM, Philip Race wrote: > In applications one may need to know the reason why focus is requested I do not mean why should apps want to *know* the cause. I am asking why apps should be able to *specify* the cause as proposed by this change. Being "symmetric" is not a sufficie

Re: Review Request For 8129569 : Test java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails

2016-04-26 Thread Ramesh Gangadhar
Hi All, Gentle remainder for one more review for this code change Thank you Ambarish. Best Regards, Ramesh BG From: Ambarish Rapte Sent: Wednesday, April 20, 2016 12:43 To: Ramesh Gangadhar; awt-dev@openjdk.java.net Subject: RE: Review Request For 8129569 : Test java/awt/Frame/

Re: [9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

2016-04-26 Thread Philip Race
> In applications one may need to know the reason why focus is requested I do not mean why should apps want to *know* the cause. I am asking why apps should be able to *specify* the cause as proposed by this change. Being "symmetric" is not a sufficient reason. -phil. On 4/26/16, 12:27 AM, Se

Re: [9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

2016-04-26 Thread Avik Niyogi
Hi Manajit, This fix looks good to me. With Regards, Avik Niyogi > On 25-Apr-2016, at 5:11 pm, Semyon Sadetsky > wrote: > > Hi Manajit, > > Thank you for the exhaustive explanation. Then I'd suggest to file a bug to > add VK_ALT_GRAPH mapping on Windows and OS X. > > The fix looks good to

Re: [9] Review Request: 7124381 DragSourceListener.dragDropEnd() never been called on completion of dnd operation

2016-04-26 Thread Semyon Sadetsky
+1 --Semyon On 4/26/2016 12:36 PM, Yuri Nesterenko wrote: +1 -yan On 04/25/2016 07:27 PM, Sergey Bylokhov wrote: Hello. Please review the small cleanup for jdk9. I was not able to reproduce the test failure(osx/windows) described in the bug, but during validation of the test I found that th

Re: [9] Review Request: 7124381 DragSourceListener.dragDropEnd() never been called on completion of dnd operation

2016-04-26 Thread Yuri Nesterenko
+1 -yan On 04/25/2016 07:27 PM, Sergey Bylokhov wrote: Hello. Please review the small cleanup for jdk9. I was not able to reproduce the test failure(osx/windows) described in the bug, but during validation of the test I found that the test can fail on linux+some specific themes, when the title

Re: [9] Review request for JDK-8151787 Unify the HiDPI splash screen image naming convention

2016-04-26 Thread Alexandr Scherbatiy
On 4/26/2016 11:13 AM, Rajeev Chamyal wrote: Hello All, Could you please review the following fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8151787 Webrev : http://cr.openjdk.java.net/~rchamyal/8151787/webrev.00/ This is a s

[9] Review request for JDK-8151787 Unify the HiDPI splash screen image naming convention

2016-04-26 Thread Rajeev Chamyal
Hello All, Could you please review the following fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8151787 Webrev : http://cr.openjdk.java.net/~rchamyal/8151787/webrev.00/ This is a small enhancement to support similar HiDPI splash screen image name convention on all platforms. C

Re: [9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

2016-04-26 Thread Semyon Sadetsky
On 4/25/2016 10:33 PM, Phil Race wrote: You will need to convince me of the appropriateness of opening these methods. It seems to me that are for the focus system, not for applications. Why should an application be allowed to say "I would like component X" to receive focus and tell it the reaso