Re: Review fix for 8154328: [TEST_BUG] java/awt/TrayIcon/ActionEventTest/ActionEventTest.java

Looks fine. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 05 May 2016 16:01 To: Ambarish Rapte; Semyon Sadetsky; Prasanta Sadhukhan; Ajit Ghaisas; awt-dev@openjdk.java.net Subject: Re: Review fix for 8154328: [TEST_BUG] java/awt/TrayIcon/ActionEventTest/Action

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

Hi Volker, 1) adding awt-dev. Semyon did the review on swing but really it should always (and mainly!) have been awt. 2) Yes, this ought to be pushed to 9-client, specifically not 9-dev. Assuming it goes to 9-dev we may need to deal with conflicts. Also if it causes any kind of problem with 9-

[9] Review Request: 8155071 AppletViewer should print the deprecation warning that the Applet API is deprecated

Hello, Please review the fix for jdk9. One more iteration of AppletViewer deprecation, the message was changed to warn the users that Applet API is deprecated also. I am not sure should I file the ccc for this change or not. Bug: https://bugs.openjdk.java.net/browse/JDK-8155071 Webrev can be f

Re: [9] Review request for 8080729: [macosx] java 7 and 8 JDialogs on multiscreen jump to parent frame on focus

Hi AWT team, I used the next test to reproduce the problem = OwnedWindowTest.java == public class OwnedWindowTest { public static void main(String[] args) { SwingUtilities.invokeLater(new Runnable() { @Override public void run() { fin

Re: Review request for 6429675: getMaximumsize() size of the frame less than the minimumsize of Frame.

Looks fine. On 29.04.16 17:09, Ambarish Rapte wrote: Hi, Please review the fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-6429675 Webrev: http://cr.openjdk.java.net/~arapte/6429675/webrev.00/ Issue: 1. setMaximumSize(

Re: Review request for 6384991: TrayIcon ActionListener called at wrong time

look fine On 28.04.16 19:56, Ambarish Rapte wrote: Hi Prasanta, Thanks for the review I have updated the test case as per the review comments. Also updated test case with few more scenarios & Os specific conditions. Please review the updated webrev.01, http://cr.openjdk.java.net/~arapte/6

Re: Review fix for 8154328: [TEST_BUG] java/awt/TrayIcon/ActionEventTest/ActionEventTest.java

looks fine On 29.04.16 18:00, Ambarish Rapte wrote: Hi, Please review fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-8154328 Webrev: http://cr.openjdk.java.net/~arapte/8154328/webrev.00/ Below three problems are fixed with the

Re: [8u/9] Review request: [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m

Looks fine. On 05.05.16 10:50, Anton Tarasov wrote: Hello, Please, review a simple fix: webrev: http://cr.openjdk.java.net/~ant/JDK-8156116/jdk9/webrev.0 bug: https://bugs.openjdk.java.net/browse/JDK-8156116 Thanks, Anton. -- Best regards, Sergey.

Re: Review request for 8155742 : [Windows] robot.keyPress(KeyEvent.VK_ALT_GRAPH) throws java.lang.IllegalArgumentException in windows

Looks fine. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 04 May 2016 20:13 To: Ambarish Rapte; Semyon Sadetsky; Prasanta Sadhukhan; Rajeev Chamyal; awt-dev@openjdk.java.net Subject: Re: Review request for 8155742 : [Windows] robot.keyPress(KeyEvent.VK_ALT_GRAP

[8u/9] Review request: [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m

Hello, Please, review a simple fix: webrev: http://cr.openjdk.java.net/~ant/JDK-8156116/jdk9/webrev.0 bug: https://bugs.openjdk.java.net/browse/JDK-8156116 Thanks, Anton.