+1
On 16.05.16 8:40, prasanta sadhukhan wrote:
Hi Ambarish,
Looks good. I guess there is no harm in putting the comments in other 2
TextField constructor too as those 2 also calls
public TextField(String text, int columns)
. Also, do not forget to add "noreg-doc" in bug label as there is no
t
Hi, Prem.
On 11.05.16 15:28, Prem Balakrishnan wrote:
1. Dialog background color set to SystemColor.control.
Can you please confirm that background color for other
components(Button, Canvas, Window for example) is not changed after this.
2. WWindowPeer extends WPanelPeer, WPanelPeer Initia
Looks fine.
On 14.05.16 4:46, Daniil Titov wrote:
Thank you all for reviewing these changes. Per Stuart's recommendations I've
updated the documentation.
Please review the new version of the fix.
Webrev : http://cr.openjdk.java.net/~dtitov/8155785/webrev.01/
Bug: https://bugs.openjdk.java.net/
Hi Prasanta,
Thanks for the review.
Regarding the other two constructors, These 2 constructors do
not take any direct argument as text to be set on TextField.
Internally these APIs call the public TextField(String text,
int columns) cons
Revisions look good. Thanks.
s'marks
On 5/13/16 6:46 PM, Daniil Titov wrote:
Thank you all for reviewing these changes. Per Stuart's recommendations I've
updated the documentation.
Please review the new version of the fix.
Webrev : http://cr.openjdk.java.net/~dtitov/8155785/webrev.01/
Bug: ht
Ok. looks good to go then.
Regards
Prasanta
On 5/16/2016 7:38 PM, Ambarish Rapte wrote:
Hi Prasanta,
Thanks for the review.
Regarding the other two constructors, These 2 constructors do not take
any direct argument as text to be set on TextField.
Internally these APIs call the public TextF
Reminder!
Regards,
Muneer
From: Muneer Kolarkunnu
Sent: Thursday, May 12, 2016 5:19 PM
To: awt-dev@openjdk.java.net
Subject: Review request for 8153184: BorderLayout javadoc says
current version of JDK is 1.2
Hi All,
Please review the fix for bug 8153184,
Looks good to me. But the testcase has no bearing to this bug and should
be removed and "noreg-doc" label needs to be added to bugreport.
Also, a ccc needs to be raised for this.
Regards
Prasanta
*From:*Muneer Kolarkunnu
*Sent:* Thursday, May 12, 2016 5:19 PM
*To:* awt-dev@openjdk.java.net
*Su
