[9] Review Request for 8157137: [PIT] [TEST_BUG] compilation failed for some tests from jdk/test/java/awt/mixing/AWT_Mixing (can't find Helper)

Colleagues, please review this test-only fix for JDK-8157137 CR: https://bugs.openjdk.java.net/browse/JDK-8157137 Webrev: http://cr.openjdk.java.net/~yan/8157137/webrev.00/ The reason these tests worked for me was, I had all necessary compiled files in my repo clones on all test machines. To re

Re: [9] Review Request for 8157137: [PIT] [TEST_BUG] compilation failed for some tests from jdk/test/java/awt/mixing/AWT_Mixing (can't find Helper)

Looks good to me. --Semyon On 14.07.2016 11:00, Yuri Nesterenko wrote: Colleagues, please review this test-only fix for JDK-8157137 CR: https://bugs.openjdk.java.net/browse/JDK-8157137 Webrev: http://cr.openjdk.java.net/~yan/8157137/webrev.00/ The reason these tests worked for me was, I had

[ping] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi, could someone please have a look at this? It's L, but the change is only one line in a lot of tests ... Thanks! Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Donnerstag, 7. Juli 2016 17:01 > To: 'awt-dev@openjdk.java.net' ; swing- > d...@openjdk.java.net; '2d-dev' <

Re: [9] Fix for JDK-8159956 : EXCEPTION_ACCESS_VIOLATION in sun.awt.windows.ThemeReader.getThemeMargins

Looks good to me. --Semyon On 14.07.2016 09:52, Ajit Ghaisas wrote: Thanks Phil. I have updated the test as discussed. Here is the updated webrev. http://cr.openjdk.java.net/~aghaisas/8159956/webrev.01/ Regards, Ajit *From:*Phi

Re: [9] Review Request for 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)

Hi Semyon, The fix looks good to me. Thanks, Alexander. On 07/13/2016 01:28 PM, Semyon Sadetsky wrote: Please review an updated version of the fix: http://cr.openjdk.java.net/~ssadetsky/8036915/webrev.02/ The solution was completely changed. The frame insets correction algorithm is revised

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

> On 14 Jul 2016, at 06:25, David Holmes wrote: > > The bug report for this is confidential but quite simply all of the little > tweaks and knobs we added to the open build and source files to support the > Java SE Embedded product no longer need to be there for JDK 9. Many of them > have alr

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

The fix looks good to me. Thanks, Alexandr. On 7/12/2016 2:47 PM, Manajit Halder wrote: Hi Alexandr, Thank you for the review comments. Code is modified as per you suggestion. RobotUtilities class is replaced with direct calls to corresponding methods in Robot class and also Util class is us

Re: [9] Review Request for 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)

The fix looks good to me. Thanks, Alexandr. On 7/14/2016 2:47 PM, Alexander Zvegintsev wrote: Hi Semyon, The fix looks good to me. Thanks, Alexander. On 07/13/2016 01:28 PM, Semyon Sadetsky wrote: Please review an updated version of the fix: http://cr.openjdk.java.net/~ssadetsky/8036915/we

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

Hello Mikhail, just double checking: now that 2 reviewers have approved the patch, do you need anything extra from me to be able to commit and push the patch ? Or can I assume that this patch will get checked in ? Robin On Wed, Jul 13, 2016 at 10:29 AM, Alexandr Scherbatiy < alexandr.scherba...@

Re: [9] Fix for JDK-8159956 : EXCEPTION_ACCESS_VIOLATION in sun.awt.windows.ThemeReader.getThemeMargins

+1 -phil. On 07/13/2016 11:52 PM, Ajit Ghaisas wrote: Thanks Phil. I have updated the test as discussed. Here is the updated webrev. http://cr.openjdk.java.net/~aghaisas/8159956/webrev.01/ Regards, Ajit *From:*Philip Race *Sent

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

On 14/07/2016 05:25, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to support the Java SE Embedded product no longer need to be there for JDK 9. Many of them have already been removed

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

Thanks for the review Alan! David On 15/07/2016 6:52 AM, Alan Bateman wrote: On 14/07/2016 05:25, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to support the Java SE Embedded produc

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

Thanks for the review Paul! David On 14/07/2016 11:12 PM, Paul Sandoz wrote: On 14 Jul 2016, at 06:25, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to support the Java SE Embedde