Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

Better, although it still does not document the supported set of scale name extensions that we discussed/proposed off-line. -phil. On 8/18/16, 5:39 AM, Rajeev Chamyal wrote: Hello Phil, Thanks for the review. Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8151787/web

Re: [9] Review Request: 8164104 Cleanup of javaclient related mapfiles

On 8/17/16, 6:33 AM, Sergey Bylokhov wrote: Tested on solarisX64/solarisSparc/linuxX64 no issues were found(SwingSet2/Java2Demo). Sounds good. +1 But I wonder why the text on solarissparc filled by yellow shadow(Is it a known issue)? Yes there is an open bug. I believe it is a SPARC (or mor

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

Hello Phil, Thanks for the review. Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8151787/webrev.02/ Updated file src/java.base/share/classes/sun/launcher/resources/launcher.properties Regards, Rajeev Chamyal From: Phil Race Sent: 16 August 2016 22:28 To

Re: [9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

Hi Sergey, Thank you for the review. I have modified the code as per your comment. http://cr.openjdk.java.net/~mhalder/8156099/webrev.02/ Thanks, Manajit > On 18-Aug-2016, at 2:58 pm, Sergey Bylokhov > wrote: > > Looks fine. > please c

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

Added "2d-dev" team for review Regards, Prem From: Alexandr Scherbatiy Sent: Thursday, August 18, 2016 2:57 PM To: Prem Balakrishnan; Rajeev Chamyal; awt-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWind

Re: [9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

Looks fine. please change the title of the frame to some text related to this fix, instead of "Updating TrayIcon Popup Menu Item Test" On 14.08.16 23:50, Manajit Halder wrote: Hi Sergey, Thank you for your review comments. I have modified the code as per your first two comments. For the last

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

Could you also send the review to the 2d-dev alias? Thanks, Alexandr. On 8/18/2016 9:59 AM, Prem Balakrishnan wrote: Hi Alexandr, AccelSurface is implemented by *ONLY* D3DSurfaceData and OGLSurfaceData classes, Both of these classes extend SurfaceData as well. Hence, casting of 'as' varia

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

Hi Alexandr, AccelSurface is implemented by *ONLY* D3DSurfaceData and OGLSurfaceData classes, Both of these classes extend SurfaceData as well. Hence, casting of 'as' variable which is of type AccelSurface object to SurfaceData is always VALID. Regards, Prem From: Alexandr Scherbatiy