Re: [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

Hi Sergey, It could be, but actually RuntimePermission is used by eawt(sure we can change it too, but I don't see a point) Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8164536/01/ -- Thanks, Alexander. On 30.08.2016 22:44, Sergey Bylokhov wrote: Hi, Alexander.

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

I agree that the @return tags need to be filled in. In the first descriptive sentence of the delegation methods, note that "{@code getBaseImage()}" is a reference to a function and not an object, so it sounds like the methods are implemented as "return getBaseImage()" which is not valid because

Re: [9] Review request for 8159432: [hidpi] Linux: display-wise scaling factor issues

Why in X11GraphicsDevice.java we cannot call initScaleFactor() directly without isUIScaleEnabled() check like we do on win/osx? The same check is made inside this method. On 30.08.16 16:26, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JD

Re: RFR: 8164899: Provide package access to setComponentMixingCutoutShape

Looks fine. On 27.08.16 0:47, Phil Race wrote: bug : https://bugs.openjdk.java.net/browse/JDK-8164899 webrev: http://cr.openjdk.java.net/~prr/8164899/ Transitional support for this API in jigsaw mode. It is not public but it is more accessible than it was .. -phil. -- Best regards, Sergey.

Re: [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

Hi, Alexander. Probably the name of this permission can be added to AWTPermissions.java? I am not sure why some of the methods require "canProcessApplicationEvents" permission. For example Taskbar.getTaskbar()? I guess Desktop.getDesktop() is used a template but it does not throw such exception

[9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

Hello, Please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8164536/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8164536 This fix add check for canProcessApplicationEvents runtime permission(currently used by eawt) for Desktop and Taskbar classes. -- Thanks, Alex

Re: [9] Review request for 8161910: [PIT] regression: HW/LW mixing seems broken on Unity

Sorry for inconvenience, but I have to update this fix once again. http://cr.openjdk.java.net/~ssadetsky/8161910/webrev.02 I have found the main root cause of the issue. In the 8036815 I have missed one insets_corrected = true; statement in the RaparentNotify handler. In my new Unity algo for

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

On 8/30/2016 6:18 PM, Anton Tarasov wrote: Hi Semyon, On 8/29/2016 9:08 PM, Semyon Sadetsky wrote: On 8/29/2016 8:29 PM, Anton Tarasov wrote: Hi Semyon, As I wrote in JIRA, the problem is caused by the fact that a native window (for a modal dialog) is shown before the peer starts to show.

Re: [9] Review request for 8159432: [hidpi] Linux: display-wise scaling factor issues

The fix looks good to me. The bug id in the email subject should be updated to 8163100. Thanks, Alexandr. On 8/30/2016 4:26 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8163100 webrev: http://cr.openjdk.java.net/~ssadetsky/8163

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

Hi Semyon, On 8/29/2016 9:08 PM, Semyon Sadetsky wrote: On 8/29/2016 8:29 PM, Anton Tarasov wrote: Hi Semyon, As I wrote in JIRA, the problem is caused by the fact that a native window (for a modal dialog) is shown before the peer starts to show. (This seems strange, and you can investigate

[9] Review request for 8159432: [hidpi] Linux: display-wise scaling factor issues

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8163100 webrev: http://cr.openjdk.java.net/~ssadetsky/8163100/webrev.00/ - UI scale listener is added to track system scale changes in Java. - Support for individual monitor scale is removed in case of Xinerama

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

On 8/30/2016 12:17 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. *http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/* I believe the @return tag should

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/ Thank you in advance. With Regards, Avik Niyogi > On 29-Aug-2016, at 5:55 pm, Alexa

Re: [9] Review request for 8050478: [macosx] Cursor not updating correctly after closing a modal dialog

Thank you very much, Sergey! Looking for a second +1 from someone else. Thanks, Dmitry > On 29 Aug 2016, at 18:53, Sergey Bylokhov wrote: > > Looks fine. > > On 25.08.16 13:53, Dmitry Markov wrote: >> Hi Sergey, >> >> I have updated the fix based on your suggestion, (i.e. add a new >> method).