Looks fine.
Regards,
Ajit
From: Prem Balakrishnan
Sent: Monday, October 24, 2016 3:16 PM
To: Ajit Ghaisas; Alexander Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net
Subject: RE: Review Request : JDK-8168292 [TestBug]Test
java/awt/TrayIcon/DragEventSource/DragEventSource.java fails
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8147440/webrev.01/
- an undecorated frame does not set WWindowPeer.sysX/Y/W,H values so
the fix is updated to retrieve a window bounds form the target
- the html test file is removed
Thanks,
Alexandr.
O
On 25.10.16 14:11, Alexandr Scherbatiy wrote:
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8147440/webrev.01/
- an undecorated frame does not set WWindowPeer.sysX/Y/W,H values so
the fix is updated to retrieve a window bounds form the target
Why this fields is n
On 20.10.16 10:04, Semyon Sadetsky wrote:
The same is necessary for the user code. Look at the spec you propose:
63 /**
64 * The Shift key modifier constant.
65 *
66 * @deprecated It is recommended that SHIFT_DOWN_MASK be used
instead.
67 */
68 @Deprecated
+1
On 25.10.16 9:43, Ambarish Rapte wrote:
Hi Ajit,
The change looks good.
Regards,
Ambarish
*From:*Ajit Ghaisas
*Sent:* Monday, October 24, 2016 3:42 PM
*To:* Semyon Sadetsky; Sergey Bylokhov; awt-dev@openjdk.java.net;
Ambarish Rapte
*Subject:* Fix for JDK-8168470 : [TES
On 10/25/2016 5:41 PM, Sergey Bylokhov wrote:
On 20.10.16 10:04, Semyon Sadetsky wrote:
The same is necessary for the user code. Look at the spec you propose:
63 /**
64 * The Shift key modifier constant.
65 *
66 * @deprecated It is recommended that SHIFT_DOWN_MASK b
+1
--Semyon
On 10/25/2016 6:00 PM, Sergey Bylokhov wrote:
+1
On 25.10.16 9:43, Ambarish Rapte wrote:
Hi Ajit,
The change looks good.
Regards,
Ambarish
*From:*Ajit Ghaisas
*Sent:* Monday, October 24, 2016 3:42 PM
*To:* Semyon Sadetsky; Sergey Bylokhov; awt-dev@openjdk.
Please see the updated webrev:
http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/02/
Thanks,
Alexander.
On 10/11/16 5:00 PM, Alexander Zvegintsev wrote:
Hi Sergey,
Please see the updated webrev:
http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/01/
As I can observe other windows such as
On 20.10.16 9:36, Semyon Sadetsky wrote:
The code which you tried to revert if not correct. The previous change
was done as a fix for HiDPI support. Lots of our code depends from the
XWindow.scaleUp/scaleDown/getScale which ware implemented on top of
graphicsConfig. If it was not updated then thi
Hi Prem,
+1 to 8168292 but one thing is that this issue is created to enable to
work on 8168291 and was mentioned that the problem DragEventSource fails
on osx will be addressed as part of 8168292 which I do not see being
done in your webrev.
So, either open up 8168291 or fix it in this bug.
10 matches
Mail list logo