Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-25 Thread Ajit Ghaisas
Looks fine. Regards, Ajit From: Prem Balakrishnan Sent: Monday, October 24, 2016 3:16 PM To: Ajit Ghaisas; Alexander Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net Subject: RE: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails

Re: [9] Review request for 8147440 HiDPI (Windows): Swing components have incorrect sizes after changing display resolution

2016-10-25 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8147440/webrev.01/ - an undecorated frame does not set WWindowPeer.sysX/Y/W,H values so the fix is updated to retrieve a window bounds form the target - the html test file is removed Thanks, Alexandr. O

Re: [9] Review request for 8147440 HiDPI (Windows): Swing components have incorrect sizes after changing display resolution

2016-10-25 Thread Sergey Bylokhov
On 25.10.16 14:11, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8147440/webrev.01/ - an undecorated frame does not set WWindowPeer.sysX/Y/W,H values so the fix is updated to retrieve a window bounds form the target Why this fields is n

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

2016-10-25 Thread Sergey Bylokhov
On 20.10.16 10:04, Semyon Sadetsky wrote: The same is necessary for the user code. Look at the spec you propose: 63 /** 64 * The Shift key modifier constant. 65 * 66 * @deprecated It is recommended that SHIFT_DOWN_MASK be used instead. 67 */ 68 @Deprecated

Re: Fix for JDK-8168470 : [TEST_BUG] @test missed in java/awt/Window/ChangeWindowResizabilty/ChangeWindowResizabiltyTest.java

2016-10-25 Thread Sergey Bylokhov
+1 On 25.10.16 9:43, Ambarish Rapte wrote: Hi Ajit, The change looks good. Regards, Ambarish *From:*Ajit Ghaisas *Sent:* Monday, October 24, 2016 3:42 PM *To:* Semyon Sadetsky; Sergey Bylokhov; awt-dev@openjdk.java.net; Ambarish Rapte *Subject:* Fix for JDK-8168470 : [TES

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

2016-10-25 Thread Semyon Sadetsky
On 10/25/2016 5:41 PM, Sergey Bylokhov wrote: On 20.10.16 10:04, Semyon Sadetsky wrote: The same is necessary for the user code. Look at the spec you propose: 63 /** 64 * The Shift key modifier constant. 65 * 66 * @deprecated It is recommended that SHIFT_DOWN_MASK b

Re: Fix for JDK-8168470 : [TEST_BUG] @test missed in java/awt/Window/ChangeWindowResizabilty/ChangeWindowResizabiltyTest.java

2016-10-25 Thread Semyon Sadetsky
+1 --Semyon On 10/25/2016 6:00 PM, Sergey Bylokhov wrote: +1 On 25.10.16 9:43, Ambarish Rapte wrote: Hi Ajit, The change looks good. Regards, Ambarish *From:*Ajit Ghaisas *Sent:* Monday, October 24, 2016 3:42 PM *To:* Semyon Sadetsky; Sergey Bylokhov; awt-dev@openjdk.

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-10-25 Thread Alexander Zvegintsev
Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/02/ Thanks, Alexander. On 10/11/16 5:00 PM, Alexander Zvegintsev wrote: Hi Sergey, Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/01/ As I can observe other windows such as

Re: [9] Review request for 8163101: dual-screen issue with JMenu, JPopupMenu

2016-10-25 Thread Sergey Bylokhov
On 20.10.16 9:36, Semyon Sadetsky wrote: The code which you tried to revert if not correct. The previous change was done as a fix for HiDPI support. Lots of our code depends from the XWindow.scaleUp/scaleDown/getScale which ware implemented on top of graphicsConfig. If it was not updated then thi

Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-25 Thread Prasanta Sadhukhan
Hi Prem, +1 to 8168292 but one thing is that this issue is created to enable to work on 8168291 and was mentioned that the problem DragEventSource fails on osx will be addressed as part of 8168292 which I do not see being done in your webrev. So, either open up 8168291 or fix it in this bug.