Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-28 Thread Sergey Bylokhov
On 25.11.16 17:08, Semyon Sadetsky wrote: Then JDK-8013116 was fixed the request for specification update was created: https://bugs.openjdk.java.net/browse/JDK-8033128 Different coordinate system simply means different coordinate origins. This is the most natural behavior for the robot created f

Re: [9] Review request for 8165705: Robot.createScreenCapture produces black screenshot on Oracle Linux 7.1

2016-11-28 Thread Sergey Bylokhov
On 24.11.16 22:24, Semyon Sadetsky wrote: Having an extra unspecified functionality on which application can depends is not better, it is also slower, and during evaluation of bugs it will be necessary to know that this can be switched at runtime. I don't believe that it may affect performance e

Re: [9] Review request for 8169589: [macosx] Activating a JDialog puts to back another dialog

2016-11-28 Thread Sergey Bylokhov
Hi, Dmitry. As far as I understand the orderAboveSiblingsImpl() is execute on the appkit thread? if yes, then you should not call target.getOwnedWindows() on it, because it can be overridden by the user. You should call "getOwnedWindows_NoClientCode" via accessor, or get a list of child window

Re: [9] Review request for 8166683: On macOS (Mac OS X) getting a ScreenMenuBar when not running "com.apple.laf.AquaLookAndFeel"

2016-11-28 Thread Sergey Bylokhov
Looks fine, but here is some of my thoughts: Since we tries to provide some kind of public API, I suggest to double check the solution again. In fact we tried to provide a support of the global menu on osx for all our L&Fs. - Is it necessary to reference the Aqua from the shared code? in varia

Re: [9] Review request for 8166683: On macOS (Mac OS X) getting a ScreenMenuBar when not running "com.apple.laf.AquaLookAndFeel"

2016-11-28 Thread Semyon Sadetsky
Looks good. --Semyon On 11/15/2016 5:39 PM, Alexander Zvegintsev wrote: Hi Sergey, I've not found casting issues, but I've found the issue when previous fix does not treat dynamically changed "apple.laf.useScreenMenuBar" property correctly. (e.g. ScreenMenuBarInputTwice test fails). So

Re: [9] Review Request: 4419271 Provide support for scrolling-mechanisms of non-mouse input-devices

2016-11-28 Thread Sergey Bylokhov
On 28.11.16 18:01, Sergey Malenkov wrote: The fix looks good, but we realized that the direction is not always changed. For example, Windows from VirtualBox on Mac. Does it mean that it works differently than in the native apps? That can be a virtualbox issue: https://forums.virtualbox.org/vi

Re: [9] Review Request: 4419271 Provide support for scrolling-mechanisms of non-mouse input-devices

2016-11-28 Thread Sergey Malenkov
The fix looks good, but we realized that the direction is not always changed. For example, Windows from VirtualBox on Mac. -jint scrollLines = 3; +jint toScroll = 3; -UINT platformLines; +UINT platformUnits; Also I prefer to use similar names for this variables as before. For exa

Re: [9] fix for JDK-8134612 :clipboard.getData(dataFlavor) can throw UnsupportedFlavorException for registered data flavor

2016-11-28 Thread Ajit Ghaisas
Thanks Alex for the review comments. As suggested, I have updated the test which results in the call to DataTransferer.constructFlavoredObject() method. Here is the new webrev. http://cr.openjdk.java.net/~aghaisas/8134612/webrev.01/ Note: 1. If the test in this webrev is run - it

Re: [9] Review request for 8169589: [macosx] Activating a JDialog puts to back another dialog

2016-11-28 Thread Alexey Ivanov
Hi Dmitry, Looks fine to me. Regards, Alexey On 28.11.2016 14:53, dmitry markov wrote: Hi Alexey, I have updated the fix based on your suggestions. Please find new webrev here: http://cr.openjdk.java.net/~dmarkov/8169589/webrev.02/ Thanks, Dmitry On 28/11/2016 12:51, Alexey Ivanov wrote:

Re: [9] Review request for 8169589: [macosx] Activating a JDialog puts to back another dialog

2016-11-28 Thread dmitry markov
Hi Alexey, I have updated the fix based on your suggestions. Please find new webrev here: http://cr.openjdk.java.net/~dmarkov/8169589/webrev.02/ Thanks, Dmitry On 28/11/2016 12:51, Alexey Ivanov wrote: Hi Dmitry, If you expand imports 31 import java.awt.*; you'll be able to use java.util.

Re: [9] Review request for 8169589: [macosx] Activating a JDialog puts to back another dialog

2016-11-28 Thread Alexey Ivanov
Hi Dmitry, If you expand imports 31 import java.awt.*; you'll be able to use java.util.List via import: 1123 java.util.List pwChildWindows = new ArrayList(Arrays.asList(w.getOwnedWindows())); Actually you don't need this local variable as well as new ArrayList object: you can

Re: [9] Review Request: 8165769 Hang in the help menu item

2016-11-28 Thread Alexey Ivanov
Hi Semyon, Sergey, On 17.11.2016 11:27, Semyon Sadetsky wrote: On 16.11.2016 20:54, Sergey Bylokhov wrote: On 16.11.16 20:25, Semyon Sadetsky wrote: The example above produce the same result as if the thread B will call dispatchEventImpl() early than addItemListener() was called by thread A.