Re: [9] Review Request: 4419271 Provide support for scrolling-mechanisms of non-mouse input-devices

I approve On Tue, Dec 6, 2016 at 4:21 AM, Sergey Bylokhov wrote: > Hi, Sergey. > Please take a look to the updated version (the names are updated): > http://cr.openjdk.java.net/~serb/4419271/webrev.03 > >> 28 нояб. 2016 г., в 7:01, Sergey Malenkov

Re: [9] Review request for 8166683: On macOS (Mac OS X) getting a ScreenMenuBar when not running "com.apple.laf.AquaLookAndFeel"

Actually there is no need in this property, this behavior can be disabled for other L by setting apple.laf.useScreenMenuBar property to false. http://cr.openjdk.java.net/~azvegint/jdk/9/8166683/03/ the fix is also reworked to remove mac specific stuff from shared code. Thanks, Alexander. On

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

I didn't eyeball what you changed but JPRT is now happy. The build passes on all platforms... -phil. On 12/5/16, 2:47 PM, Lindenmaier, Goetz wrote: Hi Phil, sorry for that! I fixed it, there is an other occurrence, too. I double checked all the casts, there was also a mp_flags<-> mp_sign

Re: [9] Review Request: 4419271 Provide support for scrolling-mechanisms of non-mouse input-devices

Hi, Sergey. Please take a look to the updated version (the names are updated): http://cr.openjdk.java.net/~serb/4419271/webrev.03 > 28 нояб. 2016 г., в 7:01, Sergey Malenkov написал(а): > > The fix looks good, but we realized that the direction is not always changed. > For

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Hi Phil, sorry for that! I fixed it, there is an other occurrence, too. I double checked all the casts, there was also a mp_flags <-> mp_sign wrong in mpi.c http://cr.openjdk.java.net/~goetz/wr16/8170525-awt-dev/webrev.05/ (Also rebased the change) Best regards, Goetz > -Original

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

I tried it .. and just as well I did. It fails in the crypto code on Mac. jdk/src/jdk.crypto.ec/share/native/libsunec/impl/ec.c:261:12: error: expression which evaluates to zero treated as a null pointer constant of type 'mp_digit *' (aka 'unsigned long *')

Re: OS X - Java Native Foundation

> On Dec 4, 2016, at 8:54 PM, serb wrote: > > Hello, Michael. > > You can find the source of these macro in the JNFJNI.h which is a part of > "Java Native Foundation»: > /System/Library/Frameworks/JavaVM.framework/Frameworks/JavaNativeFoundation.framework/ Using