On 30/10/2018 22:30, Prasanta Sadhukhan wrote:
What is the syntax of this? I tried
-nativepath:
but it gave "unexpected exit from test code"
Can we put this option in the test itself in @run option? since we do not run
with nativepath option neither in PIT not in test sprint, it will always f
That adds what I suggested, but I had also suggested you leave in what you
had added as it also adds some protection.
Additionally I read the MS docs and they do explain the 131071 return value.
The message this code is sending is LB_ITEMFROMPOINT and the docs say here
https://docs.microsoft.com
+1
-Phil.
On 10/31/18 12:53 PM, Ambarish Rapte wrote:
Thanks Phil & Sergey for review comments,
Please take a look at updated webrev:
http://cr.openjdk.java.net/~arapte/8198001/webrev.02/
Regards,
Ambarish
*From:*Phil Race
*Sent:* Wednesday, October 31, 2018 12:58 AM
*To:* Ambarish Rapte
Thanks Phil & Sergey for review comments,
Please take a look at updated webrev:
http://cr.openjdk.java.net/~arapte/8198001/webrev.02/
Regards,
Ambarish
From: Phil Race
Sent: Wednesday, October 31, 2018 12:58 AM
To: Ambarish Rapte ; awt-dev@openjdk.java.net
Subject: Re: [12] RFR : JDK-8
Hi Phil & Sergey,
This issue was introduced with the fix for HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-6806217"JDK-6806217, in 7b55, which
modified AwtList::HandleEvent(), so It was not observed with JDK6.
Please review the updated change as discussed offline:
http
Even though I'm still not convinced about the need of imposing partial
order sync on asynchronous events, we can do it.
Here it's Webrev.03 that includes partial ordering of non-SequencedEvent
events and Sergey's unit test:
* http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.03/
Also robot.setAutoDelay() can be used instead of a list of .delay()
+I suggest to add robot.waitForIdle after the createAndShowGUI,
because it can be slow operation on the slow systems.
On 31/10/2018 04:59, Krishna Addepalli wrote:
Hi Shashi,
1. Please add "@key headful" to the test.
2. I don’
Hi Martin,
Le mer. 31 oct. 2018 à 17:03, Martin Balao a écrit :
> Hi Sergey,
>
> Your MultipleContextsUnitTest test has 2 assertions that don't look good
> to me:
>
> * dispatchSENumber < num1
> * dispatchSENumber < num2
>
> My understanding is that these assertions mean that a non-SequencedEv
Changed the targeted review version to 12.
Regards,
Manajit
On 31/10/18 10:09 PM, Manajit Halder wrote:
Hi Dmitry/Sergey,
I have a different fix for this issue in Mac OS specific code. In this
proposed fix I am trying to fix the window addition/ordering with
respect to the screen on which t
Hi Dmitry/Sergey,
I have a different fix for this issue in Mac OS specific code. In this
proposed fix I am trying to fix the window addition/ordering with
respect to the screen on which the window is created. As per my
debugging this issue was introduced while fixing JDK-8080729. The
problem
Hi, Martin.
On 31/10/2018 09:03, Martin Balao wrote:
Your MultipleContextsUnitTest test has 2 assertions that don't look good to me:
* dispatchSENumber < num1
* dispatchSENumber < num2
My understanding is that these assertions mean that a non-SequencedEvent event
is expected to be synchron
Hi Sergey,
Your MultipleContextsUnitTest test has 2 assertions that don't look good to
me:
* dispatchSENumber < num1
* dispatchSENumber < num2
My understanding is that these assertions mean that a non-SequencedEvent
event is expected to be synchronized with SequencedEvent events. If such
synch
+1
On 30/10/2018 07:05, Thomas Stüfe wrote:
Seems fine and trivial.
Regards, Thomas
On Tue, Oct 30, 2018 at 2:56 PM Volker Simonis wrote:
Hi,
can I please have a review for the following tiny change which fixes
the license header on a few AIX-specific files:
http://cr.openjdk.java.net/~si
Hi Sergey,
You are right, the support for “apple.awt.documentModalShee” property is
incomplete. If the property is set for a window, the window appears as a sheet
but it is not attached to its owner. I have opened JDK-8213197 [1] for this.
Thanks,
Dmitry
[1] - https://bugs.openjdk.java.net/bro
Hi Shashi,
1. Please add "@key headful" to the test.
2. I don’t think you need to replace the waitForIdle call with delay. You may
choose to add delay in addition to waitForIdle.
3. Minor nit: replace () -> createAndShowGUI() with method reference.
Thanks,
Krishna
-Original Message-
Fro
Hi Manajit, Sergey,
we use a swing dialog-based implementation in our product. I believe the
current terms and behaviour could be improved.
There are some collision in terms. To be a document-modal in AWT means to
block "all windows from the same document except those from its child
hierarchy". T
Hi All, Please review test fix for the below bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-6849922
Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/
Fix: As the initial bug analysis said in the bug comments, it is a
timing issue where in the choice menu remains opened ev
> So at some point the code, where isInAquaSession() is used in the
launcher, will be removed.
Great!
On Tue, Oct 30, 2018 at 9:17 PM Sergey Bylokhov
wrote:
> Hi, Denis.
> It is not possible to avoid duplication from the implementation point of
> view, because these two libraries should not dep
Also consider adding it for bug7154841, bug8007006.java.
-Original Message-
From: Krishna Addepalli
Sent: Wednesday, October 31, 2018 1:35 PM
To: Jayathirth D V ; Sergey Bylokhov
Cc: awt-dev@openjdk.java.net; Igor Ignatyev
Subject: Re: [12] Review Request: 8211822 and 8202886
Hi Serg
Hi Sergey,
Could you update the test use @requires tag, instead of relying on Platform for
NSTexturedJFrame.java?
This would probably make the test skip faster on non-Mac platforms.
Thanks,
Krishna
-Original Message-
From: Jayathirth Rao
Sent: Wednesday, October 31, 2018 12:25 PM
To:
Changing it to "strings" sounds fine.
Pre-approved.
-phil.
On 10/30/18, 6:41 PM, Sergey Bylokhov wrote:
This one looks odd :
+ * Each element of the array should be a set of three {@code Strings}
Since there is no class called "Strings".
Is that how plurals are handled in other parts of t
21 matches
Mail list logo
