Re: RFR 8213532: add missing LocalFree calls after using FormatMessage(A) [windows]

2018-11-13 Thread Baesken, Matthias
Hi Sergey, thanks for the review ! Could I have a second review please, before I push the change ? Best regards, Matthias > -Original Message- > From: Sergey Bylokhov > Sent: Freitag, 9. November 2018 21:50 > To: Baesken, Matthias ; awt- > d...@openjdk.java.net > Subject: Re: RFR 8

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018-11-13 Thread Shashidhara Veerabhadraiah
All swing components has accessibility info associated with it. But how those information is received thro' AT matters. For ex., one can use the control+option(system accessibility shortcuts) on the progress bar demo but you can't use it in the option pane demo. You can't reach 'show input dial

Re: OpenJdk11-28-EA JDialog hanging

2018-11-13 Thread Krishna Addepalli
+1   Krishna   From: Laurent Bourgès Sent: Tuesday, November 13, 2018 2:18 PM To: Martin Balao Cc: awt-dev@openjdk.java.net Subject: Re: OpenJdk11-28-EA JDialog hanging   Hi, Sergey approved the webrev.4, anyone else?   I would like this bug fix to be pushed soon, then this RFR.   Re

Re: OpenJdk11-28-EA JDialog hanging

2018-11-13 Thread Sergey Bylokhov
It looks fine, I have run internal tests jck/regression and no new issues were found. Thank you for contribution. On 13/11/2018 10:24, Martin Balao wrote: Sergey, Are we okay to go with Webrev.04? Thanks, Martin.- On Tue, Nov 13, 2018 at 5:47 AM, Laurent Bourgès wrote: Hi, Sergey approved

Re: RFR: 8213614 DnD operation change feature does not work with 64bit big endian CPU

2018-11-13 Thread Sergey Bylokhov
This change looks fine, I'll push it if there are no any objections. BTW we have some other places where we use the similar approach: "(int)Native.getLong()", I assume we need to update it also? On 09/11/2018 04:01, Ichiroh Takiguchi wrote: Hello, IBM would like to contribute this patch to Open

Re: Review request for: JDK-8213292 Input freezes after MacOS key-selector (press&hold) usage on macOS Mojave

2018-11-13 Thread Sergey Bylokhov
Looks fine. On 08/11/2018 01:40, Alexey Ushakov wrote: I’ve checked the fix on 10.13. Looks like it works as well. So, here is updated webrev: http://cr.openjdk.java.net/~avu/JDK-8213292/webrev.01 Best Regards, Alexey On 8 Nov 2018, at 01:12, Sergey Bylokhov mailto:sergey.bylok...@oracle.co

Re: OpenJdk11-28-EA JDialog hanging

2018-11-13 Thread Martin Balao
Sergey, Are we okay to go with Webrev.04? Thanks, Martin.- On Tue, Nov 13, 2018 at 5:47 AM, Laurent Bourgès wrote: > Hi, > Sergey approved the webrev.4, anyone else? > > I would like this bug fix to be pushed soon, then this RFR. > > Regards, > Laurent > > Le ven. 9 nov. 2018 à 14:50, Laurent B

Re: OpenJdk11-28-EA JDialog hanging

2018-11-13 Thread Laurent Bourgès
Hi, Sergey approved the webrev.4, anyone else? I would like this bug fix to be pushed soon, then this RFR. Regards, Laurent Le ven. 9 nov. 2018 à 14:50, Laurent Bourgès a écrit : > Dear Martin & Sergey, > > I just tested webrev.03 on latest openjdk12 and it passed my tests: good > job ! > (I a

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

2018-11-13 Thread Manajit Halder
Hi All, Gentle remainder. Please review this fix. Regards, Manajit On 08/10/18 10:27 AM, Krishna Addepalli wrote: Looks fine. Krishna *From:*Manajit Halder *Sent:* Thursday, October 4, 2018 6:01 PM *To:* Krishna Addepalli ; awt-dev@openjdk.java.net *Subject:* Re: [12] Review request for