Re: [OpenJDK 2D-Dev] [12] Review Request: 8213110 Remove the use of applets in automatic tests

2018-11-26 Thread Sergey Bylokhov
The "ProblemList.txt" is updated in the new version: http://cr.openjdk.java.net/~serb/8213110/webrev.04 On 08/11/2018 10:57, Sergey Bylokhov wrote: Note that for some of the tests I'll need to update the problem list and replace the .html by the .java. But since we actively updates the problem

Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

2018-11-26 Thread Sergey Bylokhov
Hi, Krishna. I added the closing "" tag, since it wouldn't hurt and the tool was reporting it. But this tag is unused in our code, is not required by html5 and it was not reported in the bug report. So I suggest to do not add them. As for the style spec, thanks for your suggestion, I have

RFR: 8214298 Add non interactive test case for JDK-8211267

2018-11-26 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Issue: JDK-8211267 requires non interactive test case Bug:https://bugs.openjdk.java.net/browse/JDK-8214298 Change: https://cr.openjdk.java.net/~itakiguchi/8214298/webrev.00/ I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan,

RFR: X11 default visual support for IM status window on VNC

2018-11-26 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212677 Change: https://cr.openjdk.java.net/~itakiguchi/8212677/webrev.00/ Screen shots are in JDK-8212677. I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-06-21

RFR: 8212676 AIX's CDE/MWM support

2018-11-26 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212676 Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/ Test instructions and screen shots are in JDK-8212676. GUI environment for AIX platform still needs CDE support. This fix is required to

Re: [12] RFR 8213583: Error while opening the JFileChooser when desktop contains shortcuts pointing to deleted files

2018-11-26 Thread Alexey Ivanov
Hi Dmitry, The fix looks fine to me. Regards, Alexey On 26/11/2018 10:38, Dmitry Markov wrote: Hello, Could you review a fix for jdk12, please? bug: https://bugs.openjdk.java.net/browse/JDK-8213583 webrev: http://cr.openjdk.java.net/~dmarkov/8213583/webrev.00/ Problem description: On Window

Re: [12] RFR 8213583: Error while opening the JFileChooser when desktop contains shortcuts pointing to deleted files

2018-11-26 Thread Krishna Addepalli
Hi Dmitry, Thanks for fixing this issue. The change looks fine. Thanks, Krishna From: Dmitry Markov Sent: Monday, November 26, 2018 4:09 PM To: awt-dev@openjdk.java.net Subject: [12] RFR 8213583: Error while opening the JFileChooser when desktop contains shortcuts pointing to delete

[12] RFR 8213583: Error while opening the JFileChooser when desktop contains shortcuts pointing to deleted files

2018-11-26 Thread Dmitry Markov
Hello, Could you review a fix for jdk12, please? bug: https://bugs.openjdk.java.net/browse/JDK-8213583 webrev: http://cr.openjdk.java.net/~dmarkov/8213583/webrev.00/ Prob

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018-11-26 Thread Shashidhara Veerabhadraiah
Thank you Alexey for the detailed reply below. The issue is closed as non-issue now. Thanks and regards, Shashi -Original Message- From: Alexey Ivanov Sent: Saturday, November 24, 2018 12:10 AM To: Shashidhara Veerabhadraiah ; Sergey Bylokhov ; Krishna Addepalli Cc: awt-dev@openjdk.j