Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi Sergey, I checked the code with only /EHs - which says: "The exception-handling model that catches synchronous (C++) exceptions only and tells the compiler to assume that functions declared as extern "C" may throw an exception." With this, our code compiles, so here is the modified webrev: h

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Since I added string.h and its related code for manipulating the path, I encountered this warning. The standard way to deal with this is to specify /EHsc, which is to enable catching of asynchronous exceptions. https://docs.microsoft.com/en-us/previous-versions/1deeycx5(v=vs.140) And my text

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Since I added string.h and its related code for manipulating the path, I encountered this warning. The standard way to deal with this is to specify /EHsc, which is to enable catching of asynchronous exceptions. https://docs.microsoft.com/en-us/previous-versions/1deeycx5(v=vs.140) Thanks, Krishn

[12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms

Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8214918 Webrev: http://cr.openjdk.java.net/~serb/8214918/webrev.00 In the fix for JDK-8076313 I need to implement possibility of switch between xinerama and non-xinerama modes at runtime. As a separate part I

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

On 06/12/2018 01:10, Krishna Addepalli wrote: Hi Sergey, I got this error while compiling: warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc. I couldn't immediately figure out how to specify that option, so I disabled that warning (4530). Now I corr

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi Sergey, I got this error while compiling: warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc. I couldn't immediately figure out how to specify that option, so I disabled that warning (4530). Now I corrected this as well as making the filePath a loc

Re: [12] RFR 8213983: [macosx] Keyboard shortcut “cmd +`” stops working properly if popup window is displayed

+1 Thanks, Krishna > On 06-Dec-2018, at 2:29 PM, Dmitry Markov wrote: > > Thank you, Sergey! > Looking for the second “+1” from someone else. > > Thanks, > Dmitry > >> On 6 Dec 2018, at 00:10, Sergey Bylokhov wrote: >> >> Looks fine. >> >> On 30/11/2018 01:53, Dmitry Markov wrote: >>> Hi S

Re: [12] RFR 8213983: [macosx] Keyboard shortcut “cmd +`” stops working properly if popup window is displayed

Thank you, Sergey! Looking for the second “+1” from someone else. Thanks, Dmitry > On 6 Dec 2018, at 00:10, Sergey Bylokhov wrote: > > Looks fine. > > On 30/11/2018 01:53, Dmitry Markov wrote: >> Hi Sergey, >> The occurrence of the problem does not depend on child windows, their type >> and v