[11u]: Backport of RFR 8211122: Reduce the number of internal classes made accessible to jdk.unsupported (and JDK-8205537 and JDK-8211121)

2019-06-24 Thread Langer, Christoph
Hi, please help me reviewing the backport of "JDK-8211122: Reduce the number of internal classes made accessible to jdk.unsupported". The main reason for backporting this item is that it'll ease further backports which base on that changeset. The patch is quite extensive and hence doesn't fully

Re: [11u]: Backport of RFR 8211122: Reduce the number of internal classes made accessible to jdk.unsupported (and JDK-8205537 and JDK-8211121)

2019-06-24 Thread Andrew Haley
On 6/24/19 2:51 PM, Langer, Christoph wrote: > please help me reviewing the backport of “JDK-8211122: Reduce the > number of internal classes made accessible to jdk.unsupported”. The > main reason for backporting this item is that it’ll ease further > backports which base on that changeset. The pa

Re: [11u]: Backport of RFR 8211122: Reduce the number of internal classes made accessible to jdk.unsupported (and JDK-8205537 and JDK-8211121)

2019-06-24 Thread Langer, Christoph
> I'm nervous. Although I expect this won't cause any JCK compatibility > issues, it is a behavioural change. I wonder if we should consider > referring this one to the CSR team. +1 The original issues didn't have CSRs attached but it really feels CSRish. Let me know whether I shall create CSR

Re: [11u]: Backport of RFR 8211122: Reduce the number of internal classes made accessible to jdk.unsupported (and JDK-8205537 and JDK-8211121)

2019-06-24 Thread Andrew Haley
On 6/24/19 3:23 PM, Langer, Christoph wrote: > The original issues didn't have CSRs attached but it really feels CSRish. Let > me know whether I shall create CSRs as you're still sorting out the process. Please go ahead. This is a small change that'll be a good test of the process. -- Andrew Ha

Re: [11u]: Backport of RFR 8211122: Reduce the number of internal classes made accessible to jdk.unsupported (and JDK-8205537 and JDK-8211121)

2019-06-24 Thread Alan Bateman
On 24/06/2019 15:23, Langer, Christoph wrote: : The original issues didn't have CSRs attached but it really feels CSRish. Let me know whether I shall create CSRs as you're still sorting out the process. The sun.applet package was JDK internal so no CSR required to change or remove anything in t

[14] Review Request: 8134672 [TEST_BUG] Some tests should check isDisplayChangeSupported

2019-06-24 Thread Sergey Bylokhov
Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8134672 Fix: http://cr.openjdk.java.net/~serb/8134672/webrev.00 The test did not check the "isDisplayChangeSupported" but tried o change the mode of the first screen. -- Best regards, Sergey.

Re: [14] RFR JDK-8226361: jdk ProblemList file contains more than 1 entry for a test

2019-06-24 Thread Sergey Bylokhov
Looks fine, please double check the closed file as well. On 23/06/2019 23:43, Jayathirth Rao wrote: Changes are fine. Thanks, Jay On 24-Jun-2019, at 12:03 PM, Prasanta Sadhukhan mailto:prasanta.sadhuk...@oracle.com>> wrote: Hi All, It appears that jtreg doesn't support having multiple entri

Re: [14] Review Request: 8134672 [TEST_BUG] Some tests should check isDisplayChangeSupported

2019-06-24 Thread Philip Race
+1 -phil On 6/24/19, 4:43 PM, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8134672 Fix: http://cr.openjdk.java.net/~serb/8134672/webrev.00 The test did not check the "isDisplayChangeSupported" but tried o change the mode of the