Re: RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

2019-11-15 Thread Baesken, Matthias
Hello Sergey, sorry for coming back to this a bit late . I could not re-create this "The Internet" shellfolder so far (are you aware of any good tools for this kind of action btw.) ? I looked a bit into the attributes of this shellfolder , it looks strange that it does not have the A

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

2019-11-15 Thread Prasanta Sadhukhan
looks ok to me. Regards Prasanta On 15-Nov-19 4:04 PM, Jayathirth D V wrote: Yes exactly. I was under the impression that waitTillShown() calls getLocationOnScreen() and makes sure that focus is on that component. But waitTillShown() also adds 100ms delay, so looks like just adding a delay

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

2019-11-15 Thread Jayathirth D V
Yes exactly. I was under the impression that waitTillShown() calls getLocationOnScreen() and makes sure that focus is on that component. But waitTillShown() also adds 100ms delay, so looks like just adding a delay helps in recording mouse entry event back to the frame. I have updated the web

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

2019-11-15 Thread Prasanta Sadhukhan
On 15-Nov-19 3:10 PM, Prasanta Sadhukhan wrote: Hi Jay, On 15-Nov-19 3:00 PM, Jayathirth D V wrote: Hi Prasanta, InvokeAndWait() for createAndShowGUI will not make sure that frame is visible? Yes, with invokeAndWait() with waitForIdle() it should be. When InvokeLater was used for crea

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

2019-11-15 Thread Prasanta Sadhukhan
Hi Jay, On 15-Nov-19 3:00 PM, Jayathirth D V wrote: Hi Prasanta, InvokeAndWait() for createAndShowGUI will not make sure that frame is visible? Yes, with invokeAndWait() with waitForIdle() it should be. When InvokeLater was used for createAndShowGUI() we had waitUntilShown(frame) inside

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

2019-11-15 Thread Jayathirth D V
Hi Prasanta, InvokeAndWait() for createAndShowGUI will not make sure that frame is visible? When InvokeLater was used for createAndShowGUI() we had waitUntilShown(frame) inside createAndShowGUI to make sure frame is visible. Main issue in this test is mouse exit from frame and entry into

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

2019-11-15 Thread Prasanta Sadhukhan
Then shouldn't the waitUntilShown(frame) to be called immediately after createAndShowGUI and then proceed with the test because we are doing clickOnComp(frame,) which will be a noop if the frame is not shown,right? Also, frame.dispose() should be under EDT. Regards Prasanta On 15-Nov-19

Re: [14] RFR JDK-8234184:[TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows

2019-11-15 Thread Jayathirth D V
Hi Prasanta, I have added frame disposal. And we need waitUntilShown() that is present especially for frame. Because without waitUntilShown(frame) sometimes dialog closes and then we validate mouseenter count before it is actually recorded in the listener and test fails. Please find update

Re: RFC: JDK-8231991: Mouse wheel change focus on awt/swing windows

2019-11-15 Thread Mario Torre
On Thu, 2019-11-14 at 17:30 -0800, Philip Race wrote: > OK. The incremental fix looks reasonable to me and the testing I've > done > is promising. > > We are currently getting a very large number of failures (not just > the > tests we pointed out) so > > let's get this pushed ASAP. Hi Phil, I