Re: RFR: 8262446: DragAndDrop hangs on Windows [v3]

2021-03-05 Thread Alexander Zuev
On Fri, 5 Mar 2021 17:21:36 GMT, Dmitry Markov wrote: >> The IME functions and the DND operation must be executed on the toolkit >> thread. If the DND operation is in progress, the IME API is invoked via >> SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The >> flag

Re: RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

2021-03-05 Thread Sergey Bylokhov
On Fri, 26 Feb 2021 19:40:22 GMT, Alexander Scherbatiy wrote: > Printing text using GlyphVector outline has bad quality on printers with low > DPI on Windows. > The GDI system used for text printing on Windows accepts only integer path > coordinates. > Rounding GlyphVector outline coordinates

Re: RFR: 8262446: DragAndDrop hangs on Windows [v3]

2021-03-05 Thread Sergey Bylokhov
On Fri, 5 Mar 2021 17:21:36 GMT, Dmitry Markov wrote: >> The IME functions and the DND operation must be executed on the toolkit >> thread. If the DND operation is in progress, the IME API is invoked via >> SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The >> flag

Re: New candidate JEP: 398: Deprecate the Applet API for Removal

2021-03-05 Thread Jonathan Gibbons
OK. My interest is purely about any work I may need to do in this area for jtreg. If I recall correctly, these tests make minimal use of the actual API. When the time comes, it may be enough to stash a private local copy of the Applet class somewhere, and just change the imports to refer to

Re: New candidate JEP: 398: Deprecate the Applet API for Removal

2021-03-05 Thread Philip Race
I should clarify my response that there's no time frame being set here for the actual removal so there should be ample time to do that re-writing. phil. On 3/5/21 2:59 PM, Philip Race wrote: I actually counted almost 100 such open tests. You need to remember JApplet too. And these open

Re: New candidate JEP: 398: Deprecate the Applet API for Removal

2021-03-05 Thread Philip Race
I actually counted almost 100 such open tests. You need to remember JApplet too. And these open jtreg tests do not account for all of it by any means. There are a couple of options - although I  think re-writing is the only truly viable one. But definitely re-working all of those is one

Re: RFR: 8262446: DragAndDrop hangs on Windows [v3]

2021-03-05 Thread Alexey Ivanov
On Fri, 5 Mar 2021 17:21:36 GMT, Dmitry Markov wrote: >> The IME functions and the DND operation must be executed on the toolkit >> thread. If the DND operation is in progress, the IME API is invoked via >> SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The >> flag

Re: New candidate JEP: 398: Deprecate the Applet API for Removal

2021-03-05 Thread Jonathan Gibbons
On 3/5/21 2:19 PM, mark.reinh...@oracle.com wrote: https://openjdk.java.net/jeps/398 Summary: Deprecate the Applet API for removal. It is essentially irrelevant since all web-browser vendors have either removed support for Java browser plug-ins or announced plans to do so. - Mark

New candidate JEP: 398: Deprecate the Applet API for Removal

2021-03-05 Thread mark . reinhold
https://openjdk.java.net/jeps/398 Summary: Deprecate the Applet API for removal. It is essentially irrelevant since all web-browser vendors have either removed support for Java browser plug-ins or announced plans to do so. - Mark

Re: RFR: 8250804: Can't set the application icon image for Unity WM on Linux.

2021-03-05 Thread Alexander Zuev
On Fri, 5 Mar 2021 00:55:04 GMT, Alexander Zvegintsev wrote: > As of now we can have two icons: on the side dock and on the top bar. > But this test was written for an old time Unity with an icon in the side dock > only. > > Icon at the top by default is displayed as grayscale(the actual

Re: RFR: 8262446: DragAndDrop hangs on Windows [v3]

2021-03-05 Thread Dmitry Markov
> The IME functions and the DND operation must be executed on the toolkit > thread. If the DND operation is in progress, the IME API is invoked via > SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The > flag isInDoDragDropLoop indicates whether the DND takes place or

Re: RFR: 8262446: DragAndDrop hangs on Windows [v2]

2021-03-05 Thread Dmitry Markov
On Fri, 5 Mar 2021 17:01:41 GMT, Alexey Ivanov wrote: >> Dmitry Markov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reuse isInDoDragDropLoop > > src/java.desktop/windows/native/libawt/windows/awt_DnDDT.cpp line 228: > >> 226:

Re: RFR: 8262446: DragAndDrop hangs on Windows [v2]

2021-03-05 Thread Alexey Ivanov
On Fri, 5 Mar 2021 16:06:04 GMT, Dmitry Markov wrote: >> The IME functions and the DND operation must be executed on the toolkit >> thread. If the DND operation is in progress, the IME API is invoked via >> SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The >> flag

Re: RFR: 8262446: DragAndDrop hangs on Windows [v2]

2021-03-05 Thread Dmitry Markov
On Fri, 5 Mar 2021 12:53:00 GMT, Dmitry Markov wrote: >>> Why we cannot reuse the old flag? "isInDoDragDropLoop"? I think the >>> Robot.waitForIdle() will hang if isInDoDragDropLoop is not set to true >>> while dragging something from the native app. >> >> Initially I didn’t want to touch

Re: RFR: 8262446: DragAndDrop hangs on Windows [v2]

2021-03-05 Thread Dmitry Markov
On Fri, 5 Mar 2021 12:51:15 GMT, Dmitry Markov wrote: >> Why we cannot reuse the old flag? "isInDoDragDropLoop"? I think the >> Robot.waitForIdle() will hang if isInDoDragDropLoop is not set to true while >> dragging something from the native app. > >> Why we cannot reuse the old flag?

Re: RFR: 8262446: DragAndDrop hangs on Windows [v2]

2021-03-05 Thread Dmitry Markov
> The IME functions and the DND operation must be executed on the toolkit > thread. If the DND operation is in progress, the IME API is invoked via > SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The > flag isInDoDragDropLoop indicates whether the DND takes place or

Re: RFR: 8262446: DragAndDrop hangs on Windows [v2]

2021-03-05 Thread Dmitry Markov
On Fri, 5 Mar 2021 01:34:04 GMT, Sergey Bylokhov wrote: > Why we cannot reuse the old flag? "isInDoDragDropLoop"? I think the > Robot.waitForIdle() will hang if isInDoDragDropLoop is not set to true while > dragging something from the native app. Initially I didn’t want to touch that flag but

Re: RFR: 8250804: Can't set the application icon image for Unity WM on Linux.

2021-03-05 Thread Pankaj Bansal
On Fri, 5 Mar 2021 00:55:04 GMT, Alexander Zvegintsev wrote: > As of now we can have two icons: on the side dock and on the top bar. > But this test was written for an old time Unity with an icon in the side dock > only. > > Icon at the top by default is displayed as grayscale(the actual

Re: RFR: 8250804: Can't set the application icon image for Unity WM on Linux.

2021-03-05 Thread Alexander Zvegintsev
On Fri, 5 Mar 2021 01:18:26 GMT, Sergey Bylokhov wrote: >> test/jdk/ProblemList.txt line 855: >> >>> 853: >>> java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java >>> 8162380 generic-all >>> 854: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java >>>