RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-07 Thread Alexey Ushakov
Perform replaceSurfaceData on insets change - Commit messages: - 8258788: incorrect response to change in window insets [lanai] Changes: https://git.openjdk.java.net/jdk/pull/3390/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3390=00 Issue:

Withdrawn: 8258788: incorrect response to change in window insets [lanai]

2021-04-07 Thread Alexey Ushakov
On Thu, 1 Apr 2021 14:38:52 GMT, Alexey Ushakov wrote: > Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT property. > MTLLayer.h header cleanup. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/3308

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v4]

2021-04-07 Thread Alexey Ushakov
> Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT property. > MTLLayer.h header cleanup. Alexey Ushakov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-07 Thread Alexey Ushakov
On Tue, 6 Apr 2021 12:51:47 GMT, Alexey Ushakov wrote: >>> Is it possible to automatically test it? >> >> Yes, just added the test. > >> @avu Test passes without fix also. > @jayathirthrao Could you provide the details about your configuration along > with parameters passed to jtreg ? > @avu

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-04-07 Thread Sergey Bylokhov
On Mon, 5 Apr 2021 18:47:25 GMT, Pankaj Bansal wrote: >> Ok, please file a similar bug for the windows platform. > > @mrserb @azuev-java Any other comments on this? Can you please look at the > CSR also? I have no additional comments. - PR:

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v3]

2021-04-07 Thread Alexey Ivanov
On Wed, 7 Apr 2021 06:39:48 GMT, Andrey Turbanov wrote: >> There are few possible cleanups in java.desktop related to legacy >> StringBuffer usages: >> 1. In few places StringBuffer can be replaced with plain String >> concatenation. >> 2. StringBuffer can be replaced with StringBuilder.

Integrated: 8255800: Raster creation methods need some specification clean up

2021-04-07 Thread Phil Race
On Fri, 26 Mar 2021 19:53:44 GMT, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8255800 could have been a one line > spec clean up but > it didn't take a lot of looking to realize there were many more > inconsistencies between spec and implementation. > I've spent a lot of time

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v3]

2021-04-07 Thread Alexander Zvegintsev
On Wed, 7 Apr 2021 06:39:48 GMT, Andrey Turbanov wrote: >> There are few possible cleanups in java.desktop related to legacy >> StringBuffer usages: >> 1. In few places StringBuffer can be replaced with plain String >> concatenation. >> 2. StringBuffer can be replaced with StringBuilder.

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v3]

2021-04-07 Thread Andrey Turbanov
On Tue, 30 Mar 2021 15:46:56 GMT, Alexander Zvegintsev wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> [PATCH] Replace uses of StringBuffer with StringBuilder in java.desktop >> >> fix copyright year > >

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v3]

2021-04-07 Thread Andrey Turbanov
> There are few possible cleanups in java.desktop related to legacy > StringBuffer usages: > 1. In few places StringBuffer can be replaced with plain String concatenation. > 2. StringBuffer can be replaced with StringBuilder. StringBuilder has better > performance as it is not thread-safe. > 3.

Integrated: 8264680: Use the blessed modifier order in java.desktop

2021-04-07 Thread Alex Blewitt
On Sat, 3 Apr 2021 22:03:44 GMT, Alex Blewitt wrote: > 8264680: Use the blessed modifier order in java.desktop This pull request has now been integrated. Changeset: 92fad1b4 Author:Alex Blewitt Committer: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/92fad1b4 Stats: