Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-12 Thread Alexander Zuev
On Thu, 12 Aug 2021 02:15:06 GMT, Sergey Bylokhov wrote: > Painting the border while the user tries to disable the border via > setBorderPainted(false) does not look like a correct solution. The user might > be drawn something there already. I remember we discussed a similar a11y bug > related

Withdrawn: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled

2021-08-12 Thread duke
On Thu, 22 Apr 2021 09:21:20 GMT, Toshio Nakamura wrote: > Hi, > > Could you review the fix? > When non-English characters were printed from JTable on MacOS, > CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, > CTextPipe seems not support glyph with slot number of compo

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v5]

2021-08-12 Thread Prasanta Sadhukhan
On Wed, 11 Aug 2021 21:16:43 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its no

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v5]

2021-08-12 Thread Prasanta Sadhukhan
On Thu, 12 Aug 2021 11:59:14 GMT, Prasanta Sadhukhan wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed test instruction and execute the testcase on metal only for mac > > test/jdk/java/awt/print/PrinterJob

Re: RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v3]

2021-08-12 Thread Alexey Ushakov
> Keep MTLLayer opacity in sync with window content view > Keep layer translucent for translucent windows Alexey Ushakov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8266079: Lanai: AlphaComposite shows differences on

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v5]

2021-08-12 Thread lawrence . andrews
On Wed, 11 Aug 2021 21:16:43 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its no

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v6]

2021-08-12 Thread lawrence . andrews
> 1) This testcase was throwing error saying Error: Not a test or directory > containing tests: java/awt/print/PrinterJob/XparColor.java > 2) Added @test tag so that this testcase can be run > 3) Since Applet is deprecated and its not supported any more in the future > release remove applet and m

Re: RFR: 8267161 : Write automated test case for JDK-4479161

2021-08-12 Thread lawrence . andrews
On Mon, 9 Aug 2021 18:36:07 GMT, lawrence.andrews wrote: > 1) Automated the manual test case. > 2) Removed html dependent file > 3) Removed javax.swing.JApplet dependent. > 4) Test case can be executed independently as well with jtreg framework. > 5) Added methods to know that JFrame and Other

Re: RFR: 8267161 : Write automated test case for JDK-4479161 [v2]

2021-08-12 Thread lawrence . andrews
> 1) Automated the manual test case. > 2) Removed html dependent file > 3) Removed javax.swing.JApplet dependent. > 4) Test case can be executed independently as well with jtreg framework. > 5) Added methods to know that JFrame and Other component is visible before > starting the user action via

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v6]

2021-08-12 Thread Prasanta Sadhukhan
On Thu, 12 Aug 2021 15:42:48 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its no

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-12 Thread Sergey Bylokhov
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote: > Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing bord

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-12 Thread Sergey Bylokhov
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote: > Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing bord

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-12 Thread Sergey Bylokhov
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote: > Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing bord

Re: RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v3]

2021-08-12 Thread Alexey Ushakov
On Wed, 11 Aug 2021 12:48:47 GMT, Alexey Ushakov wrote: >> I check the steps below and was able to reproduce the same artifacts(black >> rectangles) in the tree tab with the current version of the fix. And I do >> not see a big difference between setting the layer to YES at the beginning >> or

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v7]

2021-08-12 Thread lawrence . andrews
> 1) This testcase was throwing error saying Error: Not a test or directory > containing tests: java/awt/print/PrinterJob/XparColor.java > 2) Added @test tag so that this testcase can be run > 3) Since Applet is deprecated and its not supported any more in the future > release remove applet and m

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v6]

2021-08-12 Thread lawrence . andrews
On Thu, 12 Aug 2021 15:42:48 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its no

Re: RFR: 8181571: printing to CUPS fails on mac sandbox app

2021-08-12 Thread Phil Race
On Wed, 21 Jul 2021 15:45:55 GMT, Alexander Scherbatiy wrote: > The issue is reproduced on macOS Big Sur 11.0.1 with jdk 16.0.1+9. > > Create a native macOS app from the Hello.java file, sign and run it in > sandbox: > > import javax.print.*; > import javax.swing.*; > > public class Hello {

Re: RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v3]

2021-08-12 Thread Sergey Bylokhov
On Thu, 12 Aug 2021 18:58:59 GMT, Alexey Ushakov wrote: >> Interesting, now I'm also able to reproduce this problem with the latest >> version of the fix. Actually, looks like the problem exists even without the >> fix. We get invalid background with the same scenario. It's not so visible >> b

Re: RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v3]

2021-08-12 Thread Alexey Ushakov
On Thu, 12 Aug 2021 22:05:03 GMT, Sergey Bylokhov wrote: >> I've filed a separate CR for this problem JDK-8272392 > > Then you can roll back this change to the default opaque layer? Did you mean to make MTLLayer opaque by default? Yes, I did it in the latest version. - PR: https:/

Re: RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v3]

2021-08-12 Thread Sergey Bylokhov
On Thu, 12 Aug 2021 23:33:51 GMT, Alexey Ushakov wrote: >> Then you can roll back this change to the default opaque layer? > > Did you mean to make MTLLayer opaque by default? Yes, I did it in the latest > version. Then why do you need " platformWindow.setOpaque(!isTranslucent());" above?

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v7]

2021-08-12 Thread Prasanta Sadhukhan
On Thu, 12 Aug 2021 19:37:51 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its no

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-12 Thread Alexander Zuev
On Thu, 12 Aug 2021 18:17:47 GMT, Sergey Bylokhov wrote: > There are two choices: draw this rectangle ourselves or request this feature > from the JRS. There i pushed the code that only draws the focus ring without the rest of the border. - PR: https://git.openjdk.java.net/jdk/pu

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v2]

2021-08-12 Thread Alexander Zuev
> Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing border on the focused component anyways. Alexander Zuev has u

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v3]

2021-08-12 Thread Alexander Zuev
> Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing border on the focused component anyways. Alexander Zuev has u