On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
jdi, jvmti, and dcmd relate
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Trivially, looks ok to me.
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
Hi Philip,
The MacosxDebuggerLocal.m changes look fine. It took a while to detect
what was actually changed since the html files seem to convert tabs to
spaces. I ended up looking in the patch file, and could see the tabs there.
thanks,
Chris
On 8/5/20 6:46 PM, Philip Race wrote:
Bug
Igor,
> On 31 Aug 2018, at 19:42, Igor Ignatyev wrote:
>
> Alan, Chris,
>
> thanks for looking at it, I went w/ the alternative suggested by Chris. that
> required a sprinkle of doPrivileged in the testlibrary, but now
> Sockets/policy.* files grant the minimal requir
d more permissions than is necessary. I share Alan’s
concern.
Another alternative, that we used in other areas, is to grant
the test library only minimal permissions, separate to the
actual test code. For example:
http://hg.openjdk.java.net/jdk/jdk/file/9183040e34d8/test/jdk/java/net/httpclient/AsFileDownloadTest.policy#l24
-Chris.
While working on SkinJob, I ran IntelliJ's Code Inspector tool over OpenJDK
AWT, and I found lots of room for improvement, much of which could be
automated. Unused imports and weird indentation are the order of the day.
Raw types are often used in place of generics, leading to a lot of
unnecessary
Hi all,
I've started work on Project SkinJob (
https://github.com/RedstoneValley/skinjob), an Android implementation of
AWT that wraps the Android graphics APIs and is forked from OpenJDK AWT.
(Because the Android APIs are as high-level as AWT, SkinJob won't need any
native code or more than a cou
ut)
>>> which is covered by a separate bug so please revert that part of the fix.
>>
>> Sorry. Here is the updated fix where only SoftCache is moved to the
>> java.desktop module and the test ReferrersTest is updated.
>> http://cr.openjdk.java.net/~alexsch/8154539/webrev.02/
This latest version looks good.
-Chris.
t of it was FX and that no longer uses the class
> as it supports only newer Linuxes. So I am deleting the class.
Makes sense to me. I see that the FX dependency was removed
by 8087516.
The changes in the webrev look good. Thanks for doing this Phil.
-Chris.
esktop module.
>
> Looks okay. Moving sun.misc.SoftCache to java.desktop is fine.
+1.
-Chris.
On 26 Apr 2016, at 18:33, Volker Simonis wrote:
> Hi,
>
> can I please have a review for this trivial change:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2016/8155156/
> https://bugs.openjdk.java.net/browse/JDK-8155156
Thank you Volker. Reviewed.
-Chris.
>
On 1 Apr 2016, at 23:19, Phil Race wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8147544
> Fix: http://cr.openjdk.java.net/~prr/8147544/
Your changes look ok to me. Thanks for doing this Phil.
-Chris.
> ManagedLocalThreads is now superseded by a standard
> co
> On Feb 10, 2016, at 9:16 AM, David DeHaven wrote:
>
>
>> Please review one more iteration of the fix of warnings in awt on osx.
>> The fix was contributed by Chris Bensen.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8141553
>> Webrev can be fou
On 12/01/16 22:44, Kevin Rushforth wrote:
I note that JavaFX optionally uses sun.misc.PerformanceLogger this in
one place (via reflection). We'll need to file a new issue to clean this up.
Thanks Kevin. Can you file the FX bug?
-Chris.
-- Kevin
Mandy Chung wrote:
On Jan 12, 2016,
Webrev updated in-place, moved to sun.awt.utli ( desktop module )
http://cr.openjdk.java.net/~chegar/8146735/
-Chris.
On 11 Jan 2016, at 22:44, Chris Hegarty wrote:
>
>> On 11 Jan 2016, at 21:27, Mandy Chung wrote:
>>
>> On Jan 10, 2016, at 1:19 AM, Chris Hegart
> On 11 Jan 2016, at 21:27, Mandy Chung wrote:
>
> On Jan 10, 2016, at 1:19 AM, Chris Hegarty wrote:
>>
>> In preparation for JEP 260, and as per the suggestion over on the core
>> libs[1],
>> sun.misc.PerformanceLogger should be moved to sun.util.logging.
In preparation for JEP 260, and as per the suggestion over on the core libs[1],
sun.misc.PerformanceLogger should be moved to sun.util.logging.
http://cr.openjdk.java.net/~chegar/8146735/
-Chris
[1]
http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-January/037959.html
Thanks for looking at this Sergey.
> On 13 Dec 2015, at 11:16, Sergey Bylokhov wrote:
>
> Hi, Chris.
> What is the reason to use assertion? If the problem is not theoretical,
Hmm… The queue is “unbounded”, but actually has a capacity of
Integer.MAX_VALUE. I suspect that this w
Forwarding to additional area specific mailing lists, as there are changes
in the webrev that affect their area.
-Chris.
Begin forwarded message:
> From: Chris Hegarty
> Subject: RFR [9] 8140606: Update library code to use internal Unsafe
> Date: 28 October 2015 19:55:41 GMT
> To
Thanks Sergey, this looks good to me.
-Chris.
On 6 Oct 2015, at 13:42, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk9.
>
> In the fix the call to ThreadGroup.stop() was wrapped in privileged block.
> The new test is provided, I have checked that it will
Pavel,
The latest changes look good to me. Can you please add a license header to the
service descriptor file ( I know we don't do this consistently ).
-Chris
> On 24 Jun 2015, at 13:20, Pavel Rappo wrote:
>
> Thanks Alan. Both issues are fixed now, webrev updated in place.
&
7;ll postpone the fix a little bit.
>> Here is the new version of the fix:
>> http://cr.openjdk.java.net/~serb/8078658/webrev.01/src/java.desktop/share/classes/java/awt/Cursor.java.sdiff.html
>>
>> The new method is used.
> Using readAllBytes looks good to me.
Yes, this looks good to me too. Nice to see this new API in action ;-)
-Chris.
> -Alan
Alexander,
> On 13 May 2015, at 16:46, Alexander Kulyakhtin
> wrote:
>
> Hi Chris,
>
>
>> I suspect that these changes are best going directly into jdk9/dev, as
>> opposed to a a downstream forest.
> Yes, they are going directly to jdk9/dev, I forgo
plicates
between the hs-rt/hotspot and hs-rt/test/lib files into hs-rt/test/lib and
prepare a full review.
Thank you very much for the review.
Best regards,
Alexander
-Chris.
ded here at all,
the original exception is much more informative.
Agreed. Similar to NetworkInterface.c Line:172
http://hg.openjdk.java.net/jdk9/dev/jdk/file/6ee5c47bdba7/src/solaris/native/java/net/NetworkInterface.c#172
-Chris.
4. Where currently are throwing an exception with pure JNI, but
On 26 Nov 2013, at 18:08, Iris Clark wrote:
>> So overall it looks good to me and should be pushed to the staging > forest
>> once you hear from others that commented previously.
>
> I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov.
> Alan,
Volker,
I skimmed over the networking part of the changes, and nothing jumps out
at me. I'd like to spend a little more time doing a more detailed
review, but I will not have time to do this until after JavaOne.
-Chris.
On 09/16/2013 08:30 PM, Volker Simonis wrote:
Resending this to
On 06/17/2013 05:15 PM, Mandy Chung wrote:
Chris,
Thanks for the patch. It looks fine to me. I saw that you have pushed
this changeset which is fine.
Thanks for looking at this Mandy, your eyes are welcome here.
As for the background, we leave these deprecated methods and fields in
/http/HttpURLConnection.java:635:
warning: [deprecation] isLoggable(int) in PlatformLogger has been deprecated
....
-Chris.
On 27/04/2012 21:37, Jim Graham wrote:
Thanks, sorry, I missed the part where this was responding to a change
that is already under way in the new build system...
Right, but it would be nice to trivially cleanup (remove these files)
from FILES_export list in the old build system.
-Chris
ts ;-) ). Just need to determine the best route for
integration.
-Chris.
On 25/04/2012 14:44, Magnus Ihse Bursie wrote:
There are a few files native files in AWT and Java2d, which include
generated JNI header files, but the corresponding header files are
empty, since the class contains neither
the two patches supplied. See below:
AWT, beans& printing:
To close the loop on this, I pushed the AWT/bean/print changes to the
jdk8/awt/tl repo.
http://mail.openjdk.java.net/pipermail/awt-dev/2012-February/002252.html
It looks like Stuart will take care of the ones going through j
Changeset: a3b50244bd10
Author:chegar
Date: 2012-02-10 11:03 +
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a3b50244bd10
7144475: fix some warnings in java.awt, javax.print.attribute.standard, and
sun.beans.infos
Reviewed-by: chegar, prr, alanb, anthony
Contributed-by: Pras
I think you should just drop the changes to this file.
-Chris.
Michael Barker wrote:
>> Oh, good catch Alan, I missed this. This part of the change should be
>> reversed ( at least in the context of warnings cleanup ).
>
>Should I switch it to a wild card (protected t
rt of the change should be
reversed ( at least in the context of warnings cleanup ).
-Chris.
-Alan.
Michael,
Looks good to me.
Trivially, the generic type in ComponentBeanInfo could simply be
Class, since the actual type is not used. But, what you have is fine.
Thanks for this contribution. I'm sure Stuart will do the integration
for you.
-Chris.
On 02/ 4/12 07:48 AM, Michael B
Changeset: bc1c20ac8676
Author:chegar
Date: 2012-01-27 13:48 +
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bc1c20ac8676
7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be
colocated with libawt
Reviewed-by: art, prr, dholmes, alanb
! make/common/Release
as I would like to push the changes
to jdk8/awt/jdk soon. I just need to do fresh builds and testing.
FYI, latest webrev
http://cr.openjdk.java.net/~chegar/7110002/webrev.01/webrev/
Thanks,
-Chris.
On 11/ 9/11 05:46 PM, Phil Race wrote:
Ditto for 2D.
-phil.
On 11/9/2011 5:19 AM, Artem
Since
getProviders is package private I assume it is ok to "generify".
-Chris
David,
Thanks for catching the issue in java_props_md. I should have seen this.
Update webrev:
- incorporated Davids changes to java_props_md
- "fixed" comments referring to libmawt in awt_LoadLibrary.c
http://cr.openjdk.java.net/~chegar/7110002/webrev.01/webrev/
Thanks,
-Chris.
lib.
See discussion on the awt-dev mailing list for further context:
http://mail.openjdk.java.net/pipermail/awt-dev/2011-April/001666.html
Webrev:
http://cr.openjdk.java.net/~chegar/7110002/webrev.00/
Thanks,
-Chris
could do this:
% webrev.sh -r 123
Chris
43 matches
Mail list logo
