this case.
- Some tests use System.exit() which should be replaced by the exception.
On 5/9/14 7:32 PM, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/9/8014755.1/
for
https://bugs.openjdk.java.net/browse/JDK-8014755
These tests were moved from the close
okhov wrote:
Hi. Oleg.
A few notes.
- Some tests contains empty/non-rethrow catch blocks. I guess we
should rethrow an exception and the test should fail in this case.
- Some tests use System.exit() which should be replaced by the exception.
On 5/9/14 7:32 PM, Oleg Pekhovskiy wrote:
Hi all,
p
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/9/8014755.1/
for
https://bugs.openjdk.java.net/browse/JDK-8014755
These tests were moved from the closed workspace.
The main idea of fix is to force termination of child JVM if it's not
exited automatically after the test sequen
Hi Sergey,
the fix looks good.
Regards,
Oleg
On 28.04.2014 20:33, Sergey Bylokhov wrote:
Hello.
Please review another one javadoc "weekend cleanup" in jdk 9 in sound area.
- 80 column limit
- replaced to @tags
- empty line after description/before the first tag
- sets of spaces in the
y. If you can
only add the source code to it and make it compile itself upon test
execution, then it is fine. But the .exe file itself should not be
pushed to the repo.
--
best regards,
Anthony
On 4/18/2014 6:13 PM, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.jav
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/9/8014754.1/
for
https://bugs.openjdk.java.net/browse/JDK-8014754
Start of 'child.exe' has no timeout, that's why if dragging fails the
executable keeps running and prevents temporary folder from being cleared.
So I forcibly term
Hi Andrew,
the fix looks good.
Regards,
Oleg
On 02.04.2014 14:45, Andrew Brygin wrote:
Hello,
could you please review a fix for 8019990?
bug: https://bugs.openjdk.java.net/browse/JDK-8019990
webrev: http://cr.openjdk.java.net/~bae/8019990/9/webrev.00/
The problem was triggered by t
Hi Sergey,
the fix looks good.
Regards,
Oleg
On 19.03.2014 20:45, Sergey Bylokhov wrote:
Please review the small fix:
diff -r fe79a65a51d8 src/windows/native/sun/font/fontpath.c
--- a/src/windows/native/sun/font/fontpath.cWed Mar 19 16:13:59 2014
+0400
+++ b/src/windows/native/sun/font/fo
Hi team,
please review the typo issue fix:
http://cr.openjdk.java.net/~bagiras/9/8037377.1/
for
https://bugs.openjdk.java.net/browse/JDK-8037377
Thanks,
Oleg
Hi, Petr,
the fix looks good.
Regards,
Oleg
On 13.03.2014 14:57, Petr Pchelko wrote:
Hello, AWT Team.
Sorry, I've broken the Windows build... Compiles fine on Mac and Linux, but
fails on windows.
The bug: https://bugs.openjdk.java.net/browse/JDK-8037287
The fix: http://cr.openjdk.java.net/~p
Hi Sergey,
the fix looks good.
Regards,
Oleg.
On 03.03.2014 23:26, Sergey Bylokhov wrote:
Hello.
Please review a "weekend cleanup" in jdk 9.
typos,final,replacement of old tags, unused imports.
Bug: https://bugs.openjdk.java.net/browse/JDK-8036103
Webrev can be found at: http://cr.openjdk.jav
It's not that I'm against your fix, it looks good actually. I'd just
like to understand the difference. Please elaborate.
Also, I recall we've fixed a number of bugs in this area. Are we sure
we don't regress after this fix?
--
best regards,
Anthony
On 2/7/2014 4:31 AM, Ole
ie. So I'm afraid the code that relies
on this behavior will stop working correctly after your fix because you
will re-create the EDT for all remaining events.
What tests did you run with your fix?
--
best regards,
Anthony
On 2/7/2014 8:18 PM, Oleg Pekhovskiy wrote:
Hi Anthony,
there are
27;m against your fix, it looks good actually. I'd just
like to understand the difference. Please elaborate.
Also, I recall we've fixed a number of bugs in this area. Are we sure
we don't regress after this fix?
--
best regards,
Anthony
On 2/7/2014 4:31 AM, Oleg Pekhovskiy
Hi all,
please review the next version of fix:
http://cr.openjdk.java.net/~bagiras/8031694.2/
We with Artem Ananiev had off-line discussion and he offered let the
dying EDT to die
and process unhandled events by forcing another EDT start.
Thanks,
Oleg
On 01/28/2014 05:32 AM, Oleg Pekhovskiy
op.org/wm-spec/wm-spec-latest.html#idp6337880
Thanks,
Alexander.
On 02/06/2014 10:21 AM, Oleg Pekhovskiy wrote:
Hi Alexander,
thanks for the comments,
please see the next version of fix:
http://cr.openjdk.java.net/~bagiras/8020443.3/
Updates:
1. Left usage of root window coordinates because they pa
.
2. Rewrote the test to make it accurate.
Tested on Ubuntu 12.04, Solaris 11 and Oracle Linux 6.4.
Thanks,
Oleg
On 02/04/2014 07:50 PM, Alexander Zvegintsev wrote:
Oleg,
please see inline
On 02/04/2014 05:00 PM, Oleg Pekhovskiy wrote:
Hi Alexander,
thank you for the review!
1. The problem
{
Otherwise fix looks good to me.
Thanks,
Alexander.
On 02/04/2014 10:26 AM, Oleg Pekhovskiy wrote:
Hi All,
please review the second version of fix:
http://cr.openjdk.java.net/~bagiras/8020443.2/
It turned out that struts must be checked and corrected from all sides
to become the proper screen i
Hi All,
please review the second version of fix:
http://cr.openjdk.java.net/~bagiras/8020443.2/
It turned out that struts must be checked and corrected from all sides
to become the proper screen insets.
Thanks,
Oleg
On 01/21/2014 06:31 PM, Oleg Pekhovskiy wrote:
Hi all,
please review the
Hi Team,
please review the next version of fix:
http://cr.openjdk.java.net/~bagiras/8013116.3
Javadoc changes were moved to a separate issue JDK-8033128.
Thanks,
Oleg
On 21.01.2014 11:53, Oleg Pekhovskiy wrote:
Hi Sergey,
I tested on Windows, Mac OS X and Ubuntu. As a result I found
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8031694.1/
for
https://bugs.openjdk.java.net/browse/JDK-8031694
During forward-port of JDK-7189350 EDT.doDispatch was not taken into
account when calling EventQueue.detachDispatchThread().
As a result harmful optimization of thi
22/2014 8:31 PM, Oleg Pekhovskiy wrote:
Hi Team,
There was a long break after last comment and now I'm able to continue
discussion.
Please review the second version of fix:
http://cr.openjdk.java.net/~bagiras/7033533.2/
I investigated the order of different events and found that
ConfigureNotif
Hi Alexander,
Just to clarify some things...
On X11 Frame utilizes XFramePeer and FileDialog utilizes GtkFileDialogPeer.
These peers have common superclass XDecoratedPeer (GtkFileDialogPeer
through XDialogPeer).
For Frame the following two chains occur:
[#1]
"AWT-XAWT"
sun.awt.X11.XContentWi
est running all automatic regression tests for AWT and
Swing
areas to make sure we don't introduce a regression with this fix.
--
best regards,
Anthony
On 09/26/2013 11:56 AM, Oleg Pekhovskiy wrote:
Hi Leonid,
I did it mostly logically, because my fix added one more service
event
(Se
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8020443.1/
for
https://bugs.openjdk.java.net/browse/JDK-8020443
Referring to the standards, we must calculate insets the special way for
Xinerama:
http://standards.freedesktop.org/wm-spec/1.3/ar01s05.html
_NET_WM_STRUT_PARTIAL
r/getMousePosition_NotHeadless).
Thanks,
Oleg
On 01/14/2014 09:42 PM, Sergey Bylokhov wrote:
On 14.01.2014 21:14, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8013116.1/
for
https://bugs.openjdk.java.net/browse/JDK-8013116
java.awt.Robot.gdLoc field was
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8013116.1/
for
https://bugs.openjdk.java.net/browse/JDK-8013116
java.awt.Robot.gdLoc field was removed to make Robot's point of origin
be the same as in setters and getters from
GraphicsDevice (GraphicsConfiguration), MouseInfo
Changeset: 610da7dcd1be
Author:bagiras
Date: 2013-11-26 15:57 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/610da7dcd1be
7160604: Using non-opaque windows - popups are initially not painted correctly
Reviewed-by: serb, alexsch
! src/share/classes/javax/swing/JPopupMenu.jav
Changeset: e3df535c613f
Author:bagiras
Date: 2013-11-25 14:05 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e3df535c613f
8028995: Write regression test for JDK-8016356
Reviewed-by: serb, anthony
+ test/javax/swing/JFrame/8016356/bug8016356.java
st way, esp. for tests), or a lock.
I always thought that in such cases two threads already synchronized,
because invokeAndWait is used, which block one thread and wait another.
--
best regards,
Anthony
On 11/22/2013 06:35 PM, Sergey Bylokhov wrote:
Thanks!
The fix looks good.
On 22.11.2013
();
91
92 frame.dispose();
On 22.11.2013 16:37, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8028995.1/
for
https://bugs.openjdk.java.net/browse/JDK-8028995
It's just a regression test for JDK-8016356.
Thanks,
Oleg
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8028995.1/
for
https://bugs.openjdk.java.net/browse/JDK-8028995
It's just a regression test for JDK-8016356.
Thanks,
Oleg
, because it returns
nothing.
On 20.11.2013 15:06, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/7160604.1/
for
https://bugs.openjdk.java.net/browse/JDK-7160604
For now popup menu is painted correctly, so the fix applies to
drop-down list of combo-box only
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/7160604.1/
for
https://bugs.openjdk.java.net/browse/JDK-7160604
For now popup menu is painted correctly, so the fix applies to drop-down
list of combo-box only.
BasicComboPopup class implements drop-down list.
BasicComboPopup.is
Changeset: 3ee121726c17
Author:bagiras
Date: 2013-11-18 23:24 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3ee121726c17
8027628: JWindow jumps to (0, 0) after mouse clicked
Reviewed-by: anthony, serb
! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java
! src/solaris/clas
no regressions with my fix even one more previously failing
test passed.
I also ran SQE functional tests mentioned in JIRA issue description.
Windows stopped jumping.
Thanks,
Oleg
--
best regards,
Anthony
On 11/08/2013 12:00 PM, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http:/
Changeset: d6fe4e451dfb
Author:bagiras
Date: 2013-11-13 20:16 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d6fe4e451dfb
8028283: Revert JavaDoc changes pushed for JDK-7068423
Reviewed-by: art, serb
! src/share/classes/java/awt/GraphicsDevice.java
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8028283.1/
for
https://bugs.openjdk.java.net/browse/JDK-8028283
It's just a JavaDoc reverse changes.
Thanks,
Oleg
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8027628.1/
for
https://bugs.openjdk.java.net/browse/JDK-8027628
The issue affects all top-level windows. XConfigureEvent.x and
XConfigureEvent.y fields
from ConfigureNotify event could have wrong values, e.g. when the window
is
Changeset: a2b42e558211
Author:bagiras
Date: 2013-10-29 21:46 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a2b42e558211
8027151: AWT_DnD/Basic_DnD/Automated/DnDMerlinQL/MultipleJVM failing on windows
machine
Reviewed-by: anthony, pchelko
! src/share/classes/sun/awt/datat
x27;ve just
filed).
With this done, the fix looks good to me.
--
best regards,
Anthony
On 10/29/2013 06:39 PM, Oleg Pekhovskiy wrote:
Hi Anthony,
I could refer to the fix for JDK-7075105. the finally {} block was added
there and had never existed before.
Here's the way InputStream passed
ake sure this change doesn't introduce any memory
leaks? Why was this not a problem before that we decided to fix this
particular piece now, so late in the release?
--
best regards,
Anthony
On 10/28/2013 02:41 AM, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.ne
h IFs;
On 28.10.2013 2:41, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8027151.1/
for
https://bugs.openjdk.java.net/browse/JDK-8027151
This issue appeared after the changes made for JDK-7075105.
There were two problems:
1. In drop targe
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8027151.1/
for
https://bugs.openjdk.java.net/browse/JDK-8027151
This issue appeared after the changes made for JDK-7075105.
There were two problems:
1. In drop target code, in SunDropTargetContextPeer.getTransferData()
method inp
Changeset: 229b10e97bd2
Author:bagiras
Date: 2013-10-16 19:02 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/229b10e97bd2
2228674: Fix failed for CR 7162144
Reviewed-by: art, anthony
! src/share/classes/java/awt/EventDispatchThread.java
! src/share/classes/java/awt/EventQue
here are still events in the queue, or we simply don't care about them?
--
best regards,
Anthony
On 10/16/2013 02:31 PM, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/2228674.1/
for
https://bugs.openjdk.java.net/browse/JDK-2228
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/2228674.1/
for
https://bugs.openjdk.java.net/browse/JDK-2228674
The fix covers two scenarios:
1. User code calls EventDispatchThread.interrupt() and then
EventDispatchThread.interrupted() which clears interrupted state and
EDT d
Changeset: 84c766f6796b
Author:bagiras
Date: 2013-10-09 14:12 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/84c766f6796b
8016356: Any swing frame resizes ugly.
Reviewed-by: art, anthony
! src/windows/native/sun/windows/awt_Window.cpp
m Ananiev wrote:
Hi, Oleg,
could you provide information (here and in bug comments), what are the
values returned by GetWindowRect() and getWindowPlacement(), while the
window is being snapped and after it has been snapped, please?
Thanks,
Artem
On 10/7/2013 2:17 PM, Oleg Pekhovskiy wrote:
Hi All,
Changeset: 184b16f4e61f
Author:bagiras
Date: 2013-10-08 17:00 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/184b16f4e61f
7199196: Incremental transfer is broken because of a typo
Reviewed-by: anthony, serb
! src/solaris/classes/sun/awt/X11/XSelection.java
Changeset: 01607de6265d
Author:bagiras
Date: 2013-10-08 16:56 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/01607de6265d
7068423: Spec for java.awt.GraphicsDevice.getFullScreenWindow() needs
clarification
Reviewed-by: art, anthony
! src/share/classes/java/awt/GraphicsDevi
Changeset: 85a72bb00d74
Author:bagiras
Date: 2013-10-08 16:04 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/85a72bb00d74
8000425: FileDialog documentation should be enhanced
Reviewed-by: serb, anthony
! src/share/classes/java/awt/FileDialog.java
SIZE-MOVE loop that works inside AwtWindow::DefWindowProc().
Thanks,
Oleg
On 01.09.2013 10:32, Oleg Pekhovskiy wrote:
Hi Anthony,
On 29.08.2013 17:16, Anthony Petrov wrote:
Hi Oleg,
On 08/28/13 01:35, Oleg Pekhovskiy wrote:
On 26.08.2013 17:20, Anthony Petrov wrote:
The fix looks somewhat
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/7199196.1/
for
https://bugs.openjdk.java.net/browse/JDK-7199196
Just a typo fix.
Thanks,
Oleg
Hi Alexander,
that's right and that proposal was made in issue description.
Victor asked to push those changes. I'm doing it right now.
Don't you mind? ;)
Thanks,
Oleg
On 04.10.2013 15:45, Alexander Zvegintsev wrote:
Hi Anthony,
I think the given bugfix is:
diff -r 0cc00c11e17e src/solaris/
Changeset: 998578a87c0e
Author:bagiras
Date: 2013-10-03 16:51 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/998578a87c0e
8013553: [macosx] java.awt.FileDialog removes file extensions
Reviewed-by: leonidr, serb
! src/macosx/native/sun/awt/CFileDialog.m
setExtensionHidden is
not applicable here.
On 03.10.2013 15:08, Leonid Romanov wrote:
Looks good to me.
On 03.10.2013, at 13:07, Oleg Pekhovskiy
wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8013553.1/
for
https://bugs.openjdk.java.net/browse/JDK-8013553
setExtensionHidden(NO
Thank you, Leonid!
Oleg.
On 03.10.2013 15:08, Leonid Romanov wrote:
Looks good to me.
On 03.10.2013, at 13:07, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8013553.1/
for
https://bugs.openjdk.java.net/browse/JDK-8013553
setExtensionHidden(NO
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8013553.1/
for
https://bugs.openjdk.java.net/browse/JDK-8013553
setExtensionHidden(NO) method of NSSavePanel doesn't work as expected
and that's a known issue mentioned on several forums.
But there is another solution based on Ap
setFullScreenWindow().
Thanks,
Oleg
On 01.10.2013 22:34, Anthony Petrov wrote:
Looks fine.
--
best regards,
Anthony
On 10/01/2013 04:37 PM, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/7068423.1/
for
https://bugs.openjdk.java.net/browse/JDK-7068423
It's j
ing this fix.
--
best regards,
Anthony
On 09/25/2013 02:50 PM, Oleg Pekhovskiy wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8000425.1/
for
https://bugs.openjdk.java.net/browse/JDK-8000425
It's just a Javadoc fix.
Thanks,
Oleg
ented, but, that did
not happen.
Thanks,
Oleg
On 25.09.2013 18:11, Leonid Romanov wrote:
Hi,
I'm not an expert in X11 programming, so I can't comment about the fix
in general, but I think the line 2436, "return getEventNumber() -
event_number > 3", really asks for a comment.
On 9/2
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/7068423.1/
for
https://bugs.openjdk.java.net/browse/JDK-7068423
It's just a Javadoc fix.
Thanks,
Oleg
all automatic regression tests for AWT and Swing
areas to make sure we don't introduce a regression with this fix.
--
best regards,
Anthony
On 09/26/2013 11:56 AM, Oleg Pekhovskiy wrote:
Hi Leonid,
I did it mostly logically, because my fix added one more service event
(SelectionRequest), tha
2013 18:11, Leonid Romanov wrote:
Hi,
I'm not an expert in X11 programming, so I can't comment about the fix
in general, but I think the line 2436, "return getEventNumber() -
event_number > 3", really asks for a comment.
On 9/25/2013 16:38, Oleg Pekhovskiy wrote:
Hi
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/7033533.1/
for
https://bugs.openjdk.java.net/browse/JDK-7033533
Previous implementation of XToolkit.syncNativeQueue() relied upon WM_S0
atom existence and that it was owned by current window manager.
But several WMs (like XFCE an
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8000425.1/
for
https://bugs.openjdk.java.net/browse/JDK-8000425
It's just a Javadoc fix.
Thanks,
Oleg
Changeset: def1fa9854f7
Author:bagiras
Date: 2013-09-12 15:50 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/def1fa9854f7
7064312: Cleanup: avoid using unsafe string function
Reviewed-by: serb, pchelko
! src/windows/native/sun/windows/awt_FileDialog.cpp
! src/windows/native
Changeset: 04fbd34fda7b
Author:bagiras
Date: 2013-09-12 14:56 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/04fbd34fda7b
8003965: Toolkit.beep() documentation is ambiguous
Reviewed-by: anthony
! src/share/classes/java/awt/Toolkit.java
re capabilities."
--
best regards,
Anthony
On 08/29/13 14:52, Oleg Pekhovskiy wrote:
Hi all,
please review the fix for JDK-8003965 (not available on bugs.sun.com):
http://cr.openjdk.java.net/~bagiras/8003965.1/
It's just a Javadoc fix.
Thanks,
Oleg
Hi Anthony,
On 29.08.2013 17:16, Anthony Petrov wrote:
Hi Oleg,
On 08/28/13 01:35, Oleg Pekhovskiy wrote:
On 26.08.2013 17:20, Anthony Petrov wrote:
The fix looks somewhat fragile to me. The sequence of events may change
in a future version of Windows, and the fix will fail then.
I agree
Hi all,
please review the fix for JDK-8003965 (not available on bugs.sun.com):
http://cr.openjdk.java.net/~bagiras/8003965.1/
It's just a Javadoc fix.
Thanks,
Oleg
-aerosnap-message-in-wndproc
This article is an attempt to handle maximize/restore snapping, but this
issue deals with vertical snapping, when top or bottom edge of the
window moved to the corresponding edge of the screen.
--
best regards,
Anthony
On 08/25/13 16:40, Oleg Pekhovskiy wrote:
Hi
Hi all,
please review the fix
http://cr.openjdk.java.net/~bagiras/8016356.1/
for
http://bugs.sun.com/view_bug.do?bug_id=8016356
Windows 7 has a feature that makes "window being automatically arranged
when moved to the edge of the screen". And there is no specific system
notification when that
em after select() call - approved
> > >
> > > Hi Denis,
> > >
> > > there are behavior differences for Choice across the platforms.
> > > on Windows - if we choose the same item twice ItemStateChange
is not
> > > fired twice but for other platfor
Changeset: 9fb5db444365
Author:bagiras
Date: 2012-10-25 19:50 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9fb5db444365
7082294: nsk/regression/b4265661 crashes on windows
Reviewed-by: art, anthony
! src/windows/native/sun/windows/awt_Font.cpp
! src/windows/native/sun/win
Hi!
Please review a 100% backport from 7u4 for CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7082294
Webrev:
http://cr.openjdk.java.net/~bagiras/8/7082294.1/
Changeset:
http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c5618ec76f11
Thanks,
Oleg
Changeset: c27efe7615f8
Author:bagiras
Date: 2012-10-25 09:55 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c27efe7615f8
8000486: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with
NullPointerException
Reviewed-by: flar, art
! src/windows/classes/sun/java
Please, disregard that letter.
I sent another request letter for JDK8 instead.
Sorry,
Oleg
10/24/2012 7:44 PM, Oleg Pekhovskiy wrote:
Hi!
Please review the fix for CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486
Webrev:
http://cr.openjdk.java.net/~bagiras/8/8000486.1
Hi!
Please review the fix for CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486
Webrev:
http://cr.openjdk.java.net/~bagiras/8/8000486.1/
Comments:
This is an 100% port for already approved
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486
Thanks,
Oleg
Hi!
Please review the fix for CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486
Webrev:
http://cr.openjdk.java.net/~bagiras/8/8000486.1/
Comments:
This is an 100% port for already approved
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486
Thanks,
Oleg
of what is going on
there...
...jim
On 10/19/12 3:40 AM, Oleg Pekhovskiy wrote:
Hi Jim,
that was my first idea too, but then I found out that calling
"peer.replaceSurfaceData()" didn't change null statement for those tests,
because "peer.replaceSurfaceData()" w
Hi!
Please review the fix for CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000492
Webrev:
http://cr.openjdk.java.net/~bagiras/7u12/8000492.1/
Comments:
It is a normal situation when
ScreenUpdateManager.getReplacementScreenSurface() returns null taking it
from the peer.
That's why
Oleg,
> >
> > the fix looks good. It was interesting to verify the functionality on
> > Linux. On my Ubuntu everything works properly.
> >
> > Thank you,
> > Denis.
> >
> > On 10/2/2012 6:48 PM, Artem Ananiev wrote:
> >> Hi, Oleg,
>
wrote:
Hi, Oleg,
the new version looks fine.
Thanks,
Artem
On 10/2/2012 4:30 PM, Oleg Pekhovskiy wrote:
Hi Artem,
thank you for the review, I made changes you proposed there:
http://cr.openjdk.java.net/~bagiras/8/7171412.2
Please tell if everything is ok.
Thanks,
Oleg
10/1/2012 2:23 PM
Hi Alexander,
the fix looks good to me.
Thanks,
Oleg
10/3/2012 7:37 PM, Alexander Scherbatiy wrote:
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199708
webrev: http://cr.openjdk.java.net/~alexsch/7199708/webrev.00
The Win32ShellFolder2 can dispose the pIShellFolder after passing
Changeset: 3ac112755bb5
Author:bagiras
Date: 2012-10-03 21:01 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3ac112755bb5
7171412: awt Choice doesn't fire ItemStateChange when selecting item after
select() call
Reviewed-by: art, denis
! src/macosx/native/sun/awt/InitIDs.m
Hi Alexander,
the fix looks good to me.
Thanks,
Oleg
03.10.2012 16:50, Alexander Scherbatiy wrote:
This is a direct backport of the fix from the JDK 8 to JDK 7u12
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7197619
webrev: http://cr.openjdk.java.net/~alexsch/7197619/webrev.03/
O
selectedIndexID just a
static variable in awt_Choice.cpp instead of AwtChoice member?
Thanks,
Artem
On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote:
Hi!
Please review the fix for CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412
Webrev:
http://cr.openjdk.java.net/~bagiras/8/7171412.1/
I left
Hi!
Please review the fix for CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412
Webrev:
http://cr.openjdk.java.net/~bagiras/8/7171412.1/
I left the idea of the fix CR 6770017 but refused of using doubling
native variable for storing previously selected index
(that also caused the
Sent: Thursday, September 20, 2012 6:48 PM
To: Oleg Pekhovskiy; awt-dev@openjdk.java.net; Alexey Utkin
Subject: Re: [8] Review request for 7197619 Using
modifiers for
the dead key detection on Windows
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/7197619/webrev.02/
- ca
method
Thanks,
Alexandr.
On 9/19/2012 8:16 PM, Oleg Pekhovskiy wrote:
Hi Alexander,
let me advice you further changes:
3397 UINT AwtComponent::WindowsKeyToJavaChar(UINT wkey, UINT
modifiers, TransOps ops, BOOL *isDeadKey)
3398 {
3399 static Hashtable transTable("VKEY translations&qu
ethod returns a char as it was before the fix
- ToAsciiEx is changed to ToUnicodeEx as it is suggested in the comment.
Thanks,
Alexandr.
On 9/14/2012 9:11 PM, Oleg Pekhovskiy wrote:
Hi Alexander,
here are my comments:
1. Why did you decide to make WindowsKeyToJavaChar void? Maybe it
Hi Alexander,
here are my comments:
1. Why did you decide to make WindowsKeyToJavaChar void? Maybe it takes
sense to leave signature closer to its original look?
2. Seems like WindowsKeyToJavaChar method could be simplifed (ToAsciiEx
-> ToUnicodeEx, remove MultiByteToWideChar),
like this:
350
Changeset: 5b7ad5bedbd7
Author:bagiras
Date: 2012-09-13 21:23 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5b7ad5bedbd7
7198318: SunToolkitSubclass.java should be removed
Reviewed-by: serb
- src/macosx/classes/sun/awt/SunToolkitSubclass.java
Hi!
Please review the fix for CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198318
Webrev:
http://cr.openjdk.java.net/~bagiras/8/7198318.1/
That's a simple removing of redundant file.
Thanks,
Oleg
Changeset: aa35dc4d3f70
Author:bagiras
Date: 2012-09-13 19:53 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/aa35dc4d3f70
7186109: Simplify lock machinery for PostEventQueue & EventQueue
Reviewed-by: art, anthony, dholmes
! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.jav
he ordering by
"real"
time.
Regards, Peter
On Wednesday, September 12, 2012 12:02:17 AM Peter Levart wrote:
Hi Oleg,
On Tuesday, September 11, 2012 04:03:01 PM Oleg Pekhovskiy wrote:
Hi Peter,
please, see my comments below...
Thanks,
Oleg
9/11/2012 9:42 AM, Peter Levart wrote:
On
ock as outside we would like
to know what happened in PostEventQueue.flush().
We are not able to rethrow the exception because we couldn't change the
signature (by adding "throwns")
for all related methods (e.g. EventQueue.postEvent()).
The fix successfully passed
"closed/java/
s, Peter
On Wednesday, September 12, 2012 12:02:17 AM Peter Levart wrote:
Hi Oleg,
On Tuesday, September 11, 2012 04:03:01 PM Oleg Pekhovskiy wrote:
Hi Peter,
please, see my comments below...
Thanks,
Oleg
9/11/2012 9:42 AM, Peter Levart wrote:
On Tuesday, September 11, 2012 01:25:39 AM Oleg Pekhov
1 - 100 of 174 matches
Mail list logo
