[9] Review request: JDK-8058193 [macosx] Potential incomplete fix for JDK-8031485

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8058193 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8058193/webrev/ The problem is that we consume Enter key by a combo box action and it's not propagated up to the dialog. Enter doe

Re: [9] Review Request for 8054143: move awt automated tests from AWT_Modality to OpenJDK repository - part 6

cannot use the center - there are some buttons there. > > Thanks, > Alexander > > On 10.11.2014 17:38, Petr Pchelko wrote: >> Hello, Alexander. >> >> test/java/awt/Modal/ToBack/ToBackDDFTest.java >> - setModal should be volatile or final >> - rightFr

Re: [7] Review Request for 8001633: Wrong alt processing during switching between windows.

Hello, Mikhail. The fix looks good to me. With best regards. Petr. On 14 нояб. 2014 г., at 18:06, mikhail cherkasov wrote: > Hi Petr, could you please make the second review? > > On 11/14/2014 3:54 PM, Anton V. Tarasov wrote: >> Looks fine for me. >> >> Regards, >> Anton. >> >> On 13.11.20

Fwd: [9] Review request: JDK-8023723 Can not paste and copy the text from the text area into the editor

[forgot to add awt-dev] Begin forwarded message: > From: Petr Pchelko > Subject: [9] Review request: JDK-8023723 Can not paste and copy the text from > the text area into the editor > Date: 14 ноября 2014 г., 15:36:51 GMT+4 > To: Sergey Bylokhov , Alexander Scherbatiy > &g

Re: [9] Review Request for 8054358: move awt automated tests from AWT_Modality to OpenJDK repository - part 7

Hello, Alexander. The fix looks fine, just the frame and dialogs fields should be volatile. The new webrev is not needed for this little change. With best regards. Petr. On 27 окт. 2014 г., at 14:26, alexander stepanov wrote: > Hello, > > Could please anyone review this old request? > > Th

Re: [9] Review Request for 8054359: move awt automated tests from AWT_Modality to OpenJDK repository - part 8

Hello, Alexander. The fix looks good to me. With best regards. Petr. On 27 окт. 2014 г., at 14:25, alexander stepanov wrote: > Hello, > > Could please anyone review this old request? > > Thanks, > Alexander > > On 25.09.2014 17:08, alexander stepanov wrote: >> Sorry, just a reminder. >>

Re: [9] Review request for 8064468 ownedWindowList access requires synchronization in Window.setAlwaysOnTop() method

Hello, Alexander. The fix looks fine to me. With best regards. Petr. > On Nov 11, 2014, at 6:27 PM, Alexander Scherbatiy > wrote: > > > Hello, > > Could you review the fix: > bug: https://bugs.openjdk.java.net/browse/JDK-8064468 > webrev: http://cr.openjdk.java.net/~alexsch/8064468/webrev

Re: [9] Review Request: 8057788 [macosx] "Pinch to zoom" does not work since jdk7

Hello, Denis. Just one question: did you add this only to AWTWindow_Normal and not to AWTWindow_Panel intentionally? Why? Will the feature still work in undecorated frames? With best regards. Petr. > On Nov 10, 2014, at 5:04 PM, Denis S. Fokin wrote: > > Hi Sergey, > > Thank you for the revi

Re: [9] Review Request for 8054143: move awt automated tests from AWT_Modality to OpenJDK repository - part 6

Hello, Alexander. test/java/awt/Modal/ToBack/ToBackDDFTest.java - setModal should be volatile or final - rightFrameOverlapsDialog: what's 7? why is it 7? I think it's better to calculate the center of the frame in case the size of window decorations will be changed in some OS version. line 146:

Re: [9] Review Request for 8055836: move awt tests from AWT_Modality to OpenJDK repository - part 9

Hello, Alexander. The fix looks fine. With best regards. Petr. On 27 окт. 2014 г., at 14:24, alexander stepanov wrote: > Hello, > > Could please anyone review this old request? > > Thanks, > Alexander > > On 24.09.2014 17:08, alexander stepanov wrote: >> Hello Sergey, >> >> Thanks, fixed:

Re: [9] Review request for 8063102: Change open awt regression tests to avoid sun.awt.SunToolkit.realSync, part 1

Hello, Yuri. As long as the classpath hack will be fixed in a separate bug, This fix looks good to me. With best regards. Petr. On 07 нояб. 2014 г., at 20:15, Yuri Nesterenko wrote: > Colleagues, > > please review the first batch of 34 regression tests > modified to eliminate internal refer

Re: [7] Review request: 8041572 [macosx] huge native memory leak in AWTWindow.m

Hello, Mikhail. The fix looks good to me. With best regards. Petr. > On Oct 28, 2014, at 2:37 PM, mikhail cherkasov > wrote: > > Hello, all. > > Could you please review the following fix: > http://cr.openjdk.java.net/~mcherkas/8051263/webrev.00/ >

Re: CFV: New AWT group member: Alexander Zvegintsev

Vote: YES. With best regards. Petr. > On Sep 3, 2014, at 2:44 PM, Artem Ananiev wrote: > > > I hereby nominate Alexander Zvegintsev (OpenJDK user name: azvegint) to > Membership in the AWT Group. > > Alexander is a member of AWT/Swing group at Oracle. He has contributed 20+ > fixes to JDK9

Re: [9] Review request for JDK-8056211: JCK test api/java_awt/Event/InputMethodEvent/serial fails

Hello, Alexey. The fix looks good to me. With best regards. Petr. > On Sep 2, 2014, at 3:09 PM, Alexey Ivanov wrote: > > Hello AWT team, > > This is a reminder, > > Is there any volunteer to review this fix? > > Thanks, > Alexey. > > On 29.08.2014 12:20, Alexey Ivanov wrote: >> Hello AWT T

Re: [9] Review request for 8055746 : plenty of clipboard/dnd tests fail and break X11

Hi, Alexander. The fix looks good to me. Thanks for taking care of this/ With best regards. Petr. > On Sep 1, 2014, at 4:55 PM, Alexander Zvegintsev > wrote: > > Hello, > > please review the fix > http://cr.openjdk.java.net/~azvegint/jdk/9/8055746/00/ > for the issue > https://bugs.openjdk.j

Re: [9/8u40] Review request for RT-37149 and JDK-8049065 : Implement DnD for SwingNode

Hello, Anthony. The AWT part looks good to me. With best regards. Petr. > On Aug 6, 2014, at 9:12 PM, Anthony Petrov wrote: > > Anton: thank you for reviewing the fix. > > All: I need at least one more reviewer for the JDK part of the fix because > we're going to back-port the change to 8u4

Re: [8] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

s, >>> >>> Artem >>> >>>> bug: https://bugs.openjdk.java.net/browse/JDK-8046495 >>>> >>>> Thank you! >>>> Anton. >>>> >>>> On 17.07.2014 13:14, anton nashatyrev wrote: >>>>> Hello All,

Re: [9] Review Request for 8050885: move awt automated tests from AWT_Modality to OpenJDK repository - part 4

Hello, Alexander. The fix looks fine. Just could you please make the fields that hold frames volatile? New review is not needed. With best regards. Petr. > On Jul 28, 2014, at 8:13 PM, alexander stepanov > wrote: > > Hello, > > Could you please review the fix for > https://bugs.openjdk.java

Re: [9] Review Request: 8033141 Cleanup of sun.awt.X11 package

Hello, Sergey. The fix looks good. Could you please add a space before = in XlibWrapper:51 before the push? Thank you. With best regards. Petr. On 28 июля 2014 г., at 19:03, Sergey Bylokhov wrote: > Hello. > Please review a small KSS fix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-803

Re: [9] Review Request: 8051588 DataTransferer.getInstance throws ClassCastException in headless mode

Hello, AWT team. Could I please get a second review on this? Thank you. With bes tregards. Petr. On 23 июля 2014 г., at 17:04, Alexander Scherbatiy wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 7/22/2014 4:20 PM, Petr Pchelko wrote: >> Hel

Re: [9] Review Request: 8051449 Incorrect parsing of the default flavor mapping

perties. Probably we can call it from java.util.Properties > directly? > > On 7/28/14 3:35 PM, Petr Pchelko wrote: >> Hello, AWT Team. >> >> Please review an updated version of this fix: >> http://cr.openjdk.java.net/~pchelko/9/8051449/webrev.01/ >> >> I've

Re: [9] Review Request: 8051449 Incorrect parsing of the default flavor mapping

hange it's package name. All the rest is the same as in the previous version. With best regards. Petr. On 22 июля 2014 г., at 15:50, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the fix for the issue: > https://bugs.openjdk.java.net/browse/JDK-8051449 > T

Re: [9] Review Request: 8037485 Refactor java.awt.datatransfer to eliminate dependency on AWT

e version of StandardEncodings in AddFlavorTest and > DataFlavorUtil? > > On 25.07.2014 12:48, Petr Pchelko wrote: >> Hello, Peter. >> >> Sorry for misunderstanding. >> I've updated the review: >> http://cr.openjdk.java.net/~pchelko/9/8037485/webrev.05/ >&

Re: [9] Review Request: 8037485 Refactor java.awt.datatransfer to eliminate dependency on AWT

Hello, Peter. Sorry for misunderstanding. I've updated the review: http://cr.openjdk.java.net/~pchelko/9/8037485/webrev.05/ With best regards. Petr. On 25 июля 2014 г., at 10:41, Peter Levart wrote: > On 07/24/2014 01:22 PM, Petr Pchelko wrote: >> Thank you for the review. &

Re: [9] Review Request: 8037485 Refactor java.awt.datatransfer to eliminate dependency on AWT

- some raw types and you may want to check if there are > others. Fixed and checked the patch for another raw/unchecked warning. With best regards. Petr. > On Jul 23, 2014, at 7:04 PM, Mandy Chung wrote: > > > On 7/23/2014 6:53 AM, Petr Pchelko wrote: >> Hello, Alan. &g

Re: Review request for 8047288: [macosx] Endless loop in EDT on Mac

which is not passed on not > fixed jdk:) And also I fixed issues in test. New webrev: > http://cr.openjdk.java.net/~bae/8047288/9/webrev.00/ > > On 7/22/2014 8:23 PM, Petr Pchelko wrote: >> Hello, Artem. >> >> A couple of comments: >> 1. LWWindowPeer: 268 -

Re: [9] Review Request: 8037485 Refactor java.awt.datatransfer to eliminate dependency on AWT

va.net/~pchelko/9/8037485/webrev.03/ With best regards. Petr. On 23 июля 2014 г., at 17:27, Alan Bateman wrote: > On 23/07/2014 09:25, Petr Pchelko wrote: >> Hello, Alan. >> >> Thank you for the review. >> I've updated the fix according to your comments. The new

Re: [8u] Review request: 8048549 [macosx] Disable usage of system menu bar if AWT is embedded in FX

Hello, AWT Team. This is a reminder. Could you please review the backport. Thank you. With best regards. Petr. On 15 июля 2014 г., at 16:16, Anthony Petrov wrote: > +1 > > -- > best regards, > Anthony > > On 7/15/2014 2:01 PM, Petr Pchelko wrote: >> Hello, AWT tea

Re: [9] Review request for 8044614: [macosx] Focus issue with 2 applets in firefox

Hello, Dmitry. Thank you for the updates, the new version looks good to me. With best regards. Petr. On 23 июля 2014 г., at 13:43, dmitry markov wrote: > Hello Petr, > > Thank you for review. Please find my answer below. > > Thanks, > Dmitry > On 23/07/2014 11:5

Re: [9] Review Request: 8037485 Refactor java.awt.datatransfer to eliminate dependency on AWT

ethod is fixed. All the rest is the same as in the previous version. Thank you. With best regards. Petr. On 22 июля 2014 г., at 19:08, Alan Bateman wrote: > On 22/07/2014 15:04, Petr Pchelko wrote: >> Hello, >> >> I've updated the fix. The new version is located here

Re: [9] Review request for 8044614: [macosx] Focus issue with 2 applets in firefox

Hello, Dmitry. >> What happens if the focused applet is closed? Does the pluginFocusedWindow >> correctly updated in this case? >> Does the closed applet receives handleFocusEvent(false) event? > The closing of an applet means that we closed the browser's window contained > the applet or move

Re: Review request for 8047288: [macosx] Endless loop in EDT on Mac

Hello, Artem. A couple of comments: 1. LWWindowPeer: 268 - please remove an empty line. 2. LWWIndowPeer. isTargetFocusable - the method is not needed at all. 3. I’m concerned about the test. Do you really need the close button? 4. frame and window variables are set from main thread and read from

Re: [9] Review Request: 8037485 Refactor java.awt.datatransfer to eliminate dependency on AWT

un.datatransfer. This allowed to make less renamings and leave sun.awt.datatransfer package as is. With best regards. Petr. On 18 июля 2014 г., at 13:15, Alan Bateman wrote: > On 17/07/2014 12:07, Petr Pchelko wrote: >> Hello, >> >> Please review the fix for the issue: >>

Re: [9] Review Request: 8032864 [macosx] sigsegv (0Xb) Being Generated When Starting JDev With Voiceover Running

vestigate this further for JDK 9 (or > tbd-major). > > -- > best regards, > Anthony > > On 7/10/2014 5:02 PM, Petr Pchelko wrote: >> Hello, AWT team. >> >> Please review a small fix for the issue: >> https://bugs.openjdk.java.net/browse/JDK-8032864

[9] Review Request: 8051588 DataTransferer.getInstance throws ClassCastException in headless mode

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8051588 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8051588/webrev/ JCK test fails in headless mode because of this issue. With best regards. Petr.

[9] Review Request: 8051449 Incorrect parsing of the default flavor mapping

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8051449 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8051449/webrev/webrev/ This is a regression of one of my recent fixes where I've got a bit too brave with a clenup. Here I've retu

Re: [9] Review request for 8051359 JPopupMenu creation in headless mode with JDK9b23 causes NPE

ause than app context NPE. > > Thanks, > Alexandr. > > > On 7/21/2014 2:01 PM, Petr Pchelko wrote: >> Hello, Alexander. >> >> Isn't it better to use a different approach and just remove the headless >> check in targetToAppContext method? >> I thi

Re: [9] Review Request: 6521783 Unnecessary final modifier for a method in a final class

> On Jul 21, 2014, at 7:31 PM, Sergey Bylokhov > wrote: > > On 7/21/14 7:22 PM, Petr Pchelko wrote: >>>> What do you think about filing new CRs for private final methods and >>>> static final methods? >>> Actually I have nothing against private/stat

Re: [9] Review Request: 6521783 Unnecessary final modifier for a method in a final class

> > On 7/21/14 6:53 PM, Petr Pchelko wrote: >> Hello, Sergey. >> >> The fix looks good. >> >> What do you think about filing new CRs for private final methods and static >> final methods? > Actually I have nothing against private/static final methods.

Re: [9] Review request for 8051440: move tests about maximizing undecorated to OpenJDK

Hello, Yuri. The fix looks good to me. With best regards. Petr. > On Jul 21, 2014, at 6:04 PM, Yuri Nesterenko > wrote: > > Thank you Sergey, > > yes, I'll take care of that, and that should be > regular practice for moving tests. > > -yan > > On 07/21/2014 05:51 PM, Sergey Bylokhov wrote:

Re: [9] Review Request: 6521783 Unnecessary final modifier for a method in a final class

Hello, Sergey. The fix looks good. What do you think about filing new CRs for private final methods and static final methods? With best regards. Petr. > On Jul 21, 2014, at 5:35 PM, Sergey Bylokhov > wrote: > > Hello. > Please review a small fix of warnings from another one tool: > I fix al

Re: [9] Review request for 8051359 JPopupMenu creation in headless mode with JDK9b23 causes NPE

Hello, Alexander. Isn't it better to use a different approach and just remove the headless check in targetToAppContext method? I think this check is incorrect, because it's perfectly valid to have multiple AppContexts in headless mode. With best regards. Petr On 21 июля 2014 г., at 13:33, Alex

Re: [9] Review Request for 8049617: move awt automated tests from AWT_Modality to OpenJDK repository - part 3

jtreg closes them). > But anyway, the version with 'finally' is better, thanks. Please see the > webrev updated: > http://cr.openjdk.java.net/~avstepan/8049617/webrev.01/ > > Regards, > Alexander > > On 21.07.2014 11:01, Petr Pchelko wrote: >> Hello, Alexander

Re: [9] Review Request for 8049617: move awt automated tests from AWT_Modality to OpenJDK repository - part 3

Hello, Alexander. In doTest you are doing closeAll in the end. But if the test is failed and any assert throws an exception, closeAll will not be called and a frame could be left on the screen. I think it's better to call closeAll from a finally block. With best regards. Petr. On 18 июля 2014

Re: [9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

; On 17.07.2014 13:14, anton nashatyrev wrote: >> Hello All, >> >> could please anyone else take a look at the fix? >> >> Thanks! >> Anton. >> >> On 02.07.2014 19:37, Petr Pchelko wrote: >>> Hello, Anton. >>> >>&

Re: [9] Review Request: 8035568 [macosx] Cursor management unification.

t; Hi, Petr. > Is it possible in LWMouseInfoPeer that windowPeer == null? > > On 7/17/14 4:03 PM, Petr Pchelko wrote: >> Hello, >> >> Thank you for the review, the new version is here: >> http://cr.openjdk.java.net/~pchelko/9/8035568/webrev.01/ >> >>

Re: [9] Review Request: 8035568 [macosx] Cursor management unification.

? maybe something else). > > > 3. src/macosx/native/sun/awt/CCursorManager.m >> -[ThreadUtilities performOnMainThreadWaiting:YES block:^(){ > > Is it OK to call Core Graphics functions on a thread other than the main > thread? > > -- > best regards, > Anthony &g

[9] Review Request: 8037485 Refactor java.awt.datatransfer to eliminate dependency on AWT

Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8037485 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8037485/webrev.00 This fix separates the public datatransfer API from the desktop module. The datatransfer module would contain java.awt.dat

Re: [9] Review Request: 8050852 Javadoc cleanup of javax.sound.midi package

Hello, Sergey. The fix looks good to me. With best regards. Petr. On 16 июля 2014 г., at 20:56, Sergey Bylokhov wrote: > Hello. > Please review another one javadoc cleanup in jdk 9 in sound area: > - @param, @return should not end with a dot, except a case when more than one > sentences are

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

these assumption. I'll reiterate my suggestion once again: > would it make sense to only remove the actual continuation slashes? > > -- > best regards, > Anthony > > On 7/15/2014 12:19 PM, Petr Pchelko wrote: >> Hello, Anthony. >> >> Thank you for

[8u] Review request: 8048549 [macosx] Disable usage of system menu bar if AWT is embedded in FX

Hello, AWT team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8048549 The 8u version is available here: http://cr.openjdk.java.net/~pchelko/9/8048549/webrev.8u/ For reference, the 9 version is available here: http://cr.openjdk.java.net/~pchelko/9/8048549/webrev/ T

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

ence in the key part > of each line. > > Also, how about processing commas within string literals? There's not a case > yet, but I can imagine such a mime type definition (e.g. > ...;terminators=",\\\r\n";...) (for the fun of it, i've also added the slash > cha

[9] Review request: 8050465 Remove sun.audio package

Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8050465 The fix is available here: http://cr.openjdk.java.net/~pchelko/9/8050465/webrev/ Simple clean-up. The package is not used any more and can be removed. With best regards. Petr.

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

e but that's not something your patch adds or > changes) > > Mike > > On Jul 9 2014, at 23:55 , Petr Pchelko wrote: > >> Hello, Build Team. >> >> This is a reminder. Could you please review the build part of the following >> fix: >> htt

[9] Review Request: 8049998 [macosx] test java/awt/image/ImageIconHang.java fails with NPE

Hello, AWT Team. Please review a little fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8049998 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8049998/webrev/ It’s a one-liner adding a missed null check. With best regards. Petr.

Re: [7u-dev] Review request for JDK-8046559: NPE when changing Windows theme

Hello, Alexey. Looks OK to me too. With best regards. Petr. > On Jul 11, 2014, at 1:43 AM, Anthony Petrov wrote: > > Hi Alexey, > > I skimmed through the changes and they look fine to me. +1. > > -- > best regards, > Anthony > > On 7/10/2014 7:59 PM, Alexey Ivanov wrote: >> Hi AWT, Swing te

Re: [9] Review Request: 8049583 Test closed/java/awt/List/ListMultipleSelectTest/ListMultipleSelectTest fails on Window XP

Hello, Sergey. The fix looks good to me. I assume that you will file a separate bug for returning parfait problems. With best regards. Petr. On 10 июля 2014 г., at 18:11, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk 9. > The bug reproduced on xp only, regression of JDK-8

Re: [9] Review request for 8049198 [macosx] Incorrect thread access when showing splash screen

> >Thanks, >Alexandr. > > On 7/10/2014 4:49 PM, Petr Pchelko wrote: >> Hello, Alexander. >> >> Please use ThreadUtilities instead of the JNFRunLoop. >> >> With best regards. Petr. >> >> On 10 июля 2014 г., at 16:42, Alexander

[9] Review Request: 8032864 [macosx] sigsegv (0Xb) Being Generated When Starting JDev With Voiceover Running

Hello, AWT team. Please review a small fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8032864 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8032864/webrev.01/ I failed to create a general fix for the core problem, so I've made a point fix for this bug. The problem i

Re: [9] Review request for 8049198 [macosx] Incorrect thread access when showing splash screen

Hello, Alexander. Please use ThreadUtilities instead of the JNFRunLoop. With best regards. Petr. On 10 июля 2014 г., at 16:42, Alexander Scherbatiy wrote: > > Hello, > > Could you review the fix: > bug: https://bugs.openjdk.java.net/browse/JDK-8049198 > webrev: http://cr.openjdk.java.net

[9] Review Request: 8049830 Remove reflection from ScreenMenuBar

Hello, AWT Team. Please review a simple cleanup: https://bugs.openjdk.java.net/browse/JDK-8049830 The fix is available here: http://cr.openjdk.java.net/~pchelko/9/8049830/webrev.00/ Just replacing nasty reflection with proper Accessor pattern. With best regards. Petr.

Re: [9] Review Request for 8047367: move awt automated tests from AWT_Modality to OpenJDK repository - part 2

Hello, Alexander. The fix looks good to me. With best regards. Petr. On 07 июля 2014 г., at 19:35, alexander stepanov wrote: > Hello, > > Could you please review the fix for > https://bugs.openjdk.java.net/browse/JDK-8047367 > > webrev: > http://cr.openjdk.java.net/~avstepan/8047367/ > > T

Re: [9] Review Request for 8043126: move awt automated functional tests from AWT_Events/Lw and AWT_Events/AWT to OpenJDK repository

should be used in future relocation job. >> >> >> With respect to other notes - I'll fix them and post a new webrev, thanks. >> >> Regards, >> Alexander >> >> >> >> On 04.07.2014 18:00, Petr Pchelko wrote: >>> Hello,

[9] Review Request: 8035568 [macosx] Cursor management unification.

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8035568 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8035568/webrev.00/ We are using 2 different methods for getting a cursor position in Robot and in LWAWT. I've changed our implemen

Re: [9] Review request for 8049418: [macosx] PopupMenuListener.popupMenuWillBecomeVisible is not called for empty combobox on MacOS/aqua look and feel

Hi, Alexander. The fix looks good, just one question. The blinking problem returns back? Could you please file a P4 bug for it? With best regards. Petr. > On Jul 7, 2014, at 6:22 PM, Alexander Zvegintsev > wrote: > > Hello, > > please review the fix > http://cr.openjdk.java.net/~azvegint/j

Re: [9] Review request for JDK-8046559: NPE when changing Windows theme

Hello, Alexey. The new version still looks good. With best regards. Petr. > On Jul 4, 2014, at 3:14 PM, Petr Pchelko wrote: > > Hello, Alexey. > >> Your test does not test the JFileChooser hang, because the bug is >> reproducible only in plugin mode where TK th

Re: [9] Review Request for 8043126: move awt automated functional tests from AWT_Events/Lw and AWT_Events/AWT to OpenJDK repository

Hello, Alexander. Sorry for the delay. First of all, could you please describe the approach used in these tests. I'm not quite sure I completely understand why do we need these special helper components. Some comments: 1. LWList: 32 typo LeightWeight 2. MultipleMouseButtonsTest: 219 - you cou

Re: [9] Review request for JDK-8046559: NPE when changing Windows theme

so that now it could deadlock in standalone too. The fix looks good. With best regards. Petr. On 04 июля 2014 г., at 14:28, Petr Pchelko wrote: > Hello, Alexey. > > Your test does not test the JFileChooser hang, because the bug is > reproducible only in plugin mode where TK thread d

Re: [9] Review request for JDK-8046559: NPE when changing Windows theme

Hello, Alexey. Your test does not test the JFileChooser hang, because the bug is reproducible only in plugin mode where TK thread doesn't have an AppContext and we update the ThemeReader on the Toolkit thread. Your test runs in standalone mode where completely different codepath is used. So I s

Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

der moved to datatransfer folder. > 2. Removed private fields/methods call from AddFlavorClipboard test > 3. Test GetContentsInterruptedTest.java is a replacement for corresponding > closed test > > Thanks, > Dima > > On 07/03/2014 02:30 PM, Petr Pchelko wrote: >> H

Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

Hello, Dmitriy. As we do not have a Clipboard folder yet, could you please put Clipboard tests under java/awt/datatransfer/Clipboard so that all data transfer tests are in the same folder. AddFlavorTest:80 - here the test is using the private method via reflection. Please remove this part of th

Re: [7] Review request for 6993873: java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java test indicates ".a frame wasn't focused on click" jdk7 issue on linux

Hello, Anton. Please add an @Override annotation to the method. All the rest looks fine, the new webrev is not needed. With best regards. Petr. > On Jul 3, 2014, at 1:23 PM, Anton V. Tarasov wrote: > > Looks fine to me. > > Regards, > Anton. > > On 02.07.2014 22:36, anton nashatyrev wrote: >

Re: [9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

nton V. Tarasov wrote: >>> On 02.07.2014 11:44, Petr Pchelko wrote: >>>> Hello, Anton. >>>> >>>> I'm not sure I have a detailed understanding of what's happening. >>>> >>>> Before your fix the timestamp of the event

Re: [9] Review Request: 8048549 [macosx] Disable usage of system menu bar if AWT is embedded in FX

eeply) that the LWAWT implementation uses the system menu bar > unconditionally in this case. I believe we can assume that AWT API isn't used > widely and we can leave it as it is. But it's worth noting this in the bug > comments. > > -- > best regards, > An

[9] Review Request: 8048549 [macosx] Disable usage of system menu bar if AWT is embedded in FX

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8048549 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8048549/webrev/ We need to disable the screenMenuBar if AWT is embedded into FX. Only the top-level UI toolkit should work with th

Re: [9] Review Request: 8033367 [macosx] Appletviewer was broken in jdk8 b124

wrote: > Hi, Petr. > Looks like there are some links to the awt.m in the source code. > In the Awt2dLibraries.gmk and in the java_md_macosx.c > > On 02.07.2014 14:58, Petr Pchelko wrote: >> Hello, >> >> Is anyone willing to make a second review? >> >> T

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

st regards. Petr. On 02 июля 2014 г., at 13:52, Alan Bateman wrote: > On 01/07/2014 09:35, Petr Pchelko wrote: >> Hello, >> >> The changes in the public API have been approved, so let me continue the >> review process. >> >> For your convenience: >

Re: [9] Review Request: 8033367 [macosx] Appletviewer was broken in jdk8 b124

Hello, Is anyone willing to make a second review? Thank you. With best regards. Petr. On 16 июня 2014 г., at 22:32, Anthony Petrov wrote: > Hi Petr, > > Thanks for the update. The fix looks fine. > > -- > best regards, > Anthony > > On 6/16/2014 3:31 PM, P

Re: [9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

Hello, Anton. I'm not sure I have a detailed understanding of what's happening. Before your fix the timestamp of the event represented the time when the event was created, and now it's the time when it's sent to java. This might be important if some events cause other events to be issued on the

Re: Review request for 8040076: java.awt.List objects allowing multiple selections are not GC-ed

Hello, Artem. >> As Anthony said it's just for limiting visibility. I didn’t understand this actually. The new version looks good to me. With best regards. Petr. > On Jul 1, 2014, at 10:40 PM, Anthony Petrov wrote: > > Hi Artem, > > Note that assert() [1] is still not a run-time check bec

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

., at 15:50, Alan Bateman wrote: > On 20/06/2014 12:41, Petr Pchelko wrote: >> Hello, Anthony, Artem. >> >>>> Do we officially declare that we drop support for this possibility? >>> This possibility will be dropped regardless of the current Petr's fix, >&g

Re: [9] Review Request: 8048265 AWT crashes inside CCombinedSegTable::In called from Java_sun_awt_windows_WDefaultFontCharset_canConvert

Hello, Sergey. The fix looks good, although I have absolutely no idea why this could be related. Could you please file another bug to track further investigation of this problem. With best regards. Petr. > On Jul 1, 2014, at 9:12 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the f

Re: Review a fix for List leak

Hello, Artem. I have a number of comments about the test: 1. The test lacks a copyright header. Could you please add it. You can use any other test to get an example of a correct header. 2. Please limit the maximum heap size for the test with -Xmx option. 100mb should be enough, it's pointless t

Re: nativeGetCursorPosition() locks EDT

Hello, Konstantin. > The bug can be related with https://bugs.openjdk.java.net/browse/JDK-8047288 Yes. It's the same bug. I highly doubt it's a regression as nothing related was changed recently. I'm currently working on this issue. Unfortunately I can't suggest any viable workaround. Thank you

Re: [9] Review Request: JDK-8047799 Remove WindowClosingSupport

., at 15:33, Anthony Petrov wrote: > Thanks! > > -- > best regards, > Anthony > > On 6/23/2014 10:04 PM, Petr Pchelko wrote: >> Hello, Anthony. >> >>> Out of curiosity, is the import BooleanSupplier statement in Dialog.java >>> only needed

Re: [9] Review Request: JDK-8047799 Remove WindowClosingSupport

not > compile w/o the import? > > -- > best regards, > Anthony > > On 6/23/2014 1:46 PM, Petr Pchelko wrote: >> Hello, AWT Team. >> >> Please review a weekly-cleanup fix for the issue: >> https://bugs.openjdk.java.net/browse/JDK-8047799 >> The fix

Re: [9] Review Request: JDK-8047798 Remove EventQueueDelegate

this fix is a reverse-changeset for JDK-6638195 > > And I assume it also reverses JDK-6699328 ? > > -- > best regards, > Anthony > > On 6/23/2014 6:40 PM, Petr Pchelko wrote: >> Hello, Anthony. >> >> Thank you for the review. >> I've checke

Re: [9] Review request for 8043967: Fix doclint warnings for java.awt

r notes were fixed, thanks: > http://cr.openjdk.java.net/~avstepan/8043967/webrev.02/ > > Regards, > Alexander > > > On 23.06.2014 16:58, Petr Pchelko wrote: >> Hello, Alexander. >> >> A couple of comments: >> >> AWTKeyStroke why do you use

Re: [9] Review Request: JDK-8047798 Remove EventQueueDelegate

also suggest you to find the initial fix, when EventQueueDelegate was > introduced (in 6u10?), to check if anything else can be wiped out. > > Thanks, > > Artem > > On 6/23/2014 6:13 PM, Petr Pchelko wrote: >> Hello, AWT Team. >> >> Please review the fix

[9] Review Request: JDK-8047798 Remove EventQueueDelegate

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8047798 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8047798/webrev/ One more weekly clenup. The EventQueueDelegate was added for JavaFXScript to manipulate EDT in unconventional ways

Re: [9] Review Request: JDK-7112454 Fix for TEST_BUG: java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html failed

Thanks, > Andrei > > On 06/23/2014 04:39 PM, Petr Pchelko wrote: >> Hello, Andrei. >> >> HTML file still lacks copyright header. >> >> With best regards. Petr. >> >> On 23 июня 2014 г., at 15:22, andrei.eremeev >> wrote: >>

Re: [9] Review request for 8043967: Fix doclint warnings for java.awt

Hello, Alexander. A couple of comments: AWTKeyStroke why do you use a full name in @throws? HeadlessException.getMessage you could use @inheritDoc here. KeyboardFocusManager: 1463 Why did you add an extra line here? Robot: 513 - the line is not aligned With best regards. Petr. On 23 июня 2014 г

Re: [9] Review Request: JDK-7112454 Fix for TEST_BUG: java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html failed

//cr.openjdk.java.net/~yan/7112454/webrev.04/ > > Andrei > > On 01/21/2014 04:41 PM, Petr Pchelko wrote: >> Hello, Andrei. >> >> Please update the copyright header, it should say 2014. And the header is >> missing in an html file. >> >> As you’ve added

[9] Review Request: JDK-8047799 Remove WindowClosingSupport

Hello, AWT Team. Please review a weekly-cleanup fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8047799 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8047799/webrev/ This feature was added for plugin in 1.4. I've grepped the sources and the interfaces and methods are

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

, the current fix is not about flavormap.properties on its own, but about > removing AWT.DnD.flavorMapFileURL toolkit property. I would suggest to push > this change as a separate bug fix, not as a part of 8047336. > > Thanks, > > Artem > >> -- >> best regards, >

Re: Review Request for 8047180: Move functional tests AWT_Headless/Automated to OpenJDK repository

июня 2014 г., at 10:26, Dmitriy Ermashov wrote: > On 06/19/2014 06:39 PM, Petr Pchelko wrote: >> Hello, Dmitriy. >> >> It's impossible to review)) > Impossible is nothing! (c)) >> I've briefly skimmed the classes and didn't see any problems with the te

Re: Fwd: RFR: make life easier for general java plugin

Hello, Jiri. Sorry for the delayed answer. From the code point of view you current change looks OK to me. It's an internal package and we can change the access modifier easily. The more general question is what are you going to achieve by making this change? In JDK-9 we would have modules and y

Re: Review Request for 8047180: Move functional tests AWT_Headless/Automated to OpenJDK repository

Hello, Dmitriy. It's impossible to review)) I've briefly skimmed the classes and didn't see any problems with the tests. Looks like these are pretty much the same) Did you check that these tests pass on all platforms? Thank you. With best regards. Petr. On 19 июня 2014 г., at 18:21, Dmitriy E

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Petr. On 19 июня 2014 г., at 16:13, Alan Bateman wrote: > On 19/06/2014 12:17, Petr Pchelko wrote: >> Hello, >> >> Please review the fix for the issue: >> https://bugs.openjdk.java.net/browse/JDK-8047336 >> The fix is available at: >> http://cr.openjdk.j

[9] Review Request: 8047336 Read flavormap.properties as resource

Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8047336 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/ This is another step in datatransfer modularization work. This part of the work needs a CCC, so I've moved it out to a s

  1   2   3   4   5   6   7   >