Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

t 2:18 PM Krishna Addepalli wrote: > > Hi Sergey Malenkov, > > We can debate on how to treat the ALTGR_KEY, and can choose to include the > behaviour as a system flag. > But, currently, with my fix, the code will behave exactly as in Java 1.8. > Even there, when I pressed ALTG

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

hat the example in the javadoc is not entirely correct. > > Why it is incorrect? Because on Mac it considers that Alt+F and Alt+Meta+F are equal. And junior developer will be surprised. > > > > On Sun, Mar 17, 2019 at 1:26 AM Sergey Bylokhov > > wrote: > >> >

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

is not entirely correct. This is just a very simple example, related to the English locale on Windows (and possibly on Linux). It should not be used in multi-platform code. On Sun, Mar 17, 2019 at 1:26 AM Sergey Bylokhov wrote: > > On 16/03/2019 03:58, Sergey Malenkov wrote: > > You

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

.desktop/java/awt/event/InputEvent.html#getModifiersEx() If a developer use this method as described his code will be broken too, because good and attentive developer definitely added ALT_GRAPH_DOWN_MASK to 'offmask'. On Sat, Mar 16, 2019 at 1:27 AM Sergey Bylokhov wrote: > > On 15/03

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

rd compatible to use AltGr instead of right Alt in both cases. Instead of 'Alt+key' you will get 'AltGr+key' or 'Alt+AltGr+key', which are not bound to any action. On Fri, Mar 15, 2019 at 9:27 AM Krishna Addepalli wrote: > > Hi Sergey Malenkov, > > > &#x

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

dds all skipped characters to selection 'Alt+AltGr+Right' does nothing, because we do not assign this shortcut yet On Thu, Mar 14, 2019 at 12:09 AM Sergey Bylokhov wrote: > > On 13/03/2019 03:59, Sergey Malenkov wrote: > > I missed the "for ALT keys" in the bug ti

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

essing”. On Wed, Mar 13, 2019 at 6:57 AM Sergey Bylokhov wrote: > > On 12/03/2019 12:28, Sergey Malenkov wrote: > > Hi Sergey, > > > > 1. macOS uses a regular Alt key as "Alternate Character Key". This is > > the reason why JDK Toolkit defines Ctrl+A

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

Hi Phil, The AltGr is actively used with some locales to enter national characters on Windows and Linux. Also it is used to enter some special symbols. See http://en.wikipedia.org/wiki/AltGr_key Someone may want to connect a classic keyboard to MacMini and configure the right Alt key to behave li

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

Hi Sergey, 1. macOS uses a regular Alt key as "Alternate Character Key". This is the reason why JDK Toolkit defines Ctrl+Alt to select a mnemonic, instead of simple Alt. See https://sites.google.com/site/malenkov/java/141229 2. JDK also supports KEY LOCATION for such keys. Mentioned "Key Table Us

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

deally, it should be a flag that can be turned on/off at run time > via a system property. This is a good idea. I've added a flag without a system property only to keep my patch as small as possible. -- Best regards, Sergey A. Malenkov > > On 06-Mar-2019, at 11:02 PM, Sergey

Re: [13] JDK-8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys

Hi Krishna, Your fix solves the issue that the right Alt key breaks further processing of the left Alt key. But there is a problem with modifiers mask: 304 java_awt_event_InputEvent_ALT_DOWN_MASK | java_awt_event_InputEvent_ALT_GRAPH_DOWN_MASK, 305 java_awt_event_InputEvent_ALT_MA

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

Hello, Sergey! > Do you have bugid for this issue? Not yet. I'll file an issue soon. Regards, SAM On Fri, Mar 1, 2019 at 12:15 AM Sergey Bylokhov wrote: > > Hi, Sergey. > > Do you have bugid for this issue? > > On 28/02/2019 09:35, Sergey Malenkov wrote: > >

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

vaKeyType = (cur->nsMask & nsFlags) ? On Thu, Feb 28, 2019 at 8:12 PM Sergey Malenkov wrote: > > ATTENTION! > > This old fix breaks Java UI 11 on macOS Mojave. > If you press RightAlt once, you never receive event with LeftAlt. > Note that static altGRPressed = NO i

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

ATTENTION! This old fix breaks Java UI 11 on macOS Mojave. If you press RightAlt once, you never receive event with LeftAlt. Note that static altGRPressed = NO is switched to YES, but never to NO. Could you please improve your fix and add a test that Alt-events are not changed after pressing/rele

[9] Review request for JDK-8173876 Fast precise scrolling and DeltaAccumulator fix for macOS Sierra 10.12.2

Hello, Could you please review the following fix: bug: http://bugs.openjdk.java.net/browse/JDK-8173876 webrev: http://cr.openjdk.java.net/~alexsch/sergey.malenkov/8173876/webrev-all.00 It improves our previous fixes after changes in macOS Sierra 10.12.2 -- Best regards, Sergey A. Malenkov

Re: Fix for precise scrolling on Mac Sierra 10.12.2

ificantly (x2-x5), > especially on slow scrolling. > > > On 17.01.2017 0:34, Sergey Malenkov wrote: > > Hello all, > > A precise scrolling (introduced in Sierra) caused a fast scrolling in > old applications including Java. It was fixed in JDK by introducing an > acc

Re: [9] Review Request: 4419271 Provide support for scrolling-mechanisms of non-mouse input-devices

I approve On Tue, Dec 6, 2016 at 4:21 AM, Sergey Bylokhov wrote: > Hi, Sergey. > Please take a look to the updated version (the names are updated): > http://cr.openjdk.java.net/~serb/4419271/webrev.03 > >> 28 нояб. 2016 г., в 7:01, Sergey Malenkov написал(а): >> >&

Re: [9] Review Request: 4419271 Provide support for scrolling-mechanisms of non-mouse input-devices

The fix looks good, but we realized that the direction is not always changed. For example, Windows from VirtualBox on Mac. -jint scrollLines = 3; +jint toScroll = 3; -UINT platformLines; +UINT platformUnits; Also I prefer to use similar names for this variables as before. For exa

Re: Who wants to fix 15 years old issue?

> The approach looks fine. ... except forgotten printf :) >> Note, that WM_MOUSEHWHEEL > WM_MOUSELAST, >> so any checks inside AWT ignores such events. > I think that the changes in the Toolkit should be moved to > PreProcessMouseMsg(), Then you should replace the following expression (msg.m

Who wants to fix 15 years old issue?

Hi guys, Now we have a lot of notebooks with touchpads/trackpads, but Java cannot scroll horizontally on such devices: http://bugs.openjdk.java.net/browse/JDK-4419271 I want to say that MacOS on my Mac supports it, while Windows on the same Mac does not support. Our customers complains about this

JDK-8098530: ArrayIndexOutOfBoundsException at sun.awt.X11.XEvent.getFieldsAsString

Hi all, Could you please consider the following changes to fix JDK-8098530? --- src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java (revision f0ae41314e223bf1b97c8126ac2b0d6edb5ee99d) +++ src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java (revision ) @@ -690,7 +690,7 @@

Re: RFR: 8167523: JDK 9 build failure on MacOS due to unhandled cases in switch statement

> Looks fine. +1 Thanks! Sergey A. Malenkov

Re: [8u-dev] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

>>> Could you review the backport of the fix to the JDK8u-dev: >>> http://cr.openjdk.java.net/~alexsch/8166591/webrev-jdk8.00 >>> >>> This is just the same fix as for the JDK 9 (see [1]). There are some >>> style differences between JDK 8u-dev and JDK 9 which I needed to merge >>> manually. Al

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

I've got old MacBook Air 2011, 11" non-Retina display. I installed Sierra and reproduced the fast scrolling issue. Now I have no idea when it can be reproduced and when cannot. Then I installed 10.12.1 beta (16B2333a). Seems that the issue is not reproducible with a system terminal anymore, but

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

Hi all, Message from Mike Swingler about sensitive scrolling: >The original issue your bug was duplicated against > has been resolved by the HID engineering team, > and should be available in a forthcoming beta of > macOS 10.12.1. To get it via Software Update, > sign up at

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

Also, I can't understand what DELTA_THRESHOLD means? It increases a pause before scrolling, which is not comfortable for me. >>> >>> Yes. I is just a barrier before which the wheel rotation event is not >>> counted. >> >> The default 0.5 from Math.round is more comfortable. >> >> Could yo

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

>> I'm not sure. It can be a "false" scrolling when you accidentally >> touched a Magic Mouse. > > The same "false" can occur at the "end" stage, also? Yes, but at the "end" we can use a threshold. See below: >> I think we should use threshold on the phase end, to ignore >> accumulatedDelta less

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

final int roundDelta = isShift && roundDeltaY != 0.0 ? roundDeltaY : roundDeltaX; roundDeltaY is integer and should be compared with 0 On Fri, Sep 30, 2016 at 6:43 PM, Sergey Malenkov wrote: > + (jint) scrollStateWithEvent: (NSEvent*) event { > > scrollPhaseFromEvent sounds

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

nd delta is not equal to zero > - The native scrollStateWithPhase: method is updated to have NSEvent as an > argument > > Thanks, > Alexandr. > > On 30/09/16 16:58, Sergey Malenkov wrote: >> >> In the CPlatformResponder: >> >> phase3 0 ~ 0.0 // mayBegan

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

x: >> http://cr.openjdk.java.net/~alexsch/8166591/webrev.06 >> >> - The CPlatformResponder.handleScrollEvent(...) is updated to dispatch >> a scroll event when delta or round delta is not equal to zero >> - The native scrollStateWithPhase: method is updated to have NSEvent as &

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

66591/webrev.05 > > The momentumPhase is used to detect the trackpad events. > > Thanks, > Alexandr. > > > On 30/09/16 14:58, Sergey Malenkov wrote: >>> >>> # C [AppKit+0x3a528e] -[NSApplication _crashOnException:]+0x6d >>> >>> The app is cras

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

> # C [AppKit+0x3a528e] -[NSApplication _crashOnException:]+0x6d > > The app is crashed as soon as I start scrolling. Investigating... > May be it is my fault during backporting. Sorry, It was may fault. > LWCToolkit.m: > +// SCROLL EVENT MASK > +#define SCROLL_PHASE_UNSUPPORTED 1 > ... > > re

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

> # C [AppKit+0x3a528e] -[NSApplication _crashOnException:]+0x6d > > The app is crashed as soon as I start scrolling. Investigating... > May be it is my fault during backporting. Sorry, it was my fault. Now it works. Consider how it works for one short gesture: phase3 0 ~ 0.0 // unexpected PHA

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

o +1 or > -1 when the scroll phase is ended and the accumulates delta value is small > than the threshold. > > Thanks, > Alexandr. > > > On 29/09/16 22:56, Sergey Malenkov wrote: >>> >>> - The SCROLL_MASK_PHASE_CANCELLED and SCROLL_MASK_PHASE_ENDED scroll >

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

>> But we already did some magic to support mouse event. >> On the top level I have no access to the phase values. > > But how this values helps you? If we roundup the accumulator on the "end > phase" the scroll will be slow in the middle phase, no? I want to support short gestures like we support

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

> It depends from the application, just checked on the list of emails in the > Thunderbird which have small "deadzone". I think we should not do any magic > in this files. only get native event and post it to upper level(the int > value should be accumulated) And this is responsibility of upper lev

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

>> Look at the following scenario: >> - Perform slow and short scroll gesture >> - Accumulator is less than threshold >> - All wheel events during this gesture has wheelRotation=0 >> - Nothing is scrolled actually. >> - Repeat several such gestures - nothing is scrolled > > Just to clarify, if you

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

> - The SCROLL_MASK_PHASE_CANCELLED and SCROLL_MASK_PHASE_ENDED scroll masks > are added. Now we use the scrollMask value and the following constants: static final int SCROLL_MASK_WHEEL = 1; static final int SCROLL_MASK_TRACKPAD = 1 << 1; static final int SCROLL_MASK_PHASE_BEGAN = 1 << 2; static

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

> - The SCROLL_MASK_PHASE_CANCELLED and SCROLL_MASK_PHASE_ENDED scroll masks > are added. Could you please use these masks in your fix? Look at the following scenario: - Perform slow and short scroll gesture - Accumulator is less than threshold - All wheel events during this gesture has wheelRota

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

> Could you please read comments about "deazone" in the following issue: > https://youtrack.jetbrains.com/issue/IDEA-158500 > Is DELTA_THRESHOLD introduced to solve such a deadzone? If your scroll gesture on a trackpad is very slow, a list will be scrolled by a single line after unexpected delay:

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

ELLED and SCROLL_MASK_PHASE_ENDED scroll masks > are added. > > Thanks, > Alexandr. > > > On 29/09/16 17:29, Sergey Malenkov wrote: >> >> The signature of the NSEvent constructor is changed. >> It is called from AWTView.m (fixed) and CTrayIcon.m (!not fixed!) &

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

The signature of the NSEvent constructor is changed. It is called from AWTView.m (fixed) and CTrayIcon.m (!not fixed!) Could you please support not only the phase start, but the phase end too? It will be useful, when we decide to support precise scrolling in JScrollPane, because we will be able to

MacOS: precise scrolling is too fast

Hi guys, JetBrains has some problems to continue Oracle support, and I have no ability to submit a CR for now. But there is a critical issue in AWT scrolling after Sierra have been released. http://bugs.openjdk.java.net/browse/JDK-8166591 I solved this issue in our custom JDK: http://sites.googl

Re: The input method handling

Regards, > Anton. > > > On 10.12.2014 20:56, Sergey Malenkov wrote: >> >> Hi all, >> >> In Oracle JDK the input method handling is slightly different from >> Apple JDK. And this is a reason of some issues in IntelliJ IDEA. I >> found out that the

Re: The input method handling

uoted in the previous mail. Maybe there > were some corner cases and that's what I wanted to know. Maybe asking the > original authors of the code (at Apple?) about this would help? > > Naoto > > > On 12/11/14 3:15 AM, Sergey Malenkov wrote: >> >> Hi Naoto,

Re: The input method handling

it. Have you investigated what it means? > > Also, if the change turns OK, you probably would want to change the variable > name from "utf8Length" to something more appropriate. > > Naoto > > > On 12/10/14, 9:56 AM, Sergey Malenkov wrote: >> >> Hi a

Re: The input method handling

t; combinations might be the only way to produce certain "common" characters > (e.g. {}, as the NetBeans page mentions). > > I'm not familiar with JDK internals, so my apologies if the observations > above are not relevant here. > > -- Eirik > > On 12/10/14, 12:56 P

The input method handling

Hi all, In Oracle JDK the input method handling is slightly different from Apple JDK. And this is a reason of some issues in IntelliJ IDEA. I found out that the insertText method in the following file uses lengthOfBytesUsingEncoding instead of length in characters: http://hg.openjdk.java.net/jdk9

hg: jdk8/awt/jdk: 8028054: com.sun.beans.finder.MethodFinder has unsynchronized access to a static Map

Changeset: 6829d28b3da5 Author:malenkov Date: 2013-11-26 13:30 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6829d28b3da5 8028054: com.sun.beans.finder.MethodFinder has unsynchronized access to a static Map Reviewed-by: alexsch, serb ! src/share/classes/com/sun/beans/find

hg: jdk8/awt/jdk: 8027648: Type of overridden property is resolved incorrectly

Changeset: 29f979efbabf Author:malenkov Date: 2013-11-08 14:09 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/29f979efbabf 8027648: Type of overridden property is resolved incorrectly Reviewed-by: alexsch ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/s

Approved: [8] Review Request: 8027696 Incorrect copyright header in the tests

Looks OK to me. SAM On 05.11.2013 20:28, Sergey Bylokhov wrote: Hello, Updated version: http://cr.openjdk.java.net/~serb/8027696/webrev.01/ Dates and spaces were fixed. On 02.11.2013 15:37, Alan Bateman wrote: On 01/11/2013 11:18, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 8

hg: jdk8/awt/jdk: 8026491: Typos in string literals

Changeset: 30766f910509 Author:malenkov Date: 2013-11-01 21:45 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/30766f910509 8026491: Typos in string literals Reviewed-by: alexsch, anthony ! src/macosx/classes/com/apple/laf/AquaFileChooserUI.java ! src/macosx/classes/com/appl

hg: jdk8/awt/jdk: 8027442: JDK compilation fails on MacOS

Changeset: d4eb25382baf Author:malenkov Date: 2013-10-29 19:01 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d4eb25382baf 8027442: JDK compilation fails on MacOS Reviewed-by: alexsch, pchelko ! src/share/classes/java/awt/Component.java

hg: jdk8/awt/jdk: 8022746: List of spelling errors in API doc

Changeset: bedc29a6d074 Author:malenkov Date: 2013-10-29 17:01 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bedc29a6d074 8022746: List of spelling errors in API doc Reviewed-by: alexsch, smarks ! src/macosx/bundle/JavaAppLauncher/src/JVMArgs.m ! src/macosx/classes/com/app

hg: jdk8/awt/jdk: 8026705: [TEST_BUG] java/beans/Introspector/TestTypeResolver.java failed

Changeset: 75ae2a980db5 Author:malenkov Date: 2013-10-25 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/75ae2a980db5 8026705: [TEST_BUG] java/beans/Introspector/TestTypeResolver.java failed Reviewed-by: art, jfranck ! test/java/beans/Introspector/TestTypeResolver.java

hg: jdk8/awt/jdk: 7035495: javax.swing.ImageIcon spec should be clarified

Changeset: 54a6e22b749c Author:malenkov Date: 2013-10-14 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/54a6e22b749c 7035495: javax.swing.ImageIcon spec should be clarified Reviewed-by: alexsch ! src/share/classes/javax/swing/ImageIcon.java

hg: jdk8/awt/jdk: 7016396: (spec) JCK test mentioned in 6735293 is still failing

Changeset: 9f49b055e983 Author:malenkov Date: 2013-10-14 13:59 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9f49b055e983 7016396: (spec) JCK test mentioned in 6735293 is still failing Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/s

hg: jdk8/awt/jdk: 7165112: Incomprehensible garbage in doc for RootPaneContainer

Changeset: 69a17384fe22 Author:malenkov Date: 2013-10-14 13:22 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/69a17384fe22 7165112: Incomprehensible garbage in doc for RootPaneContainer Reviewed-by: alexsch ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/ja

hg: jdk8/awt/jdk: 7172597: java.awt.KeyboardFocusManager.clearFocusOwner() missed javadoc tag @since 1.8

Changeset: 6914b883c3bb Author:malenkov Date: 2013-10-08 18:19 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6914b883c3bb 7172597: java.awt.KeyboardFocusManager.clearFocusOwner() missed javadoc tag @since 1.8 Reviewed-by: art, anthony ! src/share/classes/java/awt/Keyboard

hg: jdk8/awt/jdk: 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified

Changeset: 42d3ea1c35b4 Author:malenkov Date: 2013-10-08 18:10 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/42d3ea1c35b4 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/LWComponentPeer.ja

[8] Review request for 7172597: java.awt.KeyboardFocusManager.clearFocusOwner() missed javadoc tag @since 1.8

Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/7172597.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-7172597 Added missed tag @since 1.8 Thanks, SAM

Re: [8] Review request for 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified

http://cr.openjdk.java.net/~malenkov/7081584.8.1/ <http://cr.openjdk.java.net/%7Emalenkov/7081584.8.1/> The specification is updated. SAM On 02.10.2013 16:29, Artem Ananiev wrote: On 10/2/2013 3:31 PM, sergey malenkov wrote: This bug is about javadoc. What if I replace "the defa

Approved: [7] Review request for backport of 8023310: Thread contention in the method Beans.IsDesignTime()

contention in the method Beans.IsDesignTime() http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a284da808700 See the subject of your first letter. I almost missed it. SAM Thanks, Mikhail. On 02.10.2013 14:32, sergey malenkov wrote: I changed the subject, which is incorrect. The backport looks good. Do

Re: [8] Review request for 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified

regards, Anthony On 09/27/2013 08:49 PM, sergey malenkov wrote: Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/7081584.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-7081584 The specification of the Window class waits for CCC approval. This f

Re: [7] Review request for backport of 8023310: Thread contention in the method Beans.IsDesignTime()

I changed the subject, which is incorrect. The backport looks good. Do you have a build for Windows to test a performance? Thanks, SAM On 02.10.2013 11:20, mikhail cherkasov wrote: Hello all, Please review a backport for the following bug: https://bugs.openjdk.java.net/browse/JDK-8023310 webre

hg: jdk8/awt/jdk: 8025652: [macos] build failed

Changeset: 603cd3cefbb0 Author:malenkov Date: 2013-09-30 22:08 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/603cd3cefbb0 8025652: [macos] build failed Reviewed-by: serb ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11GraphicsEnv

[8] Review request for 8025652: [macos] build failed

Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/8025652.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8025652 This is a regression after the 7117595 fix. Thanks, SAM

hg: jdk8/awt/jdk: 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed

Changeset: 0042f54f65d0 Author:malenkov Date: 2013-09-27 22:25 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0042f54f65d0 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed Reviewed-by: anthony, serb ! src/macosx/classes/sun/awt/CGra

hg: jdk8/awt/jdk: 8012716: java.beans.EventHandler.create method should check if the given listenerInterface is a public interface

Changeset: bfff9e9120ec Author:malenkov Date: 2013-09-27 22:17 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bfff9e9120ec 8012716: java.beans.EventHandler.create method should check if the given listenerInterface is a public interface Reviewed-by: art, mchung ! src/share/

[8] Review request for 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified

Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/7081584.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-7081584 The specification of the Window class waits for CCC approval. This fix removes the getTookit method from the ComponentPeer class and its

Re: [8] Review request for 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed

devices found after a second re-initialization attempt. The rest of code (user apps and tests) seem to be happy with this implementation. -- best regards, Anthony On 09/23/2013 09:59 PM, sergey malenkov wrote: Could you please review the second version of the fix: http://cr.openjdk.java.net/~ma

hg: jdk8/awt/jdk: 8023310: Thread contention in the method Beans.IsDesignTime()

Changeset: a284da808700 Author:malenkov Date: 2013-09-25 14:06 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a284da808700 8023310: Thread contention in the method Beans.IsDesignTime() Reviewed-by: art, sfriberg ! src/share/classes/java/beans/ThreadGroupContext.java ! src/s

Re: [8] Review request for 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed

seem to be happy with this implementation. -- best regards, Anthony On 09/23/2013 09:59 PM, sergey malenkov wrote: Could you please review the second version of the fix: http://cr.openjdk.java.net/~malenkov/7117595.8.1/ I throw AWTError if there are no more screen devices. On 23.09.2013 16

Re: [8] Review request for 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed

Could you please review the second version of the fix: http://cr.openjdk.java.net/~malenkov/7117595.8.1/ I throw AWTError if there are no more screen devices. On 23.09.2013 16:47, sergey malenkov wrote: Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov

Re: [8] Review request for 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed

sException instead. What do you think? -- best regards, Anthony On 09/23/13 16:47, sergey malenkov wrote: Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/7117595.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-7117595 Thanks, SAM

[8] Review request for 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed

Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/7117595.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-7117595 Thanks, SAM

hg: jdk8/awt/jdk: 7024235: Nimbus L&F: wrong "packing" of a frame containing tabbed pane

Changeset: abebe03818f6 Author:malenkov Date: 2013-09-20 18:56 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/abebe03818f6 7024235: Nimbus L&F: wrong "packing" of a frame containing tabbed pane Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneU

hg: jdk8/awt/jdk: 8024407: [macosx] javax/swing/JScrollBar/7163696/Test7163696.java failed intermittently on macos

Changeset: eedb2b6d93ec Author:malenkov Date: 2013-09-10 17:12 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/eedb2b6d93ec 8024407: [macosx] javax/swing/JScrollBar/7163696/Test7163696.java failed intermittently on macos Reviewed-by: alexsch ! test/javax/swing/JScrollBar/71

hg: jdk8/awt/jdk: 7057770: (spec)Scrollbar spec should specify that unit increment & decrement functionality may not be present

Changeset: 1daffcf035c4 Author:malenkov Date: 2013-09-10 17:06 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1daffcf035c4 7057770: (spec)Scrollbar spec should specify that unit increment & decrement functionality may not be present Reviewed-by: alexsch ! src/share/classes

hg: jdk8/awt/jdk: 7172865: PropertyDescriptor fails to work with setter method name if setter is non-void

Changeset: 2ad01ecbaf90 Author:malenkov Date: 2013-09-03 21:53 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2ad01ecbaf90 7172865: PropertyDescriptor fails to work with setter method name if setter is non-void Reviewed-by: art, alexsch ! src/share/classes/java/beans/Index

hg: jdk8/awt/jdk: 6943780: JTabbedPane throws ArrayIndexOutOfBoundsException sometimes

Changeset: b5ed8686cc01 Author:malenkov Date: 2013-09-03 11:00 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b5ed8686cc01 6943780: JTabbedPane throws ArrayIndexOutOfBoundsException sometimes Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.

hg: jdk8/awt/jdk: 7156658: JTextComponent.setFocusAccelerator() spec does not state that focus accelerator is L&F dependent

Changeset: f2f614e31522 Author:malenkov Date: 2013-09-02 14:06 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f2f614e31522 7156658: JTextComponent.setFocusAccelerator() spec does not state that focus accelerator is L&F dependent Reviewed-by: alexsch ! src/share/classes/jav

hg: jdk8/awt/jdk: 6968363: ClassCastException while entering HINDI characters with CustomDocument

Changeset: 35644adc3269 Author:malenkov Date: 2013-08-28 17:32 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/35644adc3269 6968363: ClassCastException while entering HINDI characters with CustomDocument Reviewed-by: alexsch ! src/share/classes/javax/swing/text/AbstractDocum

hg: jdk8/awt/jdk: 8022398: javax/swing/JFileChooser/8013442/Test8013442.java fails

Changeset: 4bfcf9c5ced3 Author:malenkov Date: 2013-08-27 13:37 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4bfcf9c5ced3 8022398: javax/swing/JFileChooser/8013442/Test8013442.java fails Reviewed-by: alexsch ! src/macosx/classes/com/apple/laf/AquaFileChooserUI.java ! src/s

hg: jdk8/awt/jdk: 7195179: ClassCastException for null values in JComboBox

Changeset: abd068530590 Author:malenkov Date: 2013-08-27 12:53 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/abd068530590 7195179: ClassCastException for null values in JComboBox Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java + test/ja

hg: jdk8/awt/jdk: 8021379: JFileChooser Create New Folder button enabled in write proteced directory

Changeset: 92adff44c841 Author:malenkov Date: 2013-08-27 13:13 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/92adff44c841 8021379: JFileChooser Create New Folder button enabled in write proteced directory Reviewed-by: alexsch ! src/share/classes/sun/swing/FilePane.java

hg: jdk8/awt/jdk: 7080613: java.beans.DefaultPersistenceDelegate.instantiate(..) doesn't throw NPE

Changeset: f983fd18dd81 Author:malenkov Date: 2013-08-23 19:29 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f983fd18dd81 7080613: java.beans.DefaultPersistenceDelegate.instantiate(..) doesn't throw NPE Reviewed-by: alexsch ! src/share/classes/java/beans/DefaultPersistence

hg: jdk8/awt/jdk: 7057769: JScrollBar spec should specify that unit increment & decrement functionality may not be present

Changeset: b71f112dab2a Author:malenkov Date: 2013-08-22 21:05 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b71f112dab2a 7057769: JScrollBar spec should specify that unit increment & decrement functionality may not be present Reviewed-by: alexsch ! src/share/classes/java

hg: jdk8/awt/jdk: 8023536: Some regression tests have a wrong header

Changeset: 0151f12bd392 Author:malenkov Date: 2013-08-22 17:17 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0151f12bd392 8023536: Some regression tests have a wrong header Reviewed-by: alexsch ! test/java/beans/Performance/Test7122740.java ! test/java/beans/Performance/Te

hg: jdk8/awt/jdk: 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF)

Changeset: 336a94dbecb5 Author:malenkov Date: 2013-07-30 17:46 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/336a94dbecb5 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF) Reviewed-by: alexsch, serb ! src/share/classes/com/sun/java/swing/plaf/w

hg: jdk8/awt/jdk: 8010782: clean up source files containing carriage return characters

Changeset: bf80c2965a84 Author:malenkov Date: 2013-07-29 18:48 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bf80c2965a84 8010782: clean up source files containing carriage return characters Reviewed-by: alexsch, art ! src/share/classes/com/sun/java/swing/plaf/gtk/resource

Re: [8] Request for review: 6230360 : Spelling mistake in documentation for AWT: 1.4, 1.5, 1.6, 1.7

Absractly, I approve. SAM On 26.07.2013 19:56, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. It resolve a small typo. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6230360 Webrev can be found at: http://cr.openjdk.java.net/~serb/6230360/webrev.01

hg: jdk8/awt/jdk: 8015926: NPE when using SynthTreeUI's expandPath()

Changeset: 3cbe376233a9 Author:malenkov Date: 2013-07-22 20:33 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3cbe376233a9 8015926: NPE when using SynthTreeUI's expandPath() Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java + test/javax/swing/

hg: jdk8/awt/jdk: 8019975: closed/javax/swing/JFileChooser/4966171/bug4966171.java throws java.io.NotSerializableException: javax.swing.plaf.basic.BasicFileChooserUI$AcceptAllFileFilter

Changeset: 607ad960fe24 Author:malenkov Date: 2013-07-22 15:36 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/607ad960fe24 8019975: closed/javax/swing/JFileChooser/4966171/bug4966171.java throws java.io.NotSerializableException: javax.swing.plaf.basic.BasicFileChooserUI$Ac

hg: jdk8/awt/jdk: 8017492: Static field in HTML parser affects all applications

Changeset: 0967103c1b65 Author:malenkov Date: 2013-07-15 17:33 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0967103c1b65 8017492: Static field in HTML parser affects all applications Reviewed-by: art ! src/share/classes/javax/swing/text/html/parser/ContentModel.java ! src

hg: jdk8/awt/jdk: 6707231: Wrong read Method returned for boolen properties

Changeset: 7e291fc61cad Author:malenkov Date: 2013-07-09 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7e291fc61cad 6707231: Wrong read Method returned for boolen properties Reviewed-by: alexsch ! src/share/classes/java/beans/Introspector.java + test/java/beans/Intro

hg: jdk8/awt/jdk: 8016545: java.beans.XMLEncoder.writeObject output is wrong

Changeset: b7b95b7ab2cb Author:malenkov Date: 2013-06-21 17:13 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b7b95b7ab2cb 8016545: java.beans.XMLEncoder.writeObject output is wrong Reviewed-by: alexsch ! src/share/classes/java/beans/XMLEncoder.java + test/java/beans/XMLEnc

hg: jdk8/awt/jdk: 8013442: No file filter selected in file type combo box when using JFileChooser

Changeset: 6a3a2cb3ca6a Author:malenkov Date: 2013-06-19 14:28 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6a3a2cb3ca6a 8013442: No file filter selected in file type combo box when using JFileChooser Reviewed-by: alexsch ! src/share/classes/javax/swing/JFileChooser.java

hg: jdk8/awt/jdk: 8013571: TreeModelEvent doesn't accept "null" for root as Javadoc specifies.

Changeset: a0202d94844a Author:malenkov Date: 2013-06-17 18:30 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a0202d94844a 8013571: TreeModelEvent doesn't accept "null" for root as Javadoc specifies. Reviewed-by: alexsch ! src/share/classes/javax/swing/JTree.java ! src/shar

Re: CFV: New AWT group member: Petr Pchelko

Vote: Yes On 11.06.2013 18:06, Artem Ananiev wrote: I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to membership in the AWT Group. Petr is a Committer in JDK8 project. He is an active contributor in AWT and OpenJFX: http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=pchelko htt

  1   2   >