Re: RFR: 8256643: Terminally deprecate ThreadGroup stop, destroy, isDestroyed,… [v3]

2020-11-24 Thread Stuart Marks
On Sun, 22 Nov 2020 16:00:45 GMT, Alan Bateman wrote: >> This change terminally deprecates the following methods defined by >> java.lang.ThreadGroup >> >> - stop >> - destroy >> - isDestroyed >> - setDaemon >> - isDaemon >> >> The stop method has been deprecated since=1.2 because it is

Re: RFR: 8256643: Terminally deprecate ThreadGroup stop, destroy, isDestroyed,… [v2]

2020-11-20 Thread Stuart Marks
On Fri, 20 Nov 2020 19:59:52 GMT, Mandy Chung wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-17 Thread Stuart Marks
On Fri, 11 Sep 2020 15:17:58 GMT, Bradford Wetmore wrote: >> Ok, sorry for the distraction. > > Our local Santuario maintainer says: > > In general, changes to Apache Santuario should also be made at Apache so we > stay in sync. Hi @doom369, I hope we didn't end up wasting too much of your

Re: [12] Review Request: 8210231 Robot.delay() catches InterruptedException and prints stacktrace to stderr.

2019-12-11 Thread Stuart Marks
For what it's worth, I've looked at the code and the CSR and I think where this has ended up is fine. Phil had previously raised some concerns about the change in behavior. I think those are reasonable concerns; obviously I don't know about every place Robot.delay() is used that could

Re: [12] Review Request: 8210692 The "com.sun.awt.SecurityWarning" class can be dropped

2018-09-13 Thread Stuart Marks
I'd guess that security-dev would have reviewers for the change to default.policy. Cc'd. s'marks On 9/13/18 2:43 PM, Sergey Bylokhov wrote: Hello. Please review fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8210692 Webrev: http://cr.openjdk.java.net/~serb/8210692/webrev.00

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-13 Thread Stuart Marks
clear this up and make the final call. Mandy On Jun 10, 2016, at 9:58 AM, Stuart Marks <stuart.ma...@oracle.com> wrote: Hi, sorry I had missed this earlier. It's surprising if forRemoval=true were to be added to this API when the rest of the Applet API has forRemoval=false. Is it the intent

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-10 Thread Stuart Marks
un 10, 2016, at 9:58 AM, Stuart Marks <stuart.ma...@oracle.com> wrote: Hi, sorry I had missed this earlier. It's surprising if forRemoval=true were to be added to this API when the rest of the Applet API has forRemoval=false. Is it the intent, for example, to have JSObject.getWi

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-10 Thread Stuart Marks
brev.01 Bug: https://bugs.openjdk.java.net/browse/JDK-8156960 Thank you! Best regards, Daniil -Original Message- From: Mandy Chung Sent: Wednesday, June 08, 2016 3:09 PM To: Daniil Titov Cc: David Dehaven; Stuart Marks; Erik Joelsson; build-dev; build-infa-...@openjdk.java.net; awt-dev; Kevin R

Re: [9] Review Request: 8155071 AppletViewer should print the deprecation warning that the Applet API is deprecated

2016-05-06 Thread Stuart Marks
Hi, the change looks fine to me. I don't think there needs to be a CCC for this, but it does change a message string, so the localization people need to be informed of this. (Unless there's some way they get notified automatically when message files change; I'm not sure.) s'marks On 5/5/16

Re: [9] Review Request: 8154493 AppletViewer should emit its deprecation warning to standard error

2016-04-28 Thread Stuart Marks
Thanks for doing this. Looks reasonable to me. (It's also not clear to me that a regression test is worthwhile for testing message output like this. In the RMI tests, we used to have tests that tested the usage messages emitted by the launchers. The tests had race conditions that led to

Re: RFR: 8136570: Avoid setting environment variables related to /usr/dt

2015-09-17 Thread Stuart Marks
Doctor Deprecator approves. Not only is this a win because it's a pure-deletion change, it's a double win because it removes a side effect from a function that's supposed to "get" and initialize Java properties values. s'marks On 9/17/15 9:12 AM, Martin Buchholz wrote: Too late, I just

Re: AWT Dev Warning Fixes from LJC Hack Session

2012-02-06 Thread Stuart Marks
Michael, Thanks for splitting up the patches and revising them in response to the review comments. I'm not yet entirely sure how to proceed with pushing these changes. I think Chris assumed that I would push these changes. Since these are in awt, printing, and beans, the changes might need