Re: [9] Review request for 8160530: [TEST-BUG] Consistent failure of java/awt/dnd/MissingEventsOnModalDialog/MissingEventsOnModalDialogTest.java

Fine with me! -yan On 04/27/2017 10:09 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160530 webrev: http://cr.openjdk.java.net/~ssadetsky/8160530/webrev.00/ To issues are being fixed. The first, Delay was increased for the test

Re: [9] Review request for 8081454: [TESTBUG]Some java/awt/Mixing tests fail in OEL 7 only

before the location request because the window may not be shown yet or its final dimensions may not be established. Window showing is asynchronous and can takes significant time on some platforms. --Semyon On 04/19/2017 02:15 AM, Yuri Nesterenko wrote: Hi Semyon, in JComboBoxOverlapping.java

Re: [9] Review request for 8081454: [TESTBUG]Some java/awt/Mixing tests fail in OEL 7 only

Hi Semyon, in JComboBoxOverlapping.java, wouldn't it be better to have some synchronization or a dumb delay after invokeAndWait? loc2 and loc may be not ready on the main thread. Perhaps making them volatile could help here? Thanks, -yan On 04/18/2017 10:07 PM, Semyon Sadetsky wrote: Hello,

Re: [9] Review request for 8142540: [TEST_BUG] Test sun/awt/dnd/8024061/bug8024061.java fails on ubuntu

+1 -yan On 04/12/2017 10:23 PM, Semyon Sadetsky wrote: On 04/10/2017 09:34 PM, Sergey Bylokhov wrote: webrev: http://cr.openjdk.java.net/~ssadetsky/8142540/webrev.00/ Starting Ubuntu 15 windows got zero width borders. Initial mouse click point missed the panel to drag. Probably it will be b

Re: [9] Review request for 8164469: [TEST_BUG] Unity, java/awt/MouseInfo/JContainerMousePositionTest.java

I tried it with b159 on Unity a dozen times in a loop: works OK So +1 -yan On 04/07/2017 03:51 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8164469 webrev: http://cr.openjdk.java.net/~ssadetsky/8164469/webrev.00/ The patch fixe

Re: [9] Review request for 8159451: [TEST_BUG] java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java

Phil, it's more or less realistic, yes. It paints various controls, many of them, clicks several times, than repeats everything again for embedded frame. On some platforms if you do it too fast, you just cannot be sure the control is ready to receive a click. And, my +1 here. -yan On 04/06/201

Re: Review request for : JDK-8137087 [TEST BUG] java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

OK with me. TMP variable would be still in POSIX notation but it seems not necessary here. -yan On 01/24/2017 09:44 AM, Rahul Singh wrote: Hi All, Kindly review the fix for the bug: JDK-8137087 [TEST BUG] The test java/awt/appletviewer/IOEx

Re: [9] Review request for 8171909: [PIT] on Windows, failure of java/awt/Dialog/DialogAboveFrame/DialogAboveFrameTest.java

Fine with me: runs as expected even on Win10. -yan On 01/11/2017 04:53 PM, Sergey Bylokhov wrote: Looks fine. Yuri can you please take a look also? Thanks. Hello, Could you review a fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8171909 webrev: http://cr.openjdk.java.

Re: [9] RFR for 8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited

+1 -yan On 10/20/2016 01:35 PM, Alexander Stepanov wrote: Hello Sergey, Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8159454/webrev.01/ Thanks, Alexander P.S.: there is no guarantee that CONFIGS does not contain repeating GCs, but hopefully this is not very important.

Re: [9] Review request for JDK-8161473:[TEST_BUG] [macosx] add autodelay to java/awt/TrayIcon/TrayIconEventModifiers/TrayIconEventModifiersTest.java

+1 -yan On 10/12/2016 06:44 PM, Sergey Bylokhov wrote: On 12.10.16 9:04, Ambarish Rapte wrote: Thanks Anubhav, Changes look fine to me. +1 *From:*Anubhav Meena *Sent:* Monday, October 10, 2016 5:06 PM *To:* Ambarish Rapte *Cc:* awt-dev@openjdk.java.net *Subject:* Re: [9] R

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

Try to open JFileChooser dialog in SwingSet2 (before the fix) and click + to maximize it (I tried on 10.10 and 10.12): application is blocked by a modal dialog, and there's no way to see it. -yan On 10/11/2016 05:01 PM, Alexander Zvegintsev wrote: Actually I can't reproduce such behavior. On

Re: [9] Review request for 8162840: Desktop. enableSuddenTermination() has no effect

In fact, we have a bunch of them in the func. workspace, all more or less easily portable to jtreg. I'll move them in a bulk, time permitting. -yan On 08/16/2016 07:47 PM, Alexander Zvegintsev wrote: Sure, but it is already created by Yuri and attached to the issue. I can include it with this

[9] Review Request for 8157137: [PIT] [TEST_BUG] compilation failed for some tests from jdk/test/java/awt/mixing/AWT_Mixing (can't find Helper)

Colleagues, please review this test-only fix for JDK-8157137 CR: https://bugs.openjdk.java.net/browse/JDK-8157137 Webrev: http://cr.openjdk.java.net/~yan/8157137/webrev.00/ The reason these tests worked for me was, I had all necessary compiled files in my repo clones on all test machines. To re

Re: [9] Review request for 8160623: [PIT] Exception running java/awt/event/KeyEvent/KeyChar/KeyCharTest.java

Have it built and tested on a couple of locales: all seems working OK. Fine with me! -yan On 06/30/2016 05:38 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160623 webrev: http://cr.openjdk.java.net/~ssadetsky/8160623/webrev.00/

Re: CFV: New AWT Group Lead: Sergey Bylokhov

Vote: yes -yan On 06/10/2016 06:39 PM, Artem Ananiev wrote: Hi, AWT team, I hereby nominate Sergey Bylokhov (OpenJDK user name: serb) to AWT Group Lead [1]. Sergey is a member of Java Client group at Oracle. He has been one of the most active contributors to AWT (and other Java client libs: S

Re: [9] Review Request: 8004693 TEST_BUG: java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java fails

+1 -yan On 05/30/2016 07:39 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The test DefaultPolicyChange_Swing.java has two issues: - It uses invokeLater(), so the test usually pass before the code is executed on the EDT, because the main thread completes before. - The te

Re: [9] Review request for 8155606: [PIT] Robot's createScreenCapture() broken on Linux

Fine with me! -yan On 04/28/2016 03:12 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8155606 webrev: http://cr.openjdk.java.net/~ssadetsky/8155606/webrev.00/ Method arguments jwidth and height were swapped in the call of a new met

Re: [9] Review Request: 7124381 DragSourceListener.dragDropEnd() never been called on completion of dnd operation

+1 -yan On 04/25/2016 07:27 PM, Sergey Bylokhov wrote: Hello. Please review the small cleanup for jdk9. I was not able to reproduce the test failure(osx/windows) described in the bug, but during validation of the test I found that the test can fail on linux+some specific themes, when the title

Re: JDK-8031423 : Test java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails by Timeout on Windows

+1 -yan On 04/15/2016 08:28 AM, Ajit Ghaisas wrote: Thanks Yuri. Here is the updated webrev with suggested change. http://cr.openjdk.java.net/~aghaisas/8031423/webrev.01/ Regards, Ajit -Original Message- From: Yuri Nesterenko Sent: Thursday, April 14, 2016 6:48 PM To: Ajit Ghaisas

Re: JDK-8031423 : Test java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails by Timeout on Windows

Hi Ajit, it's good you didn't change java.awt.Robot! As to the test, you have created that instance of Robot: now, pass it to Util.waitForIdle() and not recreate every time. Thanks, -yan On 04/14/2016 02:59 PM, Ajit Ghaisas wrote: Hi, Adding delay in test code in main thread fixes this t

Re: [9] Review Request for 8152693: Changed behavior of java/awt/xembed/server/TestXEmbedServerJava.java test

Please take a look at the slightly changed version of this test-only fix. Semyon, thank you! I'm sorry I have to update it: now we have new syntax for addExport; the old syntax will eventually stop working. yan On 03/31/2016 04:24 PM, Yuri Nesterenko wrote: Hi, could you please review

Re: [9] Review Request for 8152693: Changed behavior of java/awt/xembed/server/TestXEmbedServerJava.java test

Webrev: http://cr.openjdk.java.net/~yan/8152693/webrev.01 On 04/04/2016 05:04 PM, Yuri Nesterenko wrote: Please take a look at the slightly changed version of this test-only fix. Semyon, thank you! I'm sorry I have to update it: now we have new syntax for addExport; the old syntax

[9] Review Request for 8152693: Changed behavior of java/awt/xembed/server/TestXEmbedServerJava.java test

Hi, could you please review this test-only fix? CR: https://bugs.openjdk.java.net/browse/JDK-8152693 Webrev: http://cr.openjdk.java.net/~yan/8152693/webrev.00 Added: one more addExport of an internal package for a spawned process. The test does sniff for Class.getModule() and runs with older JDK

Re: [9] Review Request for several test bugs: 8150535, 8151033, 8151037 etc.

on from WM directly and is more reliable. --Semyon On 3/24/2016 6:12 PM, Yuri Nesterenko wrote: Sergey, I'm sorry, filing JDK-8152693, I found an error in that version. A new one is http://cr.openjdk.java.net/~yan/8150535/webrev.02 The spawned processes were provided with addExports. Sh

Re: [9] Review Request for several test bugs: 8150535, 8151033, 8151037 etc.

Sergey, I'm sorry, filing JDK-8152693, I found an error in that version. A new one is http://cr.openjdk.java.net/~yan/8150535/webrev.02 The spawned processes were provided with addExports. Shame on me! -yan On 03/24/2016 05:34 PM, Sergey Bylokhov wrote: cc swing-dev On 24.03.16 17:17,

[9] Review Request for several test bugs: 8150535, 8151033, 8151037 etc.

Hi, please review this test-only fix, a leftover from Jigsaw M3 integration. Some 7 tests fixed but note that not all of them always pass even fixed. Webrev: http://cr.openjdk.java.net/~yan/8150535/webrev.01 I need to file a bug about the fixed here manual test java/awt/xembed/server/TestXEmbedS

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

+1 -yan On 03/11/2016 06:05 PM, Alexander Scherbatiy wrote: The test looks good to me. Thanks, Alexandr. On 11/03/16 16:19, Alexander Stepanov wrote: Hello Alexandr, Thank you for the explanation. Could you please review the updated test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.

Re: [9] RFR for 8151627 [TEST_BUG] fix test/java/awt/image/multiresolution/MultiResolutionRenderingHintsTest.java to run with Jake

OK with me. -yan On 03/10/2016 05:13 PM, Sergey Bylokhov wrote: Looks fine. On 10.03.16 17:03, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8151627/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8151627 Thanks, Alex

Re: [9] Review Request for 8150535: [TEST_BUG] fix @library for test/java/awt/TrayIcon/MouseMovedTest/MouseMovedTest.java

Gentle unassuming reminder!! (I would also ask someone to push it to Jake upon approval). (Or, after ~b111, I'll push them myself) -yan On 02/29/2016 06:45 PM, Yuri Nesterenko wrote: Colleagues, please review this test-only fix for some tray icon AWT tests in 9-jigsaw repository. CR is

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

+1 -yan On 03/04/2016 06:13 PM, Sergey Bylokhov wrote: Looks fine. On 29.02.16 18:45, Alexander Stepanov wrote: The following version of the test passes for OS X + retina (as well as for Windows and Linux): http://cr.openjdk.java.net/~avstepan/8150258/webrev.01/ not sure if "-Dsun.java2d.uiSc

Re: [9] Review Request: 8144164 [macosx] Test java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest failed

Hi Sergey, fix looks OK to me. We didn't see the original issue on Mac, did we? Thanks, -yan On 02/28/2016 10:33 PM, Sergey Bylokhov wrote: Hello, Please review the small fix for jdk9. The test tries to use Alt+F4 but it is meaningless on OSX. - On OSX Ctrl+f4 (cycle between open windows in a

[9] Review Request for 8150535: [TEST_BUG] fix @library for test/java/awt/TrayIcon/MouseMovedTest/MouseMovedTest.java

Colleagues, please review this test-only fix for some tray icon AWT tests in 9-jigsaw repository. CR is https://bugs.openjdk.java.net/browse/JDK-8150535 Webrev: http://cr.openjdk.java.net/~yan/8150535/webrev.00 The fix should go to 9-jigsaw since there are extra lines using Xpatch (comparing wit

Re: Review-request for 8143227: Platform-Specific Desktop Features

NB: if you create an application with taskbar menu and a progress bar and register it with Unity, then start 2 instances of the application and then call getTaskbar().setIconBadge(null) in the first instance (not in the second), result will be, completely removed taskbar menu. Perhaps it is a Unit

Re: Review-request for 8143227: Platform-Specific Desktop Features

Hi Alexander, an unimportant note: before the spec is finalized, could you please replace the StarOffice example with something actual? StarOffice is discontinued long ago. It is in Desktop.java. Also, could you describe the minimal packaging procedures for client applications, necessary to take

Re: [9] Review Request for 8145795: [TEST_BUG][PIT] java/awt/Window/ScreenLocation/ScreenLocationTest.java fails (can assign Integer.MAX_VALUE to Window dimensions)

Semyon, but earlier builds of jdk9 could handle this bordercase properly, didn't they?. E.g. b95? -yan On 12/22/2015 04:22 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8145795 webrev: http://cr.openjdk.java.net/~ssadetsky/8145795

Re: [9] Review Request for 8135008: TEST_BUG] Part 3: update client tests requiring jake-specific options after changes in setAccessible(true) routine

On 12/10/2015 03:09 PM, Alan Bateman wrote: On 10/12/2015 11:09, Yuri Nesterenko wrote: Hi colleagues, please review this test-only fix for AWT tests in 9-jigsaw repository. CR is https://bugs.openjdk.java.net/browse/JDK-8135008 Webrev: http://cr.openjdk.java.net/~yan/8135008/webrev.00

[9] Review Request for 8135008: TEST_BUG] Part 3: update client tests requiring jake-specific options after changes in setAccessible(true) routine

Hi colleagues, please review this test-only fix for AWT tests in 9-jigsaw repository. CR is https://bugs.openjdk.java.net/browse/JDK-8135008 Webrev: http://cr.openjdk.java.net/~yan/8135008/webrev.00/ Here, after November updates in jtreg, 14 identical helpers are replaced by a single one, and li

Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

Hi Semyon, it's OK for OEL 7 but wouldn't the tests fail for any other system with Gnome 3? -yan On 11/25/2015 04:29 PM, Sergey Bylokhov wrote: Looks fine. On 25.11.15 11:18, Semyon Sadetsky wrote: On 11/12/2015 2:02 AM, Sergey Bylokhov wrote: Isn't this is a typo in the MouseMovedTest.java

Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

Now we should carefully merge them with Jigsaw version. -yan On 11/25/2015 11:18 AM, Semyon Sadetsky wrote: On 11/12/2015 2:02 AM, Sergey Bylokhov wrote: Isn't this is a typo in the MouseMovedTest.java? : 42 if (SystemTray.isSupported()) { 43 return; 44 } Yes

Re: Review-request for 8143227: Platform-Specific Desktop Features

doesn't work. Thanks, -yan [0] http://cloud.addictivetips.com/wp-content/uploads/2011/10/Global-Menu.jpg [1] https://wiki.ubuntu.com/Unity/LauncherAPI?action=AttachFile&do=get&target=quicklilst-static-entry.png -- Thanks, Alexander. On 11/20/2015 05:36 PM, Yuri Nesterenko wrote: Hi Ale

Re: Review-request for 8143227: Platform-Specific Desktop Features

p/unix/native/libawt_xawt/awt/gtk2_interface.c#l478 Thanks, Alexander. On 11/19/2015 05:41 PM, Yuri Nesterenko wrote: Hi Alexander, I tried it with Ubuntu 14.04.3, and it started indeed from dash or a command line as a gray rectangle. Once I added isSupported() for every Action and separately for the

Re: Review-request for 8143227: Platform-Specific Desktop Features

Hi Alexander, I tried it with Ubuntu 14.04.3, and it started indeed from dash or a command line as a gray rectangle. Once I added isSupported() for every Action and separately for the Taskbar, it reported, just like jdk9b91, that only OPEN was supported and nothing else. Is it OK? dconf editor i

Re: [9] Review Request: 8011541 [TEST_BUG] closed/javax/swing/plaf/metal/MetalUtils/bug6190373.java fails NPE since 7u25b03

+1 -yan On 10/21/2015 07:32 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The test emulate implementation of two applets inside one vm. It has two threads in two different threads groups, for one of them it creates an appcontext, and the test assumes that for the main threa

Re: [9] Review Request: 8134732 [TEST_BUG] Test java/awt/applet/Applet/AppletFlipBuffer.java fails on Windows with AWTException

Fine with me. -yan On 09/24/2015 10:55 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The test for JDK-8130390 (which fixed an unspecified ClassCastException) doesn't take into account that the createBufferStrategy() method can throw the specified exception(AWTException) for

Re: [awt-dev] Request for Approval and Review: JDK-8136592 [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw

OK, +1. -yan On 10/05/2015 12:43 PM, Renjith Alexander wrote: Hi All, Please find the updated webrev at: http://cr.openjdk.java.net/~pchopra/8136592/webrev.01/ Regards, Renjith. -Original Message- From: Yuri Nesterenko Sent: Wednesday, September 30, 2015 5:20 PM To: Renjith

Re: [awt-dev] Request for Approval and Review: JDK-8136592 [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw

Looks good but I think you should (1) provide in the copyright notices a year of the actual test creation (see how it is done in the updated old tests); (2) provide a copyright notice in the html as well. I tried the multiscreen test on my setup, it worked well with both jdk9 and jigsaw build. -

Re: Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

Looks much better now:-) -yan On 09/15/2015 12:02 PM, Renjith Alexander wrote: Hi Andrei, Please see the updated version: http://cr.openjdk.java.net/~pchopra/8132380/webrev.01/ Regards, Renjith. *From:*Andrei Eremeev *Sent:* Friday, September 11, 2015 6:34 PM *To:* Renjith Alexander; awt-dev

Re: Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

Looks OK to me. -yan On 09/11/2015 01:16 PM, Renjith Alexander wrote: Hi all, Please review the fix for the bug: JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java BUG ID -*https://bugs.openjdk.java.net/browse/JDK-8132380 * The webrev is:http://cr

Re: [9] Review Request: 8076178 [macosx] Few open swing and awt reg-tests fail after their update to avoid SunToolkit.realSync

Fix looks OK, great to have it, finally: thank you! -yan On 08/31/2015 02:19 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The workaround for JDK-7185258 is removed, because it cause instability or failures of a number of tests. Note that the bug JDK-7185258 is not OSX spec

Re: [awt-dev] Request for Approval and Review: JDK-8133027: [Jigsaw] Test java/awt/PrintJob/Text/stringwidth.sh fails during compilation

Looks OK. -yan On 08/20/2015 11:08 AM, Renjith Alexander wrote: Hi all, Please review the fix for the bug: JDK-8133027: [Jigsaw] Test java/awt/PrintJob/Text/stringwidth.sh fails during compilation BUG ID -*https://bugs.openjdk.java.net/browse/JDK-8133027* The webrev is: http://cr.openjdk.

Re: [9] Review Request for 8132958: [TEST_BUG] Part 1: update client tests failing after changes in setAccessible(true) routine

On 08/13/2015 01:08 PM, Alexander Scherbatiy wrote: On 8/13/2015 10:36 AM, Yuri Nesterenko wrote: Oops, sorry, Alexander, I have missed that. This means that the test cannot be fixed in current JDK9 (before Jigsaw integration) and should be treated elsewhere, hard way. It can be split into

Re: [9] Review Request for 8132958: [TEST_BUG] Part 1: update client tests failing after changes in setAccessible(true) routine

/2015 4:29 PM, Yuri Nesterenko wrote: Colleagues, please review this test-only fix. Some tests would need more elaborate permissions now to access the private methods of internal classes. CR is https://bugs.openjdk.java.net/browse/JDK-8132958 Webrev see in http://cr.openjdk.java.net/~yan/8132958

Re: [9] Review Request for 8132958: [TEST_BUG] Part 1: update client tests failing after changes in setAccessible(true) routine

wrote: The test/java/awt/image/MultiResolutionImageTest.java has part which can be run on all platforms. There is the specific check for Mac OS X dependent part. It looks like the test does not need to have the @requires mac tag. Thanks, Alexandr. On 8/12/2015 4:29 PM, Yuri Nesterenko

[9] Review Request for 8132958: [TEST_BUG] Part 1: update client tests failing after changes in setAccessible(true) routine

Colleagues, please review this test-only fix. Some tests would need more elaborate permissions now to access the private methods of internal classes. CR is https://bugs.openjdk.java.net/browse/JDK-8132958 Webrev see in http://cr.openjdk.java.net/~yan/8132958/webrev.00/ A diff in a moved closed t

Re: [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

Fine with me. -yan On 08/07/2015 01:56 PM, Renjith Alexander wrote: Hi all, Please review the fix for the bug: JDK-8132376: Add @requires os.family to the client tests with access to internal OS-specific API BUG ID -*https://bugs.openjdk.java.net/browse/JDK-8132376* The webrev is:http://c

[9] Review request for 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows

Colleagues, please review this small test-only fix for https://bugs.openjdk.java.net/browse/JDK-6544871 Webrev: http://cr.openjdk.java.net/~yan/6544871/webrev.00 As a result, the test should pass on Windows without stray Ctrl keypress left in the keyboard buffer. Thanks, -yan

[9] Review Request for 8131673: [TEST_BUG] add @modules to some OS X-specific regtests

Colleagues, please review this test fix for 3 tests reflecting com.apple.eawt. After the fix, they should start with a modular build. Two of them dealing with fullscreen, should now work better on OS X 10.9. I cannot, however, easily fix them for OS X 10.10 where full screen button is in differen

Re: [9] Review Request for 8130125: [TEST_BUG] add @modules to the several client tests unaffected by the automated bulk update

o not break the fix for 8075609(at least the test should check what component should has a focus). On 02.07.15 17:35, Yuri Nesterenko wrote: Hi, could you please take a look at the 2nd version: http://cr.openjdk.java.net/~yan/8130125/webrev.01 Bug is here: https://bugs.openjdk.java.net/brows

Re: [9] Review Request for 8130125: [TEST_BUG] add @modules to the several client tests unaffected by the automated bulk update

Hi, could you please take a look at the 2nd version: http://cr.openjdk.java.net/~yan/8130125/webrev.01 Bug is here: https://bugs.openjdk.java.net/browse/JDK-8130125 Thanks, -yan On 07/02/2015 04:50 PM, Yuri Nesterenko wrote: On 07/02/2015 03:57 PM, Sergey Bylokhov wrote: Hi, Yuri

Re: [9] Review Request for 8130125: [TEST_BUG] add @modules to the several client tests unaffected by the automated bulk update

ports. - JSplitPaneOverlapping please split the long description - bug6608456 why it needs com.sun.java.swing? That's for SwingUtilities3 (sic)! I'll be back with logging and description. Thank you! -yan On 02.07.15 13:55, Yuri Nesterenko wrote: Colleagues, please review this te

[9] Review Request for 8130125: [TEST_BUG] add @modules to the several client tests unaffected by the automated bulk update

Colleagues, please review this test change: http://cr.openjdk.java.net/~yan/8130125/webrev.00/ In the most of the tests just @modules directive added; other than that, see a short comment in https://bugs.openjdk.java.net/browse/JDK-8130125 Also I'd like to piggyback in the push 3 tests moved fr

Re: debugging a regression

Well, yes, I'm afraid so. On Nimbus, however, I don't see any degradation, and it seems that after switching from Nimbus to Metal or GTK SwingSet2 is more responsive. But the fix is not in this PIT, is it? -yan On 07/01/2015 06:27 PM, Phil Race wrote: BTW I meant to send email on this but yeste

Re: RFR: JDK-8076468 Add @modules to tests in jdk_desktop test group

Hi Alexander, the fix looks OK to me. Thanks, -yan On 06/22/2015 06:44 PM, Alexander Kulyakhtin wrote: Hi, Could you, please, review the test-only changes for the JDK-8076468 CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group" Webrev: http://cr.openjdk.java.net/~akulyakh/80

Re: [9] Review Request for 8081306: remove imports of the internal API from some regression tests

rs in the moved tests, but the webrev.diff does not contain this. So the fix looks fine. On 17.06.15 15:47, Sergey Bylokhov wrote: Hi, Yuri. I think you should update the copyrights also. On 17.06.15 15:30, Yuri Nesterenko wrote: Colleagues, please review this test fix to https://bugs.openjdk.jav

[9] Review Request for 8081306: remove imports of the internal API from some regression tests

Colleagues, please review this test fix to https://bugs.openjdk.java.net/browse/JDK-8081306 Webrev http://cr.openjdk.java.net/~yan/8081306/webrev.00 closed tests moved to open, diffs: http://cr.openjdk.java.net/~yan/8081306/webrev.diff.00 From the tests removed some unused import instructions.

Re: RFR: JDK-8076468: Add @modules to jtreg jdk_desktop tests to take into account the new modular architecture

Hi Alexander(s), I have some problems not with this change but with the routine itself. As I understand, this change is automatically generated. The generator script is imperfect. For instance, it cannot catch dependencies in places like javax/swing/RepaintManager/6608456/bug6608456.java where t

Re: [9] Review Request: JDK-8080932 [TEST_BUG] Test java/awt/BasicStroke/DashStrokeTest.java fails with Bad script error due to improper @run notation

Hi Pooja, looks OK to me. Thanks, -yan On 05/22/2015 04:53 PM, pooja chopra wrote: Hello, Please review a fix for issue: 8080932 [TEST_BUG] Test java/awt/BasicStroke/DashStrokeTest.java fails with Bad script error due to improper @run notation Test bug fix. https://bugs.openjdk.java.net/

Re: [9] Review Request: 8015900 [TEST_BUG] ScrollbarMouseWheelTest failed on ubuntu 12 with unity and unity 2D

Hi Sergey, fine with me. BTW will it work on the multimonitor OS X configuration:-)? -yan On 05/07/2015 06:29 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The test has incorrect assumption that the new window usually opens in the top-left corner of the window, and moves t

Re: [9] Review Request for 8074807: Fix some tests unnecessary using internal API

find "Resolved" date, and guess it is the date, but the test is appearing in the repo now, in 2015. Finally, JDK code is updated every year by a script. Perhaps that script can distinguish important change from unimportant, I don't know. -yan On 03/17/2015 04:28 AM, Yuri Nesterenk

[9] Review Request for 8074807: Fix some tests unnecessary using internal API

Colleagues, please review this test fix to https://bugs.openjdk.java.net/browse/JDK-8074807 Webrev: http://cr.openjdk.java.net/~yan/8074807/webrev.00/ 5 closed tests moved to open after this change: http://cr.openjdk.java.net/~yan/8074807/webrev.diff.00/ Resulting tests don't use internal API.

Re: [9] Review Request for 8074092: Newly introduced unnecessary dependencies on internal API in client regtests

with @library /javax/swing/regtesthelper @library /lib/testlibrary Library path is concatenated to the directory in which TEST.ROOT is located. Andrei Eremeev On 03/04/2015 04:28 PM, Yuri Nesterenko wrote: Hi! Please review this fix for several regression tests. Webrev: http://cr.openjdk.java.net

Re: [9] Review Request: 8074028 Remove API references to java.awt.peer

On 03/04/2015 04:35 PM, Sergey Bylokhov wrote: On 04.03.2015 15:51, Alan Bateman wrote: On 04/03/2015 12:37, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public API whichreference the unsupported java.awt.peer interfaces. public java.awt.Component.getPee

[9] Review Request for 8074092: Newly introduced unnecessary dependencies on internal API in client regtests

Hi! Please review this fix for several regression tests. Webrev: http://cr.openjdk.java.net/~yan/8074092/webrev.00 CR: https://bugs.openjdk.java.net/browse/JDK-8074092 In bug8062561.java test an error message also changed. Verified on 3 platforms. Thanks, -yan

Re: [9] Review Request: 8068275 Some tests failed after JDK-8063104

OK, it's even better. -yan On 12/25/2014 05:43 PM, Alexander Zvegintsev wrote: Sergey, the fix still looks good to me. -- Thanks, Alexander. 25.12.2014 17:36, Sergey Bylokhov пишет: Hi, Alexander. On 25.12.2014 17:26, Alexander Zvegintsev wrote: but I think it can be improved by saving robo

Re: [9] Review Request: 8068275 Some tests failed after JDK-8063104

Hi Sergey, fix is OK with me. -yan On 12/25/2014 05:08 PM, Sergey Bylokhov wrote: Hello. Please review a small fix for jdk 9. The problem is in the Util.waitForIdle(Robot) which does not take into account that robot can be null. Bug: https://bugs.openjdk.java.net/browse/JDK-8068275 Webrev can

Re: [9] Review Request for 8063104: Change open awt regression tests to avoid sun.awt.SunToolkit.realSync, part 2

On 12/03/2014 05:48 PM, Yuri Nesterenko wrote: Thank you Sergey, On 12/03/2014 04:23 PM, Sergey Bylokhov wrote: Hi, Yuri. It will be good to add setAutoDelay(50) to these tests, because they press keys w/o delays: - KeyCharTest - DragMouseOutAndRelease - GetSizeTest - PopupPosTest - UnfocusableC

Re: [9] Review Request for 8063104: Change open awt regression tests to avoid sun.awt.SunToolkit.realSync, part 2

gtest written on a different principle. -yan On 02.12.2014 19:35, Yuri Nesterenko wrote: Added more useful http://cr.openjdk.java.net/~yan/8063104/webrev.diff.00_1 diff between old closed and new open versions. Thanks, -yan On 12/02/2014 03:26 PM, Yuri Nesterenko wrote: Colleagues, please r

Re: [9] Review Request for 8063104: Change open awt regression tests to avoid sun.awt.SunToolkit.realSync, part 2

Added more useful http://cr.openjdk.java.net/~yan/8063104/webrev.diff.00_1 diff between old closed and new open versions. Thanks, -yan On 12/02/2014 03:26 PM, Yuri Nesterenko wrote: Colleagues, please review this test fix. http://cr.openjdk.java.net/~yan/8063104/webrev.00 pre-move state of

[9] Review Request for 8063104: Change open awt regression tests to avoid sun.awt.SunToolkit.realSync, part 2

Colleagues, please review this test fix. http://cr.openjdk.java.net/~yan/8063104/webrev.00 pre-move state of the closed tests: http://cr.openjdk.java.net/~yan/8063104/webrev.diff.00 There are modularization-related changes in (plus certain cleanup of) some 66 awt tests and some helper classes.

[9] Review request for 8063102: Change open awt regression tests to avoid sun.awt.SunToolkit.realSync, part 1

Colleagues, please review the first batch of 34 regression tests modified to eliminate internal references (mostly to realSync but not only). Several closed tests moved in the open. Change: http://cr.openjdk.java.net/~yan/8063102/webrev.00 removal diff: http://cr.openjdk.java.net/~yan/8063102/w

Re: Review Request for 8062606: Fix a typo in java.awt.Robot class

Hi Dima, fix looks OK to me. -yan On 10/31/2014 12:14 PM, Dmitriy Ermashov wrote: Hi, There was a small typo in a fix for 8056911 that broke build process Please review the changeset for fixing the typo: http://cr.openjdk.java.net/~dermashov/8062606/webrev.00/ Corresponding bug: https://bugs

Re: [9] Review Request: JDK-8058805 Fix type in client-related package for tray.policy file missing in java/awt/TrayIcon/SecurityCheck/NoPermissionTest

://bugs.openjdk.java.net/browse/JDK-8058805 Please review further . Regards, Pooja On 10/15/2014 1:06 PM, Yuri Nesterenko wrote: Hi Pooja, perhaps it would be better to have _something_ in this policy file, for instance a comment. Thanks, -yan On 09/30/2014 05:46 PM, pooja chopra wrote: Hello All, Gentle reminder

Re: [9] Review Request: JDK-8058805 Fix type in client-related package for tray.policy file missing in java/awt/TrayIcon/SecurityCheck/NoPermissionTest

Hi Pooja, perhaps it would be better to have _something_ in this policy file, for instance a comment. Thanks, -yan On 09/30/2014 05:46 PM, pooja chopra wrote: Hello All, Gentle reminder . Please review below fix . Regards, Pooja On 9/19/2014 5:04 PM, pooja chopra wrote: |Hello, | || |Please

Re: [9] Review request for 8058726: Update regtests using sun.awt.OSInfo, part 1

Great, thank you! -yan On 09/18/2014 04:30 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 9/18/2014 2:48 PM, Yuri Nesterenko wrote: Colleagues, please review this change in tests only: http://cr.openjdk.java.net/~yan/8058726/webrev.00 and http

[9] Review request for 8058726: Update regtests using sun.awt.OSInfo, part 1

Colleagues, please review this change in tests only: http://cr.openjdk.java.net/~yan/8058726/webrev.00 and http://cr.openjdk.java.net/~yan/8058726/webrev.diff.00 for a bug https://bugs.openjdk.java.net/browse/JDK-8058726 Thanks, -yan

Re: [9] Review Request for 8056991: Provide OSInfo functionality to regression tests

Thank you Alexander! I hope I may push it with your single review: the change is in test area and seems virtually harmless. Cheers, -yan On 09/15/2014 03:13 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 9/15/2014 3:00 PM, Yuri Nesterenko wrote: On

Re: [9] Review Request for 8056991: Provide OSInfo functionality to regression tests

se in Swing classes. I'm retaining it because (1) no harm in it and (2) this way, it would be much simpler to maintain a duplicate of sun.awt.OSInfo in case of a change. -yan Thanks, Alexandr. On 9/15/2014 11:35 AM, Yuri Nesterenko wrote: Dear friends, one more weekly reminder! Withou

[9] Review Request for 8056991: Provide OSInfo functionality to regression tests

Dear friends, one more weekly reminder! Without this (or similar) fix applied, we cannot start changes of ~60 regtests, and time is short. Cheers, -yan On 09/08/2014 01:09 PM, Yuri Nesterenko wrote: Weekly reminder! Cheers, -yan On 09/01/2014 12:44 PM, Yuri Nesterenko wrote: Colleagues

Re: Review Request for 8056911: Remove internal API usage from ExtendedRobot class

chronized on the robot object), and should we add a new static methods now? Probably creation of the Robot is not a big problem? -- best regards, Anthony On 9/10/2014 3:45 PM, Yuri Nesterenko wrote: So it will be in Robot. (1) Now, we have some 82 tests calling the static realSync() without in

Re: Review Request for 8056911: Remove internal API usage from ExtendedRobot class

#x27;ve decided that adding new method to Toolkit class with similar to sync() method functionality but with a different name could hardly look elegant, and besides, new solution could be less conspicuous. Thanks, Dima On 09/01/2014 04:49 PM, Yuri Nesterenko wrote: Phil, perhaps javadoc should b

Re: Review Request for 8056911: Remove internal API usage from ExtendedRobot class

x27;ve decided that adding new method to Toolkit class with similar to sync() method functionality but with a different name could hardly look elegant, and besides, new solution could be less conspicuous. Thanks, Dima On 09/01/2014 04:49 PM, Yuri Nesterenko wrote: Phil, perhaps javadoc should be c

Re: Review Request for 8056911: Remove internal API usage from ExtendedRobot class

n 09/01/2014 04:49 PM, Yuri Nesterenko wrote: Phil, perhaps javadoc should be changed, yes. It is the first public spec for Dmitriy. As to the narrow purpose, are you serious? We have nothing to replace this invention. Original idea was to replace Toolkit.sync() with realSync() but after JDK-625

[9] Review Request for 8056991: Provide OSInfo functionality to regression tests

Weekly reminder! Cheers, -yan On 09/01/2014 12:44 PM, Yuri Nesterenko wrote: Colleagues, please review this minimal change to fix https://bugs.openjdk.java.net/browse/JDK-8056991 http://cr.openjdk.java.net/~yan/8056991/webrev.00 In the webrev there is an example of a test refactored. We

Re: CFV: New AWT group member: Alexander Zvegintsev

Vote: yes -yan On 09/03/2014 02:44 PM, Artem Ananiev wrote: I hereby nominate Alexander Zvegintsev (OpenJDK user name: azvegint) to Membership in the AWT Group. Alexander is a member of AWT/Swing group at Oracle. He has contributed 20+ fixes to JDK9 so far, and JDK8/8u contribution is signifi

Re: Review Request for 8056911: Remove internal API usage from ExtendedRobot class

Phil, perhaps javadoc should be changed, yes. It is the first public spec for Dmitriy. As to the narrow purpose, are you serious? We have nothing to replace this invention. Original idea was to replace Toolkit.sync() with realSync() but after JDK-6252005 Denis left us, there was no resources and

[9] Review Request for 8056991: Provide OSInfo functionality to regression tests

Colleagues, please review this minimal change to fix https://bugs.openjdk.java.net/browse/JDK-8056991 http://cr.openjdk.java.net/~yan/8056991/webrev.00 In the webrev there is an example of a test refactored. We need to clean up regression tests from internal dependencies. One of them, dependen

Re: The path to flavormap.properties is currently broken in SystemFlavorMap

On 09/01/2014 12:24 PM, Alan Bateman wrote: This does seem to a merge issue. When the source reorganization was pushed to jdk9/jdk9 (and immediately to jdk9/dev) then the resource was in sun/datatransfer. Soon afterwards there was an integration + merge from jdk9/client -> jdk9/dev that brough

Re: [9] Review request for 8055664: move 14 tests about setLocationRelativeTo to jdk

- Thanks, Alexander. On 08/26/2014 10:42 AM, Yuri Nesterenko wrote: A polite reminder! On 08/20/2014 04:09 PM, Yuri Nesterenko wrote: Hi team, please review this test update in jdk9: http://cr.openjdk.java.net/~yan/8055664/webrev.00 ( https://bugs.openjdk.java.net/browse/JDK-8055664 ) The

Re: Review Request for 8039749: Migrate needed functionality from all subclasses of java.awt.Robot in jdk/test directory to the ancestor

On 08/27/2014 04:25 PM, Dmitriy Ermashov wrote: Hi Anthony, Thanks for your review. At first, let me focus on fact that the actual motivation of moving functionality to java.awt.Robot is the Jigsaw project. We (SQE) will be unable to use internal java API after the project will be finished (Ext

[9] Review request for 8055664: move 14 tests about setLocationRelativeTo to jdk

A polite reminder! On 08/20/2014 04:09 PM, Yuri Nesterenko wrote: Hi team, please review this test update in jdk9: http://cr.openjdk.java.net/~yan/8055664/webrev.00 ( https://bugs.openjdk.java.net/browse/JDK-8055664 ) There's a single test made out of 14 old internal functional

  1   2   3   >