Re: [10] Review Request: 8186559 [macos] the screen location is wrong when using AWT/SWT bridge with dual monitors

2017-10-20 Thread Semyon Sadetsky
+1 --Semyon On 09/18/2017 03:04 PM, Sergey Bylokhov wrote: On 9/18/17 09:53, Semyon Sadetsky wrote: On 09/15/2017 02:29 PM, Sergey Bylokhov wrote: It is broken from the moment when it was implemented(I have rechecked on 8u121 which was mentioned in the report), unlike Apple jdk where it

Re: [10] Review Request: 8186559 [macos] the screen location is wrong when using AWT/SWT bridge with dual monitors

2017-09-22 Thread Dmitry Markov
Hi Sergey, The fix still looks good for me. Thanks, Dmitry > On 18 Sep 2017, at 23:04, Sergey Bylokhov wrote: > > On 9/18/17 09:53, Semyon Sadetsky wrote: >> On 09/15/2017 02:29 PM, Sergey Bylokhov wrote: >>> It is broken from the moment when it was implemented(I

Re: [10] Review Request: 8186559 [macos] the screen location is wrong when using AWT/SWT bridge with dual monitors

2017-09-18 Thread Sergey Bylokhov
On 9/18/17 09:53, Semyon Sadetsky wrote: On 09/15/2017 02:29 PM, Sergey Bylokhov wrote: It is broken from the moment when it was implemented(I have rechecked on 8u121 which was mentioned in the report), unlike Apple jdk where it worked. Then probably the regression label need to be removed

Re: [10] Review Request: 8186559 [macos] the screen location is wrong when using AWT/SWT bridge with dual monitors

2017-09-18 Thread Semyon Sadetsky
On 09/15/2017 02:29 PM, Sergey Bylokhov wrote: It is broken from the moment when it was implemented(I have rechecked on 8u121 which was mentioned in the report), unlike Apple jdk where it worked. Then probably the regression label need to be removed from the bug? Should the main screen also

Re: [10] Review Request: 8186559 [macos] the screen location is wrong when using AWT/SWT bridge with dual monitors

2017-09-15 Thread Sergey Bylokhov
It is broken from the moment when it was implemented(I have rechecked on 8u121 which was mentioned in the report), unlike Apple jdk where it worked. On 9/15/17 08:55, Semyon Sadetsky wrote: Hi Sergey, what was caused the regression? --Semyon On 9/14/2017 3:46 PM, Sergey Bylokhov wrote:

Re: [10] Review Request: 8186559 [macos] the screen location is wrong when using AWT/SWT bridge with dual monitors

2017-09-15 Thread Semyon Sadetsky
Hi Sergey, what was caused the regression? --Semyon On 9/14/2017 3:46 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk10. Bug: https://bugs.openjdk.java.net/browse/JDK-8186559 Webrev can be found at: http://cr.openjdk.java.net/~serb/8186559/webrev.00 When our NSView is

Re: [10] Review Request: 8186559 [macos] the screen location is wrong when using AWT/SWT bridge with dual monitors

2017-09-15 Thread Dmitry Markov
Hi Sergey, The fix looks good to me. Thanks, Dmitry > On 14 Sep 2017, at 23:46, Sergey Bylokhov wrote: > > Hello, > Please review the fix for jdk10. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8186559 > Webrev can be found at:

[10] Review Request: 8186559 [macos] the screen location is wrong when using AWT/SWT bridge with dual monitors

2017-09-14 Thread Sergey Bylokhov
Hello, Please review the fix for jdk10. Bug: https://bugs.openjdk.java.net/browse/JDK-8186559 Webrev can be found at: http://cr.openjdk.java.net/~serb/8186559/webrev.00 When our NSView is embedded in native to the SWT-based NSWindow we incorrectly fetch the location of the NSView. The reason