of
changing it.
Krishna
*From:*Magnus Ihse Bursie
*Sent:* Tuesday, November 27, 2018 6:52 PM
*To:* Krishna Addepalli
*Cc:* Philip Race ; awt-dev@openjdk.java.net;
2d-dev <2d-...@openjdk.java.net>; build-dev
*Subject:* Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]:
Resolve disabled warning
ovember 27, 2018 6:52 PM
> To: Krishna Addepalli
> Cc: Philip Race ; awt-dev@openjdk.java.net; 2d-dev
> <2d-...@openjdk.java.net>; build-dev
> Subject: Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve
> disabled warnings for libawt_xawt
>
> I normally do not commen
@openjdk.java.net; 2d-dev
<2d-...@openjdk.java.net>; build-dev
Subject: Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve
disabled warnings for libawt_xawt
I normally do not comment on component source code changes, but I glanced
through this and noticed that a lot of size_t values are
any crashes.
>
> Thanks,
> Krishna
>
> From: Krishna Addepalli
> Sent: Tuesday, October 2, 2018 8:53 PM
> To: Philip Race
> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; build-dev
>
> Subject: Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Reso
K3 and did not find any crashes.
Thanks,
Krishna
From: Krishna Addepalli
Sent: Tuesday, October 2, 2018 8:53 PM
To: Philip Race
Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; build-dev
Subject: Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve
disabled warnings
On 30/09/2018 20:48, Krishna Addepalli wrote:
By using static_cast, I have maintained the existing behaviour. I’m not sure
about which function to use, but should we address it separately, or here
itself?
But the existed behavior might maintained without this fix, right? with
one exception t
Yes, that is right.
I have compiled it Mac, Linux and Windows locally. I tried submitting a Mach5
job, but was unable to as it was down. Will try it again.
Thanks
Krishna
> On 02-Oct-2018, at 3:39 AM, Philip Race wrote:
>
> I suspect I understand this one now .. the array is stack allocated so
I suspect I understand this one now .. the array is stack allocated so
we don't want NULL
but the compiler probably complained about possible uninitialised use of
the values ?
-phil.
On 10/1/18, 9:38 AM, Philip Race wrote:
You really do need to explain *each* of the changes better.
This one .
You really do need to explain *each* of the changes better.
This one .. why not NULL ?
http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html
-phil
On 10/1/18, 9:19 AM, Philip Race wrote:
Hi,
1) Has this been built on
Hi,
1) Has this been built on all platforms ?
2) I can't find the list of warnings that you are seeing and fixing and
they are all over the place.
So adding 2d-dev and build-dev.
For each of these changes, please show what was the warning that you
received from the compiler
This might sound l
Hi Sergey,
By using static_cast, I have maintained the existing behaviour. I’m not sure
about which function to use, but should we address it separately, or here
itself?
Thanks,
Krishna
> On 01-Oct-2018, at 8:33 AM, Sergey Bylokhov
> wrote:
>
> Hi, Krishna.
> One initial question about awt_
Hi, Krishna.
One initial question about awt_Window.cpp:
2150 w = static_cast((rect.right - rect.left) * scaleX /
prevScaleX);
2151 h = static_cast((rect.bottom - rect.top) * scaleY /
prevScaleY);
Are you sure that we need to use "cast" instead of ScaleUp/Down?
On 29/09/2018 20:18, Kr
Hi All,
Please review a fix for JDK-8074824:
https://bugs.openjdk.java.net/browse/JDK-8074824
Webrev: http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/
Most of the warnings have been fixed for Linux, Mac and Windows.
Thanks,
Krishna
13 matches
Mail list logo
