Hi All,
Please review a fix for JDK-8014503:
https://bugs.openjdk.java.net/browse/JDK-8014503
Webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev00/
On Windows, the default behavior has been changed to not send an ItemEvent, if
the same item is selected again, whereas this was
: JDK-8014503: AWT Choice implementation should be
made consistent across platforms.
Hi All,
Please review a fix for JDK-8014503:
https://bugs.openjdk.java.net/browse/JDK-8014503
Webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev00/
On Windows, the default behavior has been
To: Krishna Addepalli ; awt-dev@openjdk.java.net
Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should
be made consistent across platforms.
Hi Krishna, Below are the comments on the fix that you made.
1. Based on the getSelectedIndex(), I think the selectedIndex should
To: Shashidhara Veerabhadraiah ;
awt-dev@openjdk.java.net
Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should
be made consistent across platforms.
Hi Shashi,
Thanks for the review. Here is the updated webrev:
http://cr.openjdk.java.net/~kaddepalli/8014503/webrev01/
As for t
hna
From: Shashidhara Veerabhadraiah
Sent: Monday, July 2, 2018 11:30 PM
To: Krishna Addepalli mailto:krishna.addepa...@oracle.com"krishna.addepa...@oracle.com>; HYPERLINK
"mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net
Subject: RE: [12]RFR : JDK-8014503: AWT Choi
t: Tuesday, July 3, 2018 1:15 PM
To: Shashidhara Veerabhadraiah ; Krishna
Addepalli ; awt-dev@openjdk.java.net
Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should
be made consistent across platforms.
Can we use existing 'skipPostMessage' member for this check instead of
quot;krishna.addepa...@oracle.com>; HYPERLINK
"mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net
Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should
be made consistent across platforms.
Can we use existing 'skipPostMessage' member for thi
hashidhara Veerabhadraiah; HYPERLINK
"mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net
Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should
be made consistent across platforms.
Hi Ajit,
I don't think we can use 'skipPostMessage' for this c
awt-dev@openjdk.java.net>
*Subject:* RE: [12]RFR : JDK-8014503: AWT Choice
implementation should be made consistent across platforms.
Hi Ajit,
I don’t think we can use ‘skipPostMessage’ for this check for the
following reasons:
1.‘skipPostMessage’ is intended to filter out item unse
});
}
}
Thanks,
Krishna
-Original Message-
From: Sergey Bylokhov
Sent: Thursday, July 5, 2018 8:10 PM
To: Krishna Addepalli ; Ajit Ghaisas
; Shashidhara Veerabhadraiah
; awt-dev@openjdk.java.net
Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should
be made
On 13/08/2018 11:06, Krishna Addepalli wrote:
The fix I propose is modeled after the code in Windows, which tracks items by
their selected index. The code in Mac is storing currently selected object,
which could raise the question about which object to select next, when the
selected object is
it Ghaisas
; Shashidhara Veerabhadraiah
; awt-dev@openjdk.java.net
Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should
be made consistent across platforms.
On 13/08/2018 11:06, Krishna Addepalli wrote:
> The fix I propose is modeled after the code in Windows, which tracks item
18 7:52 AM
To: Krishna Addepalli ; Ajit Ghaisas
; Shashidhara Veerabhadraiah
; awt-dev@openjdk.java.net
Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should
be made consistent across platforms.
On 13/08/2018 11:06, Krishna Addepalli wrote:
The fix I propose is modeled after t
t;> -Original Message-
>> From: Sergey Bylokhov
>> Sent: Tuesday, August 14, 2018 7:52 AM
>> To: Krishna Addepalli ; Ajit Ghaisas
>> ; Shashidhara Veerabhadraiah
>> ; awt-dev@openjdk.java.net
>> Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementat
To: Krishna Addepalli <mailto:krishna.addepa...@oracle.com>>; Ajit Ghaisas
mailto:ajit.ghai...@oracle.com>>;
Shashidhara Veerabhadraiah <mailto:shashidhara.veerabhadra...@oracle.com>>;
awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>
Subject: Re: [12]RFR : JD
-dev@openjdk.java.net
Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should
be made consistent across platforms.
Hi, Krishna.
Why did you update the test? Before the fix the robot used the middle of the
first element, but after the fix it will click on the first pixel of the first
Addepalli
Cc: Ajit Ghaisas ; Shashidhara Veerabhadraiah
; awt-dev@openjdk.java.net
Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should
be made consistent across platforms.
Hi, Krishna.
Why did you update the test? Before the fix the robot used the middle of the
first element, but
17 matches
Mail list logo