Looks good to me.
On 5/30/16 7:39 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
The test DefaultPolicyChange_Swing.java has two issues:
- It uses invokeLater(), so the test usually pass before the code is
executed on the EDT, because the main thread completes before.
- T
On 6/9/2016 12:37 PM, Sergey Bylokhov wrote:
On 08.06.16 19:53, Semyon Sadetsky wrote:
Yes, but the Object#equlas() does not prohibit different class instances
to be equal. The purpose of the test is to prove that existing
component's FTP instances remain untouchable during the default FTP
chan
On 08.06.16 19:53, Semyon Sadetsky wrote:
Yes, but the Object#equlas() does not prohibit different class instances
to be equal. The purpose of the test is to prove that existing
component's FTP instances remain untouchable during the default FTP
change regardless of the specific FTP implementatio
On 6/8/2016 5:37 PM, Sergey Bylokhov wrote:
On 08.06.16 10:12, Semyon Sadetsky wrote:
Since method equals() is not specified in the FTP class, you cannot make
any assumption how it is implemented, it may return true for different
classes instances. So in the test the policy untouchability shoul
On 08.06.16 10:12, Semyon Sadetsky wrote:
Since method equals() is not specified in the FTP class, you cannot make
any assumption how it is implemented, it may return true for different
classes instances. So in the test the policy untouchability should be
checked by ==, without any additional ass
On 6/7/2016 3:31 PM, Sergey Bylokhov wrote:
On 07.06.16 12:31, Semyon Sadetsky wrote:
I cannot agree with this assumption. Since the policy should not be
touched for the existing components, the test should prove that the
policy object instances are the same, other behavior is an error.
The p
On 07.06.16 12:31, Semyon Sadetsky wrote:
I cannot agree with this assumption. Since the policy should not be
touched for the existing components, the test should prove that the
policy object instances are the same, other behavior is an error.
The policy will be the same if two policies will re
On 6/7/2016 11:48 AM, Sergey Bylokhov wrote:
On 07.06.16 10:23, Semyon Sadetsky wrote:
Sergey,
- You need to compare with the original policy by reference. Only by
that you may prove that the original policies were not affected.
I do not see the reason why the equal cannot be used, if some
On 07.06.16 10:23, Semyon Sadetsky wrote:
Sergey,
- You need to compare with the original policy by reference. Only by
that you may prove that the original policies were not affected.
I do not see the reason why the equal cannot be used, if some policy
will override equal and return true then
Sergey,
- You need to compare with the original policy by reference. Only by
that you may prove that the original policies were not affected.
- Please remove the printouts of policies objects before and after the
default policy change. It looks too verbose.
- It would be nice to have a chec
Hello Sergey,
The fix looks good (not a reviewer).
Thanks,
Alexander
On 5/30/2016 7:39 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
The test DefaultPolicyChange_Swing.java has two issues:
- It uses invokeLater(), so the test usually pass before the code is
executed on t
+1
-yan
On 05/30/2016 07:39 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
The test DefaultPolicyChange_Swing.java has two issues:
- It uses invokeLater(), so the test usually pass before the code is
executed on the EDT, because the main thread completes before.
- The te
Hello.
Please review the fix for jdk9.
The test DefaultPolicyChange_Swing.java has two issues:
- It uses invokeLater(), so the test usually pass before the code is
executed on the EDT, because the main thread completes before.
- The test fetches the FocusTraversalPolicy from the current
Keybo
13 matches
Mail list logo
