Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-11-03 Thread Semyon Sadetsky
+1 --Semyon On 03.11.2016 03:20, Sergey Bylokhov wrote: I guess we can extract some of the common logic in the fix, upto other reviewers, this looks fine to me. On 25.10.16 19:25, Alexander Zvegintsev wrote: Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-11-02 Thread Sergey Bylokhov
I guess we can extract some of the common logic in the fix, upto other reviewers, this looks fine to me. On 25.10.16 19:25, Alexander Zvegintsev wrote: Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/02/ Thanks, Alexander. On 10/11/16 5:00 PM, Alexander Zve

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-10-25 Thread Alexander Zvegintsev
Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/02/ Thanks, Alexander. On 10/11/16 5:00 PM, Alexander Zvegintsev wrote: Hi Sergey, Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/01/ As I can observe other windows such as

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-10-11 Thread Alexander Zvegintsev
Now I see, it's an unrelated issue. Is there any filed bug for this issue? I had similar one with JavaFX https://bugs.openjdk.java.net/browse/JDK-8160241 On 10/11/16 5:42 PM, Yuri Nesterenko wrote: Try to open JFileChooser dialog in SwingSet2 (before the fix) and click + to maximize it (I tr

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-10-11 Thread Yuri Nesterenko
Try to open JFileChooser dialog in SwingSet2 (before the fix) and click + to maximize it (I tried on 10.10 and 10.12): application is blocked by a modal dialog, and there's no way to see it. -yan On 10/11/2016 05:01 PM, Alexander Zvegintsev wrote: Actually I can't reproduce such behavior. On

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-10-11 Thread Alexander Zvegintsev
Actually I can't reproduce such behavior. On 9/30/16 5:12 PM, Semyon Sadetsky wrote: The fix looks good. Do you know why JDialog maximize button doesn't work? When I click on it the maximize button the dialog disappears. --Semyon On 9/6/2016 5:32 PM, Alexander Zvegintsev wrote: Hello, p

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-10-11 Thread Alexander Zvegintsev
Hi Sergey, Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/01/ As I can observe other windows such as native dialogs doesn't have fullscreen button. On 10/2/16 5:52 PM, Sergey Bylokhov wrote: Hi, Alexander. In the fix you use eawt events which are generat

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-10-02 Thread Sergey Bylokhov
Hi, Alexander. In the fix you use eawt events which are generated by the same peer. Why not use windowWill/DidEnterFullScreen + windowWill/DidExitFullScreen? Why the fix is for the Frames only, there are some limitations for other windows, dialogs etc? On 06.09.16 17:32, Alexander Zvegintsev w

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-09-30 Thread Semyon Sadetsky
The fix looks good. Do you know why JDialog maximize button doesn't work? When I click on it the maximize button the dialog disappears. --Semyon On 9/6/2016 5:32 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/00/ for the is

[9] Review request for 8143914: Provide Mac-specific fullscreen support

2016-09-06 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8143914 This fix adds the green FullScreen button to a resizable frames by default. Previous maximize behavior is still accessible by holding Alt while