Re: [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

2016-09-20 Thread Sergey Bylokhov
On 08.09.16 18:02, Alexander Zvegintsev wrote: Initially showWindowWithoutWarningBanner was added to deny the new API functions invocation without permission check, Looks fine. but now it seems redundant, so I left only canProcessApplicationEvents in the new webrev: cr.openjdk.java.net/~azv

Re: [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

2016-09-20 Thread Semyon Sadetsky
Looks good. --Semyon On 9/8/2016 6:02 PM, Alexander Zvegintsev wrote: Initially showWindowWithoutWarningBanner was added to deny the new API functions invocation without permission check, but now it seems redundant, so I left only canProcessApplicationEvents in the new webrev: cr.openjdk.

Re: [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

2016-09-08 Thread Alexander Zvegintsev
Initially showWindowWithoutWarningBanner was added to deny the new API functions invocation without permission check, but now it seems redundant, so I left only canProcessApplicationEvents in the new webrev: cr.openjdk.java.net/~azvegint/jdk/9/8164536/02/ -- Thanks, Alexander. On 09/08/2016

Re: [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

2016-09-08 Thread Sergey Bylokhov
On 31.08.16 3:27, Alexander Zvegintsev wrote: Hi Sergey, It could be, but actually RuntimePermission is used by eawt(sure we can change it too, but I don't see a point) It is still unclear to me why in most of the place we check two permissions? Can you please clarify what is the purpose of

Re: [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

2016-08-30 Thread Alexander Zvegintsev
Hi Sergey, It could be, but actually RuntimePermission is used by eawt(sure we can change it too, but I don't see a point) Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8164536/01/ -- Thanks, Alexander. On 30.08.2016 22:44, Sergey Bylokhov wrote: Hi, Alexander.

Re: [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

2016-08-30 Thread Sergey Bylokhov
Hi, Alexander. Probably the name of this permission can be added to AWTPermissions.java? I am not sure why some of the methods require "canProcessApplicationEvents" permission. For example Taskbar.getTaskbar()? I guess Desktop.getDesktop() is used a template but it does not throw such exception

[9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

2016-08-30 Thread Alexander Zvegintsev
Hello, Please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8164536/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8164536 This fix add check for canProcessApplicationEvents runtime permission(currently used by eawt) for Desktop and Taskbar classes. -- Thanks, Alex