Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-29 Thread Sergey Bylokhov
On 29.11.16 19:18, Semyon Sadetsky wrote: On 29.11.16 17:47, Semyon Sadetsky wrote: If the same coordinate system is shared by both screens, means that each point passed to the robot will be related to the(0,0). It is not necessary the (left/top) point of the screen because the screen itself can

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-29 Thread Semyon Sadetsky
On 11/29/2016 6:09 PM, Sergey Bylokhov wrote: On 29.11.16 17:47, Semyon Sadetsky wrote: If the same coordinate system is shared by both screens, means that each point passed to the robot will be related to the(0,0). It is not necessary the (left/top) point of the screen because the screen itsel

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-29 Thread Sergey Bylokhov
On 29.11.16 17:47, Semyon Sadetsky wrote: If the same coordinate system is shared by both screens, means that each point passed to the robot will be related to the(0,0). It is not necessary the (left/top) point of the screen because the screen itself can be shifted from the (0,0)/ That would mea

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-29 Thread Semyon Sadetsky
On 11/28/2016 11:13 PM, Sergey Bylokhov wrote: On 25.11.16 17:08, Semyon Sadetsky wrote: Then JDK-8013116 was fixed the request for specification update was created: https://bugs.openjdk.java.net/browse/JDK-8033128 Different coordinate system simply means different coordinate origins. This is

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-28 Thread Sergey Bylokhov
On 25.11.16 17:08, Semyon Sadetsky wrote: Then JDK-8013116 was fixed the request for specification update was created: https://bugs.openjdk.java.net/browse/JDK-8033128 Different coordinate system simply means different coordinate origins. This is the most natural behavior for the robot created f

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-25 Thread Semyon Sadetsky
On 11/25/2016 4:13 PM, Sergey Bylokhov wrote: On 24.11.16 22:21, Semyon Sadetsky wrote: All robots may be used to address any area of the desktop regardless of the screen constructor argument. The coordinate system is the only aspect the screen argument affects. This statement means that th

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-25 Thread Sergey Bylokhov
On 24.11.16 22:21, Semyon Sadetsky wrote: All robots may be used to address any area of the desktop regardless of the screen constructor argument. The coordinate system is the only aspect the screen argument affects. This statement means that this constructor will have any effects when used for

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-24 Thread Semyon Sadetsky
On 24.11.2016 21:50, Sergey Bylokhov wrote: On 24.11.16 21:05, Sergey Bylokhov wrote: All robots may be used to address any area of the desktop regardless of the screen constructor argument. The coordinate system is the only aspect the screen argument affects. This statement means that this c

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-24 Thread Sergey Bylokhov
On 24.11.16 21:05, Sergey Bylokhov wrote: All robots may be used to address any area of the desktop regardless of the screen constructor argument. The coordinate system is the only aspect the screen argument affects. This statement means that this constructor will have any effects when used for

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-24 Thread Sergey Bylokhov
On 24.11.16 20:36, Semyon Sadetsky wrote: Creates a Robot for the given screen device. Coordinates passed to Robot method calls like mouseMove and createScreenCapture will be interpreted as being in the same coordinate system as the specified screen. This is what I am talking about: "Coordinates

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-24 Thread Semyon Sadetsky
On 24.11.2016 20:29, Sergey Bylokhov wrote: On 24.11.16 20:20, Semyon Sadetsky wrote: Creates a Robot for the given screen device. Coordinates passed to Robot method calls like mouseMove and createScreenCapture will be interpreted as being in the same coordinate system as the specified screen.

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-24 Thread Sergey Bylokhov
On 24.11.16 20:20, Semyon Sadetsky wrote: Creates a Robot for the given screen device. Coordinates passed to Robot method calls like mouseMove and createScreenCapture will be interpreted as being in the same coordinate system as the specified screen. This is what I am talking about: "Coordinates

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-24 Thread Semyon Sadetsky
On 24.11.2016 18:44, Sergey Bylokhov wrote: On 24.11.16 18:27, Semyon Sadetsky wrote: Isn't the open test always passed before/after the fix? The open test was wrong from the time it was created. By the way, it was approved by you. I can fix this along with the current bug or I can file a sep

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-24 Thread Sergey Bylokhov
On 24.11.16 18:27, Semyon Sadetsky wrote: Isn't the open test always passed before/after the fix? The open test was wrong from the time it was created. By the way, it was approved by you. I can fix this along with the current bug or I can file a separate test bug. What is your suggestion? Can

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-24 Thread Semyon Sadetsky
On 24.11.2016 16:56, Sergey Bylokhov wrote: On 18.11.16 14:51, Semyon Sadetsky wrote: On 11/18/2016 1:20 PM, Sergey Bylokhov wrote: On 18.11.16 12:40, Semyon Sadetsky wrote: On 15.11.2016 17:06, Sergey Bylokhov wrote: What test did you use to verify the bug? It seems that the test in clos

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-24 Thread Sergey Bylokhov
On 18.11.16 14:51, Semyon Sadetsky wrote: On 11/18/2016 1:20 PM, Sergey Bylokhov wrote: On 18.11.16 12:40, Semyon Sadetsky wrote: On 15.11.2016 17:06, Sergey Bylokhov wrote: What test did you use to verify the bug? It seems that the test in closed ws was reworked by Manajit and moved to the

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-18 Thread Semyon Sadetsky
On 11/18/2016 1:20 PM, Sergey Bylokhov wrote: On 18.11.16 12:40, Semyon Sadetsky wrote: On 15.11.2016 17:06, Sergey Bylokhov wrote: What test did you use to verify the bug? It seems that the test in closed ws was reworked by Manajit and moved to the open ws. But closed version was existed til

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-18 Thread Sergey Bylokhov
On 18.11.16 12:40, Semyon Sadetsky wrote: On 15.11.2016 17:06, Sergey Bylokhov wrote: What test did you use to verify the bug? It seems that the test in closed ws was reworked by Manajit and moved to the open ws. But closed version was existed till today. (Note probably the fix for both tests

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-18 Thread Semyon Sadetsky
On 15.11.2016 17:06, Sergey Bylokhov wrote: What test did you use to verify the bug? It seems that the test in closed ws was reworked by Manajit and moved to the open ws. But closed version was existed till today. (Note probably the fix for both tests passed. JDK-8145784 should be reworked be

Re: [9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-15 Thread Sergey Bylokhov
What test did you use to verify the bug? It seems that the test in closed ws was reworked by Manajit and moved to the open ws. But closed version was existed till today. (Note probably the fix for JDK-8145784 should be reworked because it return behavior which was before JDK-8013116). On 11.11

[9] Review request for 8169133: This time, on Windows: java/awt/Robot/SpuriousMouseEvents/SpuriousMouseEvents.java

2016-11-11 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8169133 webrev: http://cr.openjdk.java.net/~ssadetsky/8169133/webrev.00/ Screen specific AWT robot was not implemented on Windows platform. The fix proposes the missed implementation. --Semyon