Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-10-06 Thread Avik Niyogi
Looks good to me. > On 06-Oct-2016, at 4:20 pm, Sergey Bylokhov > wrote: > > Looks fine. > > On 05.10.16 12:57, Manajit Halder wrote: >> Hi Sergey, >> >> Thanks for the comments. Please review the updated webrev. >> http://cr.openjdk.java.net/~mhalder/816/webrev.04/ >> >> The “frame” can

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-10-06 Thread Sergey Bylokhov
Looks fine. On 05.10.16 12:57, Manajit Halder wrote: Hi Sergey, Thanks for the comments. Please review the updated webrev. http://cr.openjdk.java.net/~mhalder/816/webrev.04/ The “frame” can’t be a local variable as it is used in two different threads inside the function. Thanks, Manajit

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-10-05 Thread Manajit Halder
Hi Sergey, Thanks for the comments. Please review the updated webrev. http://cr.openjdk.java.net/~mhalder/816/webrev.04/ The “frame” can’t be a local variable as it is used in two different threads inside the function. Thanks, Manaji

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-10-04 Thread Sergey Bylokhov
Hi, Manajit. It looksbetter, bet it can be improved a little bit. - you should not skip exceptions in the run(); - It will be good to select the frame by mouse click before pressing the key, otherwise you can run somthing else. - I suggest to iterate the code in main a few times in the loop(I

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-10-04 Thread Manajit Halder
Hi Sergey, Thanks for the review. Changes in CRobot.m are removed and added a jtreg test case. Please review the webrev. http://cr.openjdk.java.net/~mhalder/816/webrev.03/ Thanks, Manajit > On 27-Sep-2016, at 4:15 pm, Sergey Bylokho

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-09-27 Thread Sergey Bylokhov
On 27.09.16 11:51, Manajit Halder wrote: Hi Sergey, Thanks for the comment. “self.javaToMacKeyMap is retaining the reference. Please review the modified code: http://cr.openjdk.java.net/~mhalder/816/webrev.02/ The changes in CRobot.m is unnecessary? I also suggest to write the test. Rece

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-09-27 Thread Manajit Halder
Hi Sergey, Thanks for the comment. “self.javaToMacKeyMap is retaining the reference. Please review the modified code: http://cr.openjdk.java.net/~mhalder/816/webrev.02/ Thanks, Manajit > On 23-Sep-2016, at 10:24 pm, Sergey Bylokhov

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-09-23 Thread Sergey Bylokhov
On 21.09.16 16:01, Manajit Halder wrote: Hi Sergey, Thanks for the comment. Access to "instance" is not broken. The problem is with the dictionary variable "javaToMacKeyMap" within the "instance" reference. The dictionary is not getting initialised for the second time when singleton method is c

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-09-23 Thread Sergey Bylokhov
On 21.09.16 16:01, Manajit Halder wrote: Access to "instance" is not broken. The problem is with the dictionary variable "javaToMacKeyMap" within the "instance" reference. The dictionary is not getting initialised for the second time when singleton method is called for the second time. The dictio

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-09-21 Thread Manajit Halder
Hi Sergey, Thanks for the comment. Access to "instance" is not broken. The problem is with the dictionary variable "javaToMacKeyMap" within the "instance" reference. The dictionary is not getting initialised for the second time when singleton method is called for the second time. The dictionar

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-09-19 Thread Sergey Bylokhov
Hi, Manajit. It seems that after the fix "(CRobotKeyCodeMapping *) sharedInstance" returns the new object per invocation, so it is not really sharedInstance. I am not sure I understand what is wrong in the current code, from the my point of view this is a correct singleton. It it true that the

[9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

2016-09-19 Thread Manajit Halder
Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-816 Webrev: http://cr.openjdk.java.net/~mhalder/816/webrev.00/ Issue: [macosx] VM crashe