Re: [OpenJDK 2D-Dev] Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

2012-01-26 Thread Chris Hegarty
Reviving an old thread... Since CR 7110017 ( the VM part of this change ) has been in hsx for a few promoted builds now, I would like to proceed with the jdk part of these changes. You guys already reviewed this, and the changes are the still the same. I just want to give you the heads up as

Re: [OpenJDK 2D-Dev] Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

2011-11-11 Thread Phil Race
Sergey Bylokhov is working on removing a lot of the dead motif related code under http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6996291. I don't know where exactly you are looking but there's a good chance it'll be gone soon. -phil. On 11/10/2011 9:06 PM, David Holmes wrote: PS. I was als

Re: Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

2011-11-11 Thread Chris Hegarty
David, Thanks for catching the issue in java_props_md. I should have seen this. Update webrev: - incorporated Davids changes to java_props_md - "fixed" comments referring to libmawt in awt_LoadLibrary.c http://cr.openjdk.java.net/~chegar/7110002/webrev.01/webrev/ Thanks, -Chris. On 11/11/

Re: Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

2011-11-10 Thread David Holmes
PS. I was also going to query about the continued existence of other Motif related code - even libmawt is still referenced in the comments of a couple of Motif specific functions. Is that now "dead" code? David On 11/11/2011 3:00 PM, David Holmes wrote: Chris, I just discovered that there is

Re: Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

2011-11-10 Thread David Holmes
Chris, I just discovered that there is an additional change needed for JAVASE_EMBEDDED. On the JDK side we also have a check to try and determine if this is a headless or headful JRE, because a true headless-JRE requires the special HToolkit. That code checks for the existence of lib//xawt to

Re: [OpenJDK 2D-Dev] Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

2011-11-09 Thread Phil Race
Ditto for 2D. -phil. On 11/9/2011 5:19 AM, Artem Ananiev wrote: Hi, Chris, the fix looks fine. Thanks, Artem On 11/9/2011 4:28 PM, Chris Hegarty wrote: Hi, CR 7110002 proposes to rename the unix version of the awt toolkit libraries to allow them reside in the same directory as libawt. xaw

Re: Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

2011-11-09 Thread Alan Bateman
On 09/11/2011 12:28, Chris Hegarty wrote: Hi, CR 7110002 proposes to rename the unix version of the awt toolkit libraries to allow them reside in the same directory as libawt. xawt/libmawt.so -> libawt_xawt.so headless/libmawt.so -> libawt_headless.so The proposed new library names ar

Re: Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

2011-11-09 Thread Artem Ananiev
Hi, Chris, the fix looks fine. Thanks, Artem On 11/9/2011 4:28 PM, Chris Hegarty wrote: Hi, CR 7110002 proposes to rename the unix version of the awt toolkit libraries to allow them reside in the same directory as libawt. xawt/libmawt.so -> libawt_xawt.so headless/libmawt.so -> libawt_headle

Code Review 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt

2011-11-09 Thread Chris Hegarty
Hi, CR 7110002 proposes to rename the unix version of the awt toolkit libraries to allow them reside in the same directory as libawt. xawt/libmawt.so -> libawt_xawt.so headless/libmawt.so -> libawt_headless.so The proposed new library names are prefixed with 'libawt' since they are su