On Thu, 14 Jan 2021 04:54:17 GMT, Alexander Zuev wrote:
>> Creating a native peer for pushbutton accessibility role on Max OS X.
>> The process of choosing of what peer to initialize is clunky so
>> might be addressed in the future.
>
> Alexander Zuev has updated the pull request incrementally wi
On Thu, 14 Jan 2021 00:17:57 GMT, Sergey Bylokhov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Replaced #include with #import for consistency
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComp
> Creating a native peer for pushbutton accessibility role on Max OS X.
> The process of choosing of what peer to initialize is clunky so
> might be addressed in the future.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Added AWT_
On Tue, 12 Jan 2021 06:08:10 GMT, Alexander Zuev wrote:
>> Creating a native peer for pushbutton accessibility role on Max OS X.
>> The process of choosing of what peer to initialize is clunky so
>> might be addressed in the future.
>
> Alexander Zuev has updated the pull request incrementally wi
On Wed, 13 Jan 2021 06:33:19 GMT, Sergey Bylokhov wrote:
>> I know. But in this case that was not enough - that still caused weird
>> compilation glitches like full compilation works but incremental calculation
>> gives compilation error about usage of non-initialized variables. Guards
>> help
On Wed, 13 Jan 2021 06:03:09 GMT, Alexander Zuev wrote:
>> The headers in the obj-c usually do not have guards because they are
>> included via "#import"
>
> I know. But in this case that was not enough - that still caused weird
> compilation glitches like full compilation works but incremental
On Wed, 13 Jan 2021 03:02:04 GMT, Sergey Bylokhov wrote:
>> Yes, since the CommonComponentAccessibility being imported from the base
>> class sometimes it causes compilation glitches - guess ObjC is not a big fan
>> of forward-declaration. Adding header guard helps. And since i'm not
>> planni
On Tue, 12 Jan 2021 06:04:32 GMT, Alexander Zuev wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ButtonAccessibility.h
>> line 25:
>>
>>> 23: * questions.
>>> 24: */
>>> 25:
>>
>> There are no header guard here. Is it left intentionally?
>
> Yes, since the CommonComponentAcce
On Thu, 17 Dec 2020 07:50:08 GMT, Pankaj Bansal wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved the new components implementations to the separate files.
>> Changed the iitialization procedure to a class
On Thu, 17 Dec 2020 08:18:26 GMT, Pankaj Bansal wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved the new components implementations to the separate files.
>> Changed the iitialization procedure to a class
> Creating a native peer for pushbutton accessibility role on Max OS X.
> The process of choosing of what peer to initialize is clunky so
> might be addressed in the future.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Replaced #
On Fri, 18 Dec 2020 00:19:59 GMT, Sergey Bylokhov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved the new components implementations to the separate files.
>> Changed the iitialization procedure to a clas
> Creating a native peer for pushbutton accessibility role on Max OS X.
> The process of choosing of what peer to initialize is clunky so
> might be addressed in the future.
Alexander Zuev has updated the pull request incrementally with two additional
commits since the last revision:
- Fixed ye
> Creating a native peer for pushbutton accessibility role on Max OS X.
> The process of choosing of what peer to initialize is clunky so
> might be addressed in the future.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contain
On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev wrote:
>> Creating a native peer for pushbutton accessibility role on Max OS X.
>> The process of choosing of what peer to initialize is clunky so
>> might be addressed in the future.
>
> Alexander Zuev has updated the pull request incrementally wi
On Wed, 16 Dec 2020 17:59:02 GMT, Alexander Zuev wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m
>> line 1990:
>>
>>> 1988:
>>> 1989: JNIEnv* env = [ThreadUtilities getJNIEnv];
>>> 1990: JNFCallStaticVoidMethod(env, jm_doAccessibleAction, [self
>
On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev wrote:
>> Creating a native peer for pushbutton accessibility role on Max OS X.
>> The process of choosing of what peer to initialize is clunky so
>> might be addressed in the future.
>
> Alexander Zuev has updated the pull request incrementally wi
On Tue, 1 Dec 2020 22:49:08 GMT, Alexander Zuev wrote:
> Creating a native peer for pushbutton accessibility role on Max OS X.
> The process of choosing of what peer to initialize is clunky so
> might be addressed in the future.
@azuev-java I think you need to rebase this PR as you started worki
On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev wrote:
>> Creating a native peer for pushbutton accessibility role on Max OS X.
>> The process of choosing of what peer to initialize is clunky so
>> might be addressed in the future.
>
> Alexander Zuev has updated the pull request incrementally wi
On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev wrote:
>> Creating a native peer for pushbutton accessibility role on Max OS X.
>> The process of choosing of what peer to initialize is clunky so
>> might be addressed in the future.
>
> Alexander Zuev has updated the pull request incrementally wi
On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev wrote:
>> Creating a native peer for pushbutton accessibility role on Max OS X.
>> The process of choosing of what peer to initialize is clunky so
>> might be addressed in the future.
>
> Alexander Zuev has updated the pull request incrementally wi
> Creating a native peer for pushbutton accessibility role on Max OS X.
> The process of choosing of what peer to initialize is clunky so
> might be addressed in the future.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Moved the
On Fri, 4 Dec 2020 02:49:07 GMT, Sergey Bylokhov wrote:
> Maybe it is better to change the used file hierarchy?
That probably a good idea. Uploading a new fix version.
-
PR: https://git.openjdk.java.net/jdk/pull/1549
On Fri, 4 Dec 2020 02:51:19 GMT, Sergey Bylokhov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved the new components implementations to the separate files.
>> Changed the iitialization procedure to a class
On Tue, 1 Dec 2020 22:49:08 GMT, Alexander Zuev wrote:
> Creating a native peer for pushbutton accessibility role on Max OS X.
> The process of choosing of what peer to initialize is clunky so
> might be addressed in the future.
Maybe it is better to change the used file hierarchy? So all new na
Creating a native peer for pushbutton accessibility role on Max OS X.
The process of choosing of what peer to initialize is clunky so
might be addressed in the future.
-
Commit messages:
- JDK-8256109: Create implementation for NSAccessibilityButton protocol
- Merge pull request #5
26 matches
Mail list logo
