Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-12 Thread Alexey Ushakov
On Fri, 9 Apr 2021 22:41:37 GMT, Sergey Bylokhov wrote: >> Yes, it's IEC61966-2.1 > > Ok, found the issue on my side, by default the test uses the OGL, not a metal. Good news! @mrserb Could you sponsor this pull request? - PR: https://git.openjdk.java.net/jdk/pull/3390

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Jayathirth D V
On Sat, 10 Apr 2021 05:52:16 GMT, Jayathirth D V wrote: >> Alexey Ushakov has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Jayathirth D V
On Fri, 9 Apr 2021 11:55:46 GMT, Alexey Ushakov wrote: >> Perform replaceSurfaceData on insets change > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of t

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-09 Thread Jayathirth D V
On Wed, 7 Apr 2021 23:04:04 GMT, Alexey Ushakov wrote: > Perform replaceSurfaceData on insets change @avu I am running CI tests, please wait until EOD for integration. - PR: https://git.openjdk.java.net/jdk/pull/3390

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 11:55:46 GMT, Alexey Ushakov wrote: >> Perform replaceSurfaceData on insets change > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of t

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 21:26:18 GMT, Alexey Ushakov wrote: >> macOS 11.2(20D64), did you set the sRGB color profile in the settings? > > Yes, it's IEC61966-2.1 Ok, found the issue on my side, by default the test uses the OGL, not a metal. - PR: https://git.openjdk.java.net/jdk/pull/339

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Alexey Ushakov
On Fri, 9 Apr 2021 19:59:38 GMT, Sergey Bylokhov wrote: >> What OS version do you have? > > macOS 11.2(20D64), did you set the sRGB color profile in the settings? Yes, it's IEC61966-2.1 - PR: https://git.openjdk.java.net/jdk/pull/3390

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 19:48:15 GMT, Alexey Ushakov wrote: >> It's strange. Just rerun it with the following command line: >> >> jtreg -Dsun.java2d.metal=True >> -testjdk:/Users/user/ws/jbr-dev/build/macosx-x86_64-server-release/images/jdk-bundle/jdk-17.jdk/Contents/Home >> >> test/jdk/java/awt/W

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Alexey Ushakov
On Fri, 9 Apr 2021 19:38:15 GMT, Alexey Ushakov wrote: >> test/jdk/java/awt/Window/FullWindowContentTest/FullWindowContentRenderTest.java >> line 29: >> >>> 27: * @key headful >>> 28: * @bug 8258788 >>> 29: * @summary [macosx] full window content option rendering test >> >> The test passed

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Alexey Ushakov
On Fri, 9 Apr 2021 17:33:46 GMT, Sergey Bylokhov wrote: >> Alexey Ushakov has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 11:55:46 GMT, Alexey Ushakov wrote: >> Perform replaceSurfaceData on insets change > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of t

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Alexey Ushakov
> Perform replaceSurfaceData on insets change Alexey Ushakov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last r

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v2]

2021-04-09 Thread Alexey Ushakov
On Thu, 8 Apr 2021 21:31:29 GMT, Sergey Bylokhov wrote: >> Alexey Ushakov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8258788: incorrect response to change in window insets [lanai] >> >> Moved replaceSurfaceData to more appropri

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v2]

2021-04-09 Thread Alexey Ushakov
> Perform replaceSurfaceData on insets change Alexey Ushakov has updated the pull request incrementally with one additional commit since the last revision: 8258788: incorrect response to change in window insets [lanai] Moved replaceSurfaceData to more appropriate place - Cha

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-08 Thread Sergey Bylokhov
On Wed, 7 Apr 2021 23:04:04 GMT, Alexey Ushakov wrote: > Perform replaceSurfaceData on insets change src/java.desktop/macosx/classes/sun/lwawt/LWWindowPeer.java line 741: > 739: if (CGraphicsDevice.usingMetalPipeline() && invalid) { > 740: replaceSurfaceData(); > 741

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-08 Thread Alexey Ushakov
On Wed, 7 Apr 2021 20:29:12 GMT, Alexey Ushakov wrote: >>> @avu Test passes without fix also. >> @jayathirthrao Could you provide the details about your configuration along >> with parameters passed to jtreg ? > >> @avu I am running test in 13 inch Macbook Early 2015 with integrated Intel >> Ir

RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-07 Thread Alexey Ushakov
Perform replaceSurfaceData on insets change - Commit messages: - 8258788: incorrect response to change in window insets [lanai] Changes: https://git.openjdk.java.net/jdk/pull/3390/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3390&range=00 Issue: https://bugs.openjd

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v4]

2021-04-07 Thread Alexey Ushakov
> Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT property. > MTLLayer.h header cleanup. Alexey Ushakov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of th

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-07 Thread Alexey Ushakov
On Tue, 6 Apr 2021 12:51:47 GMT, Alexey Ushakov wrote: >>> Is it possible to automatically test it? >> >> Yes, just added the test. > >> @avu Test passes without fix also. > @jayathirthrao Could you provide the details about your configuration along > with parameters passed to jtreg ? > @avu I

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-06 Thread Sergey Bylokhov
On Mon, 5 Apr 2021 10:34:21 GMT, Alexey Ushakov wrote: >>> Can you check that it will work in the "new" tabbed mode on big sur as well? >> >> Could you suggest any working test scenario? My simple test (below) just >> hangs even with OGL: >> >> import java.awt.FlowLayout; >> import java.util.O

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-06 Thread Jayathirth D V
On Tue, 6 Apr 2021 12:51:47 GMT, Alexey Ushakov wrote: > > @avu Test passes without fix also. > > @jayathirthrao Could you provide the details about your configuration along > > with parameters passed to jtreg ? @avu I am running test in 13 inch Macbook Early 2015 with integrated Intel Iris Gr

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-06 Thread Jayathirth D V
On Tue, 6 Apr 2021 12:03:14 GMT, Jayathirth D V wrote: > > > Is it possible to automatically test it? > > > > > > Yes, just added the test. > > @avu Test passes without fix also. @aghaisas Please verify the regression test behavior from your end also. - PR: https://git.openjdk.j

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-06 Thread Alexey Ushakov
On Fri, 2 Apr 2021 11:41:12 GMT, Alexey Ushakov wrote: >> Is it possible to automatically test it? > >> Is it possible to automatically test it? > > Yes, just added the test. > @avu Test passes without fix also. @jayathirthrao Could you provide the details about your configuration along with p

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-06 Thread Jayathirth D V
On Tue, 6 Apr 2021 12:03:14 GMT, Jayathirth D V wrote: >>> Is it possible to automatically test it? >> >> Yes, just added the test. > >> > Is it possible to automatically test it? >> >> Yes, just added the test. > > @avu Test passes without fix also. Verified test case attached in JBS : http

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-06 Thread Jayathirth D V
On Fri, 2 Apr 2021 11:41:12 GMT, Alexey Ushakov wrote: > > Is it possible to automatically test it? > > Yes, just added the test. @avu Test passes without fix also. - PR: https://git.openjdk.java.net/jdk/pull/3308

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-05 Thread Alexey Ushakov
On Mon, 5 Apr 2021 10:29:20 GMT, Alexey Ushakov wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 1171: >> >>> 1169: layer.leftInset = >>> (jint)(screenContentRect.origin.x - frame.origin.x); >>> 1170: } >>> 1171:

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-05 Thread Alexey Ushakov
On Thu, 1 Apr 2021 15:18:21 GMT, Sergey Bylokhov wrote: > Can you check that it will work in the "new" tabbed mode on big sur as well? Could you suggest any working test scenario? My simple test (below) just hangs even with OGL: import java.awt.FlowLayout; import java.util.Objects; import java

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-02 Thread Alexey Ushakov
> Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT property. > MTLLayer.h header cleanup. Alexey Ushakov has updated the pull request incrementally with one additional commit since the last revision: 8258788: incorrect response to change in window insets [lanai] Correc

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v2]

2021-04-02 Thread Kevin Rushforth
On Fri, 2 Apr 2021 11:44:52 GMT, Alexey Ushakov wrote: >> Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT >> property. MTLLayer.h header cleanup. > > Alexey Ushakov has updated the pull request incrementally with one additional > commit since the last revision: > > 825878

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-02 Thread Alexey Ushakov
On Thu, 1 Apr 2021 15:15:32 GMT, Sergey Bylokhov wrote: > Is it possible to automatically test it? Yes, just added the test. - PR: https://git.openjdk.java.net/jdk/pull/3308

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v2]

2021-04-02 Thread Alexey Ushakov
> Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT property. > MTLLayer.h header cleanup. Alexey Ushakov has updated the pull request incrementally with one additional commit since the last revision: 8258788: incorrect response to change in window insets [lanai] Added

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-01 Thread Sergey Bylokhov
On Thu, 1 Apr 2021 14:38:52 GMT, Alexey Ushakov wrote: > Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT property. > MTLLayer.h header cleanup. Is it possible to automatically test it? src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 1171: > 1169:

RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-01 Thread Alexey Ushakov
Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT property. MTLLayer.h header cleanup. - Commit messages: - 8258788: incorrect response to change in window insets [lanai] Changes: https://git.openjdk.java.net/jdk/pull/3308/files Webrev: https://webrevs.openjdk.ja