Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-27 Thread Prasanta Sadhukhan
Chamyal; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net> *Subject:* RE: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X Hi Ajit, Thankyou for the review. Updated patch as per review co

Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-27 Thread Prem Balakrishnan
Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net Subject: Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X Hi Prem, +1 to 8168292 but one thing is that this issue is created to enable to work on 8168291 and was mentioned

Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-26 Thread Prasanta Sadhukhan
:*Ajit Ghaisas *Sent:* Monday, October 24, 2016 2:00 PM *To:* Prem Balakrishnan; Alexander Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net> *Subject:* RE: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java f

Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-25 Thread Ajit Ghaisas
"mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net Subject: RE: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X Hi Prem, I know this is compilation fix, but still few corrections can be made to the t

Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-24 Thread Prem Balakrishnan
@openjdk.java.net Subject: RE: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X Hi Prem, I know this is compilation fix, but still few corrections can be made to the test. 1. Please replace generic imports to specific class

Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-24 Thread Ajit Ghaisas
utton in it." Should be : "User sees a Frame with a button on it." Regards, Ajit From: Prem Balakrishnan Sent: Thursday, October 20, 2016 3:00 PM To: Alexander Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net Subject: Review Request : JDK-8168292 [TestBug]Tes

Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

2016-10-20 Thread Prem Balakrishnan
Hi, Please review the patch. Test Bug: https://bugs.openjdk.java.net/browse/JDK-8168292 Webrev: http://cr.openjdk.java.net/~pkbalakr/8168292/webrev.00/ Compilation error: Can't find library\: ../../../regtesthelpers Fix: updated the library path Regards, Prem